From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80196C3DA49 for ; Thu, 25 Jul 2024 13:25:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF4B56B0093; Thu, 25 Jul 2024 09:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA4C96B0095; Thu, 25 Jul 2024 09:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6DAC6B0096; Thu, 25 Jul 2024 09:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A403F6B0093 for ; Thu, 25 Jul 2024 09:25:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 36B7F1A106D for ; Thu, 25 Jul 2024 13:25:16 +0000 (UTC) X-FDA: 82378346232.03.78D25C0 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf11.hostedemail.com (Postfix) with ESMTP id 8AC0E40017 for ; Thu, 25 Jul 2024 13:25:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RP6PGTQw; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721913864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gTiASqCvEjVysVjVj++iYK8OTORjLn710t1qDdJ6Zuk=; b=fsBNQQWCWDawaIBJULGsxZSYsonzvIj42iuGd55KSTxHl4nJGrB5dV+U8pwF//uAvWTGBC /LGh6ZZ4oCSHIJdk54qHPUiIP07cfsmE57TaDbLqQ2wmsh35f4HD4NMBDFRaGEMP9D+oLP znqg8h8ld92WSwhj11kRW0mRTHSNeiA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721913864; a=rsa-sha256; cv=none; b=iB8JjYnZTaeRTyXje9TBXrWaqqI3AgOPTOwLc8m1GP/Q21CnteYThkbSYyJTgbpbU63Mdz ltVmbNgn0Dc8HlQSLkR7IsAivWFMDubAGyXO/xolL2rHF1rA5E5lZMi/c54/h6gI9tS78O 1bjA+ZnJQCGJY3FjR3KTDuIrJT1ZK2g= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RP6PGTQw; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721913913; x=1753449913; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FquZqCdRSkWOmjxMsAuK0N+4yE04yJ/Bz7POqAHeIdc=; b=RP6PGTQwifhsQb7BWYeclVS+9A8Jpq+q2BGfKBPLDfwF8i1cwgbcGQ4O w8Dd9r0ZJJ3gPDulgTNgLztWpPZE1FgUyqjGuI85NgfdSNzaImNGrF3jE y00onJqw1NOOliqAswhfh0xUETFLZpI0Gl+jA515ufYEYogWqd8rlbs1W JSzdCo3Gml0Tt6x9hoIh9Ae91H2ZQaY1mPH/uKhlwokbqSV47/H9N0sQn jEypQ3i8MszQfWgwoznQoS8iONg+Wbzyn9dsKbsFu9tJJ41yZwh4Asbfi Rs7LkvzMuGUPbT2SCShcsuEqsH9pWsmdUwtNczFPhGmk6ioN9O2KDlhgj A==; X-CSE-ConnectionGUID: vfPRyAgFQca6uWYfyybIlQ== X-CSE-MsgGUID: 6fEs4WosRreHUischxnHDw== X-IronPort-AV: E=McAfee;i="6700,10204,11144"; a="23457015" X-IronPort-AV: E=Sophos;i="6.09,236,1716274800"; d="scan'208";a="23457015" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2024 06:25:11 -0700 X-CSE-ConnectionGUID: ciqpoQn/Q5qKsjHNf/Em5A== X-CSE-MsgGUID: PXLIW9fZRlyg1CN4SKi1mQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,236,1716274800"; d="scan'208";a="53692564" Received: from lkp-server01.sh.intel.com (HELO 68891e0c336b) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 25 Jul 2024 06:25:07 -0700 Received: from kbuild by 68891e0c336b with local (Exim 4.96) (envelope-from ) id 1sWySu-000o8m-39; Thu, 25 Jul 2024 13:25:04 +0000 Date: Thu, 25 Jul 2024 21:24:09 +0800 From: kernel test robot To: David Laight , "'linux-kernel@vger.kernel.org'" , 'Linus Torvalds' Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, "'Matthew Wilcox (Oracle)'" , 'Christoph Hellwig' , 'Andrew Morton' , Linux Memory Management List , 'Andy Shevchenko' , 'Dan Carpenter' , 'Arnd Bergmann' , "'Jason@zx2c4.com'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' Subject: Re: [PATCH 4/7] minmax: Simplify signedness check Message-ID: <202407252100.fDFchC5O-lkp@intel.com> References: <03601661326c4efba4e618ead15fa0e2@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03601661326c4efba4e618ead15fa0e2@AcuMS.aculab.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8AC0E40017 X-Stat-Signature: 4baytc694bwupa864uwqyhb5tgpg7g6j X-HE-Tag: 1721913912-749774 X-HE-Meta: U2FsdGVkX19ks3gBW+J7Zi0IhmsvgarEetgVGQkd2HyZ09e9e8ctZOAm/YtqQagm9NmU6TLum8+tzMZ0gC07pzzgn5E1exh0NGfM/I3nm7qiDOw4sBeP6pxnXAXBe2ZWMwER7b7Jzu9d359U6yrwrJiHB2u//Ee7VJ8Teeh8X7xZ4GxVG6MwFicn6hmun2MtA/YIX2304qpxM0S6jiw5E54fUonDOxdhYRqbXN9tAfWBdN4nGhf4jYj4YEmlVEHI7BA2zv4DuLu6iQIwKXF9gzB04DOtok79ucOeH65aekOTU0ziOZ+O3g9laydfKK2FL2lQV2kEbB0AX+/gHYGeYnMjPSxOM68EDR6EY6sj/WoZSkLgPx5kKyoY44hoHHSarOtPZlM5peYByuKgDGYzowry0D2D3S3wn82UAj/Wdh1u7J3DzwsKkFPfr8GW5bIjzIc0jHXjCE/kWnPHNgKUbuv3YaELmDdcmSdlvNaZo8spJdfetnRZh/fPMXfx85dIjaaer+HNb8i0iAAdlWJVzC0AxzMc8EXI3znktUGO6UifY5gXVDGrcfVXe+8/wF1wX5HQNwO52cnzv7gN99hOuvQFglfikc6qhQDM8YSut8SuUzIhq8uTL9YTsNuBu+VUEg5T7AVQc04DouOQbka6hfTL7dxIXHljXgzKTJdFdd3npYN8A74zgYbgzpb+n3y0BKBYkHK/lVp00GbZve50htpk191C030EN6v8IqjdBuv3eH0dpkt0mRvegtiVI/0kLAaOhkx+Jss26p2YbxoxBIoJjlEJCp1QBEoSH4d1DlcftEh8sxFIq3jRB7K8kbDA+0lkC9dRVBd0hX/T0E30btzAlfQDGx5ZxE0iUSFhheV8r7lYrwNKg3SC4lwpILY6B2QfIy09szzhj84fTI+FPcBvD8Dj6PGxBqmgg9Hh0GSPxzR0DcZUP4Evgumawf1garnmoXpdDm5FDnfUFbj JXNQJdvw zA5JISsNq5PJWBZc1a4PlYfoEV2YUg4sLl4d3ObvrICY+JU74H4nCDpO+VdW9/pl80A0VfMQJ5SlEEERxlbucrF1H6MoAEoxnsPdd8BIfaQQEO+lUtYegS3d6T29drk94gLop7eXFZz5b87ycPSpre04ZTfPb/ejewdL8gY938CNwjCUdK6Q6ogpXDVZ4tO4k8C16xj2ANCQLVoKPF5Cqhlc+WGgEdRrDYSKbXyOJGUWrZ5TDSuG9EwKkZsBVOt0/IcvC3LIeUjnf4oPrenU2JwfKYBx1e+b0ntdztBwJs0S+xZSV1otXzKd0xWL1Qg+SqvR//OFgAo4jBGjJPYyk3J43fwWcOAf3HkD/yLQFcC0x0mnDRrtvNPkazPhahxxVS5TEdzfi7UEu97K1AyysOFRJ7HfKPSRpYAqNdiwXWWSWEfLq9OeJRChxBtWp70uFZFZNJ4iUEDNLyTDmAfjqfnQ/u/mHrMr4azv0x+CHLDgOMpZlLGF8u/ykoBQMY1b82+Dqj8jn+5hKwjoUu0nL+pv/gA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, kernel test robot noticed the following build errors: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v6.10 next-20240725] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/David-Laight/minmax-Put-all-the-clamp-definitions-together/20240724-224832 base: linux/master patch link: https://lore.kernel.org/r/03601661326c4efba4e618ead15fa0e2%40AcuMS.aculab.com patch subject: [PATCH 4/7] minmax: Simplify signedness check config: mips-loongson1b_defconfig (https://download.01.org/0day-ci/archive/20240725/202407252100.fDFchC5O-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240725/202407252100.fDFchC5O-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202407252100.fDFchC5O-lkp@intel.com/ All errors (new ones prefixed by >>): >> crypto/skcipher.c:83:9: error: static assertion expression is not an integral constant expression return max(start, end_page); ^~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:70:19: note: expanded from macro 'max' #define max(x, y) __careful_cmp(max, x, y) ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:56:3: note: expanded from macro '__careful_cmp' __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:49:17: note: expanded from macro '__cmp_once' _Static_assert(__types_ok(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:38:2: note: expanded from macro '__types_ok' ((__is_ok_signed(x) && __is_ok_signed(y)) || \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ crypto/skcipher.c:83:9: note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression include/linux/minmax.h:70:19: note: expanded from macro 'max' #define max(x, y) __careful_cmp(max, x, y) ^ include/linux/minmax.h:56:3: note: expanded from macro '__careful_cmp' __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y))) ^ include/linux/minmax.h:49:17: note: expanded from macro '__cmp_once' _Static_assert(__types_ok(x, y), \ ^ include/linux/minmax.h:38:4: note: expanded from macro '__types_ok' ((__is_ok_signed(x) && __is_ok_signed(y)) || \ ^ include/linux/minmax.h:34:27: note: expanded from macro '__is_ok_signed' #define __is_ok_signed(x) is_signed_type(typeof((x) + 0)) ^ include/linux/compiler.h:273:32: note: expanded from macro 'is_signed_type' #define is_signed_type(type) (((type)(-1)) < (__force type)1) ^ 1 error generated. -- >> lib/lzo/lzo1x_compress.c:53:33: error: static assertion expression is not an integral constant expression const unsigned char *limit = min(ip_end, ip + MAX_ZERO_RUN_LENGTH + 1); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:63:19: note: expanded from macro 'min' #define min(x, y) __careful_cmp(min, x, y) ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:56:3: note: expanded from macro '__careful_cmp' __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:49:17: note: expanded from macro '__cmp_once' _Static_assert(__types_ok(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:38:2: note: expanded from macro '__types_ok' ((__is_ok_signed(x) && __is_ok_signed(y)) || \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/lzo/lzo1x_compress.c:53:33: note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression include/linux/minmax.h:63:19: note: expanded from macro 'min' #define min(x, y) __careful_cmp(min, x, y) ^ include/linux/minmax.h:56:3: note: expanded from macro '__careful_cmp' __cmp_once(op, x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y))) ^ include/linux/minmax.h:49:17: note: expanded from macro '__cmp_once' _Static_assert(__types_ok(x, y), \ ^ include/linux/minmax.h:38:4: note: expanded from macro '__types_ok' ((__is_ok_signed(x) && __is_ok_signed(y)) || \ ^ include/linux/minmax.h:34:27: note: expanded from macro '__is_ok_signed' #define __is_ok_signed(x) is_signed_type(typeof((x) + 0)) ^ include/linux/compiler.h:273:32: note: expanded from macro 'is_signed_type' #define is_signed_type(type) (((type)(-1)) < (__force type)1) ^ 1 error generated. vim +83 crypto/skcipher.c b286d8b1a690667 Herbert Xu 2016-11-22 75 b286d8b1a690667 Herbert Xu 2016-11-22 76 /* Get a spot of the specified length that does not straddle a page. b286d8b1a690667 Herbert Xu 2016-11-22 77 * The caller needs to ensure that there is enough space for this operation. b286d8b1a690667 Herbert Xu 2016-11-22 78 */ b286d8b1a690667 Herbert Xu 2016-11-22 79 static inline u8 *skcipher_get_spot(u8 *start, unsigned int len) b286d8b1a690667 Herbert Xu 2016-11-22 80 { b286d8b1a690667 Herbert Xu 2016-11-22 81 u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK); b286d8b1a690667 Herbert Xu 2016-11-22 82 b286d8b1a690667 Herbert Xu 2016-11-22 @83 return max(start, end_page); b286d8b1a690667 Herbert Xu 2016-11-22 84 } b286d8b1a690667 Herbert Xu 2016-11-22 85 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki