From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6CDC3DA49 for ; Thu, 25 Jul 2024 20:21:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76E6F6B0093; Thu, 25 Jul 2024 16:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71E896B0095; Thu, 25 Jul 2024 16:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60D016B0096; Thu, 25 Jul 2024 16:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 431476B0093 for ; Thu, 25 Jul 2024 16:21:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F171C1A132C for ; Thu, 25 Jul 2024 20:21:32 +0000 (UTC) X-FDA: 82379395224.15.0D85649 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id CF30C40010 for ; Thu, 25 Jul 2024 20:21:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="yrqZB9/z"; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721938889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K5+v9ho6thyAgTGLR8tEJPapfpZKWLp1I9S3cKwjKeQ=; b=41gSOkyoZhb3Bp+AXRWWfNs8UXEvuqd51sVtCagEeR0gJNms/QLJ/BPjiwfAi9NZXOuPYN B/NH6llYI3tfn+WbMcwWUkeICYXsXVj4or4O2SapmDIKZ873PWdUFxvbFQC5dZzTz8MhJ6 0MFn2AeJlGsuefRxxGpwieAAg8yR7eE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="yrqZB9/z"; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721938889; a=rsa-sha256; cv=none; b=BBZqRE2ZJxuKbNIaUbIV8IyexPFk6dg4qZadTxF1vDpCPoZlJMxMqMacLPRFPwibj3+6im 5UuFCZ/KQkv6x1zIuZAAVEG83xa1ibwNxcWwITWlBbwOE+CQ2jFqCSvG69aiLkWpVOBene S9fis5YWJWXyYshC9VdTBY9LOHLH0b4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2F095CE0B5C; Thu, 25 Jul 2024 20:21:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3266CC116B1; Thu, 25 Jul 2024 20:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721938885; bh=EonBZNIMfXTTGkQRxL3TuRf0CW1y7npm618AHRH9WP8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yrqZB9/zlqvwOyFLOZjXi+h3U1J0x+irLixtZRkC5A0Q57noJA/pjvNAHZfXKHoeG Q4+bDSmgnxN7mLBntgdCrWcgX9mgrw9ts3kXPiSi/nACJhR9Hk9EcKIGCwRAqecphE hfiU/7AQbkCaZf+SzE5gaoXuA4CCyE0LMyyJz11w= Date: Thu, 25 Jul 2024 13:21:24 -0700 From: Andrew Morton To: Steven Davis Cc: urezki@gmail.com, hch@infradead.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Capitalize letters for readability Message-Id: <20240725132124.b0d317ba1d9e7d1651b71a65@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: pdr47godejmcszoauucz7x6md5rnbwqw X-Rspamd-Queue-Id: CF30C40010 X-Rspamd-Server: rspam11 X-HE-Tag: 1721938890-293513 X-HE-Meta: U2FsdGVkX19NgkZZKH/Ycxd5TfhTEocKrZ2wBlCKJ4EKxbTs5vyu+L/QeXIk11onQudDSiivn967SDWzc8O+YFmCTY/VF0bJPgXnbN7wf65FnuUNY6dK1UTqTkEI9pWbeGp2aSVrhXMQXCThBhjRF9jZVK1u9NDd6syuUqVct8D+D8cJfVLZ4UQwnPtDIPx/cO30+E1BalCLdHoEsa3fqj7u9wssyXTnoOVu6p2X6tK6+4H43hZcYejbKkzYyFwgXHEG1gUqiaroNV9EapP7GjRduWmLYYbCmBK+vP0ycqkhNQ0BsDxt2eoVDfwgos12Q29eJKZgJclJ0jg0B/3W6eyIJj6SfbLB09/fXZcA8I4DXJxV78ENy/kwsL6reJE1lJHl0EQ8aCwLozWcK2vPE/+Ss6PVdX7JeaxQLHvTmrblZdfp1rjuJMW/GzN1yflQKTgxLKRS0NDJBTJ479QdwMt5SKh+Q0dONNE9FkDqO+iQoG3/1KQmwC5AkJuv6bZaK0V3XGY2pNiNsZxziwM7F4+o6qbw523Ak66LROET2aQK0Mn3/30rAsF8ZWW3v68j9mcypTCf6RUd4S2npEZUYnmt2f9NIgVj5K4HViWfEKWCVLOE0IJ97KfeoVRRsc5ZJs4UiQetpXcKQwFxlNAf0SLSJ6xY2b2noQno8QCEkT/rQSjrmG0N8UkI/4AUoYZlGvWHz/aClBE9P32a0ojPgRVWCDKByr1cdnchvZMrtcvA6zylG2UBPx/wnxyszF+jnRebZpdNH1oVFCK4i8CPAcTd0h4jiTeg5idLEdpw8iHQVuztG3GeHLe1c3JGUW7RXb8suvC4LeKiQ6QoHIKZviFsaYvhcymv2sAhLKVrOn8pp/MzCYQIB1LO9ufDAtqfIUIdqVt1C8nPkEOuWjHbvncpy7nPtFChozXMGe3cLKhk7QFpxZNOtRZu7M6Kn+1r1BCzwetduHm6kWcLg0e kd3f/wkR sFPYmEYWQHtsYFkj1eTcb1OkqkAHgnSIN+xcknzkuGWPtf4NR+9EtydgrankWob499bFT2eKTf59V6O7ybhBGgeQqlo0v5ydn1yWRS3v18PtUl1lALZ6teeS6E7PsVKJXc3EgPlezRz8FzamZnOJrkhfyA4axZM8sESLwprNBUNcTOeoBXPi2ItiN0I9PfoICH/RlJZtpPNDjtOwXKKMND8Xd9hx9JbuQsb7oocX0Vs7I5NG50gjh+ygefw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 25 Jul 2024 15:28:29 -0400 Steven Davis wrote: > This patch capitalizes the first letters of error and > debug messages to enhance readability. This is important > for adhering to the style of other error messages in the > kernel, and making it easier and clearer to read the > messages upon the (likely dark) terminal. hm. x1:/usr/src/25> grep " pr_[^(]*.*: [A-Z]" mm/*.c | wc -l 34 x1:/usr/src/25> grep " pr_[^(]*.*: [a-z]" mm/*.c | wc -l 97 If we're going to make this change then we should change everything, add a checkpatch rule, etc. But I do think such a change is too trivial to justify churning the code around.