From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40B3C3DA49 for ; Thu, 25 Jul 2024 19:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3334C6B007B; Thu, 25 Jul 2024 15:47:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BCA86B0082; Thu, 25 Jul 2024 15:47:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 184856B0083; Thu, 25 Jul 2024 15:47:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EDABA6B007B for ; Thu, 25 Jul 2024 15:47:14 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5FE84C13B8 for ; Thu, 25 Jul 2024 19:47:14 +0000 (UTC) X-FDA: 82379308788.09.4730612 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 92CCE12001E for ; Thu, 25 Jul 2024 19:47:12 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qmGKGFbu; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721936767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U63xF0Ke0nIwpN+u5eTfUGXDOdTK9ZNc5H2JFRGffno=; b=2hIFKwCQjkjl9DnlHvR76CsdV/3vIPqu60wuQmkQpPm+sm4WU2zQ3JGrBt5u3houmCl7wG aaP9nKfQrBWGQWwuJ1FATLOTeTmhCsV5pDsdjT+sqAB9IrqmzISa02ruaXoAUb0DGPd6eV eYxzGlYZAQi/vXlUrSjbyKAewNzCGMA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qmGKGFbu; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721936767; a=rsa-sha256; cv=none; b=Z2Ui0wcXd5FOissj4eXoEcdsrw6cqYZVPZMz4AQf72VJS1A8p0iqogW+b0tikTYt9Yt38+ fC4VvKvNCWxPdmiljq67KZdn8Am4sN56LB/E10iirgPTKJi5rpe4gHUiQu1GGtavq13wrN mOpXmF3TxKJd4gKUPijzH1bwLWhL2Uo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 503BA614D5; Thu, 25 Jul 2024 19:47:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1AE6C32786; Thu, 25 Jul 2024 19:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721936831; bh=BU5Wxb6NLkscTs38oI32XkDXG45HkzUFyAf6EuMsgFI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qmGKGFbu0Sr2xjlkH0IBl8lKX6jHJq4jAj0394aZ01rrGZ1fL1RVHm5wZB+opohrv shpYoKjYxJBvYKBM229NXGRIOiBrd5pb/FucJopcf0K9JwWFqil/PxDdM+VRq0hhLC q11ga5PefTHJLb8E3LzNb8zyxRqwa8iUYeobL0tU= Date: Thu, 25 Jul 2024 12:47:10 -0700 From: Andrew Morton To: Shivank Garg Cc: , , , , , Subject: Re: [PATCH] mm/vmstat: Fix placement of per-node stats in /proc/zoneinfo Message-Id: <20240725124710.76206c2c9baa27b8463b825d@linux-foundation.org> In-Reply-To: <20240725105626.824-1-shivankg@amd.com> References: <20240725105626.824-1-shivankg@amd.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 92CCE12001E X-Stat-Signature: 4danh7obyuhahbra3dxrkx9mrkt4ukbn X-Rspam-User: X-HE-Tag: 1721936832-662647 X-HE-Meta: U2FsdGVkX186ym7QT5FzBQMV8OyY/+/cLCGb4v8u8zZO5SyJYr4H+x7WjKgQUCdfVB9YMqYnoG9xdHMokDCmeJPiEC5fLnghJ3T6vBBvp/YP19xGuPRZL+vhlMoaIXOYzkzzzNybCrZUVcGeT0mNTS75go6avaLauj4eSRI6MNWjlQ6WGwR+y43X0iRUJ1AAdliZQY7UdThwlQFOkAJqzdrtPc/AuDluVf9cwuU7cFmWym5X9f/SEKaxeCupMdOCbg0DXKp0k6Gl4VCPzKqvNRAaLAP3rKrZMQQl7d4mPIGfLpYXpHJfLajSNLjH5gVpalGGyQ1iOFWy6t+nTHg4QqUwFK11Y1UaZoPqHxuq5xWMm8/y5VG0250JcdAeTtzAJSsw+KQJuK5qIc+o6MVWGMMu3TcKXwgVs2FfPrSnWBtpQWuR0Ig+UW5SXAwNx6ITO9xPDdTJSIk2z/WRb5PxgwYbNAsBG743v5EDziLSr29MMC8CTaVLU8FOp15Lo1+t6abbzkqkicz99trJ6EoAgVvV57jrPYeDrHi5uYf/60SOJI/UnxRToOT11whDFo2nW2UM9g/p32gCb4s9MlQxdXdQDVSotqoHZHKowxsbTbtYs0NZajtMJd7xauElfA4RdpEFl48eImsV+gl68ZmkRcB/tUE4fulsemoZNG+EwtqTCLgGJAAaHt6g+Mbz6LUxz/EDOZUR4Q+YWfOUAcsi7nj5/QuBawJuGqjORYA/eG1Q+dlq2fMf1DmfvtJ1jNoLjpCLRfAGT8GfUE88S11H9JW5Ambz4o9jXwE5ekyujo6ipdQ71dnqJTXH+FXwggOqCQenetZUrHYWmXYCWkrxKPVkh6qzUs/NYjAZVp/iSDF8fMgoVJooJf80Y1MzfC7noZoemxvk8GoLVLv9HrfhcOmja3AtOI380w71J9iuc8cBju2osVmpUs6WAmEU+ncRFcdSbGLA27pCbKlZ5/7 4J/Zl9Ci GRR8jo1b8tMKyh7+EaCRkK7YuTw2QaAFcOTSWqXdD0H3zOmwqkBwbhCCeBAh9GtWQeWiOjlfsOdqDUvCbxawnEsxRd0GnRhOM206mZIgqu7lNt5GAIWtlryEr5yp6EcQ2tJJ5fP+q53P+FWIu/sdEtUpoY3cO8HvEmy5eONbKmcQ2EdNWcc+jEn9Ywv8Ca/jvS9qyPxWXAILqBMnz8crsPfFGxM7zHC30r37NiWKcHNTic3O9Ffi9lQoabA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 25 Jul 2024 16:26:26 +0530 Shivank Garg wrote: > The per-node stats in /proc/zoneinfo output are incorrectly inserted > between the first populated zone title and its specific stats. This > creates confusion while reading or parsing its output. I pity anyone who has to write a parser for that mess. > This patch relocates the per-node stats at the beginning for each node, > followed by the individual zone statistics. This fix results in a clearer > and more consistent output format. > Fixes: e2ecc8a79ed4 ("mm, vmstat: print node-based stats in zoneinfo file") It's been this way since 2016? Surely there's a risk of breaking existing userspace parsers?