* [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo()
@ 2024-07-25 2:16 Kefeng Wang
2024-07-25 3:33 ` Muchun Song
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kefeng Wang @ 2024-07-25 2:16 UTC (permalink / raw)
To: Muchun Song; +Cc: Andrew Morton, linux-mm, Kefeng Wang
The comment is useless after commit 57a196a58421 ("hugetlb: simplify
hugetlb handling in follow_page_mask") since all follow_huge_foo() are
killed.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
mm/hugetlb.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 0858a1827207..ba176240f764 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -7503,10 +7503,6 @@ __weak unsigned long hugetlb_mask_last_page(struct hstate *h)
#endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */
-/*
- * These functions are overwritable if your architecture needs its own
- * behavior.
- */
bool isolate_hugetlb(struct folio *folio, struct list_head *list)
{
bool ret = true;
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo()
2024-07-25 2:16 [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo() Kefeng Wang
@ 2024-07-25 3:33 ` Muchun Song
2024-07-25 15:43 ` David Hildenbrand
2024-07-25 16:54 ` Vishal Moola
2 siblings, 0 replies; 4+ messages in thread
From: Muchun Song @ 2024-07-25 3:33 UTC (permalink / raw)
To: Kefeng Wang; +Cc: Andrew Morton, linux-mm
> On Jul 25, 2024, at 10:16, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> The comment is useless after commit 57a196a58421 ("hugetlb: simplify
> hugetlb handling in follow_page_mask") since all follow_huge_foo() are
> killed.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo()
2024-07-25 2:16 [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo() Kefeng Wang
2024-07-25 3:33 ` Muchun Song
@ 2024-07-25 15:43 ` David Hildenbrand
2024-07-25 16:54 ` Vishal Moola
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2024-07-25 15:43 UTC (permalink / raw)
To: Kefeng Wang, Muchun Song; +Cc: Andrew Morton, linux-mm
On 25.07.24 04:16, Kefeng Wang wrote:
> The comment is useless after commit 57a196a58421 ("hugetlb: simplify
> hugetlb handling in follow_page_mask") since all follow_huge_foo() are
> killed.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> mm/hugetlb.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 0858a1827207..ba176240f764 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -7503,10 +7503,6 @@ __weak unsigned long hugetlb_mask_last_page(struct hstate *h)
>
> #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */
>
> -/*
> - * These functions are overwritable if your architecture needs its own
> - * behavior.
> - */
> bool isolate_hugetlb(struct folio *folio, struct list_head *list)
> {
> bool ret = true;
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo()
2024-07-25 2:16 [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo() Kefeng Wang
2024-07-25 3:33 ` Muchun Song
2024-07-25 15:43 ` David Hildenbrand
@ 2024-07-25 16:54 ` Vishal Moola
2 siblings, 0 replies; 4+ messages in thread
From: Vishal Moola @ 2024-07-25 16:54 UTC (permalink / raw)
To: Kefeng Wang; +Cc: Muchun Song, Andrew Morton, linux-mm
On Thu, Jul 25, 2024 at 10:16:43AM +0800, Kefeng Wang wrote:
> The comment is useless after commit 57a196a58421 ("hugetlb: simplify
> hugetlb handling in follow_page_mask") since all follow_huge_foo() are
> killed.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-25 16:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-25 2:16 [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo() Kefeng Wang
2024-07-25 3:33 ` Muchun Song
2024-07-25 15:43 ` David Hildenbrand
2024-07-25 16:54 ` Vishal Moola
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox