[PATCH 1/5] memblock test: fix implicit declaration of function 'virt_to_phys'

[PATCH 1/5] memblock test: fix implicit declaration of function 'virt_to_phys'

[Wei Yang]

Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys
alloc") introduce the usage of virt_to_phys(), which is not defined in
memblock tests.

Define it in kernel.h to fix the build error.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 tools/testing/memblock/linux/kernel.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/memblock/linux/kernel.h b/tools/testing/memblock/linux/kernel.h
index d2f148bd8902..ca56f36ef296 100644
--- a/tools/testing/memblock/linux/kernel.h
+++ b/tools/testing/memblock/linux/kernel.h
@@ -9,4 +9,6 @@
 #include <linux/linkage.h>
 #include <linux/kconfig.h>
 
+#define virt_to_phys(p) ((unsigned long)p)
+
 #endif
-- 
2.34.1

[PATCH 2/5] memblock test: add the definition of __setup()

[Wei Yang]

Commit 1e4c64b71c9b ("mm/memblock: Add "reserve_mem" to reserved named
memory at boot up") introduce usage of __setup(), which is not defined
in memblock test.

Define it in init.h to fix the build error.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 tools/testing/memblock/linux/init.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/memblock/linux/init.h b/tools/testing/memblock/linux/init.h
index 828e0ee0bc6c..036616a25427 100644
--- a/tools/testing/memblock/linux/init.h
+++ b/tools/testing/memblock/linux/init.h
@@ -28,6 +28,9 @@ struct obs_kernel_param {
 		__aligned(__alignof__(struct obs_kernel_param)) =	\
 		{ __setup_str_##unique_id, fn, early }
 
+#define __setup(str, fn)						\
+	__setup_param(str, fn, fn, 0)
+
 #define early_param(str, fn)						\
 	__setup_param(str, fn, fn, 1)
 
-- 
2.34.1

[PATCH 3/5] memblock test: fix implicit declaration of function 'memparse'

[Wei Yang]

Commit 1e4c64b71c9b ("mm/memblock: Add "reserve_mem" to reserved named
memory at boot up") introduce the usage of memparse(), which is not
defined in memblock test.

Add the definition and link it to fix the build.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 tools/include/linux/string.h          |  1 +
 tools/lib/cmdline.c                   | 53 +++++++++++++++++++++++++++
 tools/testing/memblock/Makefile       |  2 +-
 tools/testing/memblock/linux/kernel.h |  1 +
 4 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 tools/lib/cmdline.c

diff --git a/tools/include/linux/string.h b/tools/include/linux/string.h
index db5c99318c79..fb8eda3019b5 100644
--- a/tools/include/linux/string.h
+++ b/tools/include/linux/string.h
@@ -47,4 +47,5 @@ extern char * __must_check skip_spaces(const char *);
 extern char *strim(char *);
 
 extern void *memchr_inv(const void *start, int c, size_t bytes);
+extern unsigned long long memparse(const char *ptr, char **retptr);
 #endif /* _TOOLS_LINUX_STRING_H_ */
diff --git a/tools/lib/cmdline.c b/tools/lib/cmdline.c
new file mode 100644
index 000000000000..c85f00f43c5e
--- /dev/null
+++ b/tools/lib/cmdline.c
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * From lib/cmdline.c
+ */
+#include <stdlib.h>
+
+#if __has_attribute(__fallthrough__)
+# define fallthrough                    __attribute__((__fallthrough__))
+#else
+# define fallthrough                    do {} while (0)  /* fallthrough */
+#endif
+
+unsigned long long memparse(const char *ptr, char **retptr)
+{
+	char *endptr;	/* local pointer to end of parsed string */
+
+	unsigned long long ret = strtoll(ptr, &endptr, 0);
+
+	switch (*endptr) {
+	case 'E':
+	case 'e':
+		ret <<= 10;
+		fallthrough;
+	case 'P':
+	case 'p':
+		ret <<= 10;
+		fallthrough;
+	case 'T':
+	case 't':
+		ret <<= 10;
+		fallthrough;
+	case 'G':
+	case 'g':
+		ret <<= 10;
+		fallthrough;
+	case 'M':
+	case 'm':
+		ret <<= 10;
+		fallthrough;
+	case 'K':
+	case 'k':
+		ret <<= 10;
+		endptr++;
+		fallthrough;
+	default:
+		break;
+	}
+
+	if (retptr)
+		*retptr = endptr;
+
+	return ret;
+}
diff --git a/tools/testing/memblock/Makefile b/tools/testing/memblock/Makefile
index 7a1ca694a982..d80982ccdc20 100644
--- a/tools/testing/memblock/Makefile
+++ b/tools/testing/memblock/Makefile
@@ -8,7 +8,7 @@ LDFLAGS += -fsanitize=address -fsanitize=undefined
 TARGETS = main
 TEST_OFILES = tests/alloc_nid_api.o tests/alloc_helpers_api.o tests/alloc_api.o \
 		  tests/basic_api.o tests/common.o tests/alloc_exact_nid_api.o
-DEP_OFILES = memblock.o lib/slab.o mmzone.o slab.o
+DEP_OFILES = memblock.o lib/slab.o mmzone.o slab.o cmdline.o
 OFILES = main.o $(DEP_OFILES) $(TEST_OFILES)
 EXTR_SRC = ../../../mm/memblock.c
 
diff --git a/tools/testing/memblock/linux/kernel.h b/tools/testing/memblock/linux/kernel.h
index ca56f36ef296..67c9ea1428a5 100644
--- a/tools/testing/memblock/linux/kernel.h
+++ b/tools/testing/memblock/linux/kernel.h
@@ -8,6 +8,7 @@
 #include <linux/printk.h>
 #include <linux/linkage.h>
 #include <linux/kconfig.h>
+#include <linux/string.h>
 
 #define virt_to_phys(p) ((unsigned long)p)
 
-- 
2.34.1

[PATCH 4/5] memblock test: fix implicit declaration of function 'isspace'

[Wei Yang]

Commit 1e4c64b71c9b ("mm/memblock: Add "reserve_mem" to reserved named
memory at boot up") introduce usage of isspace().

In kernel source code, memblock.c include the definition by
debugfs.h/seq_file.h/string_helpers.h/ctype.h. Since it already has
ctype.h in tools, let complete the include chain to fix the build error.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 tools/include/linux/debugfs.h        | 2 ++
 tools/include/linux/seq_file.h       | 2 ++
 tools/include/linux/string_helpers.h | 8 ++++++++
 3 files changed, 12 insertions(+)
 create mode 100644 tools/include/linux/string_helpers.h

diff --git a/tools/include/linux/debugfs.h b/tools/include/linux/debugfs.h
index 4ba06140b1be..a99b0e0c5414 100644
--- a/tools/include/linux/debugfs.h
+++ b/tools/include/linux/debugfs.h
@@ -2,4 +2,6 @@
 #ifndef _TOOLS_DEBUGFS_H
 #define _TOOLS_DEBUGFS_H
 
+#include <linux/seq_file.h>
+
 #endif
diff --git a/tools/include/linux/seq_file.h b/tools/include/linux/seq_file.h
index f6bc226af0c1..8614fc2ca695 100644
--- a/tools/include/linux/seq_file.h
+++ b/tools/include/linux/seq_file.h
@@ -1,6 +1,8 @@
 #ifndef _TOOLS_INCLUDE_LINUX_SEQ_FILE_H
 #define _TOOLS_INCLUDE_LINUX_SEQ_FILE_H
 
+#include <linux/string_helpers.h>
+
 struct seq_file;
 
 #endif /* _TOOLS_INCLUDE_LINUX_SEQ_FILE_H */
diff --git a/tools/include/linux/string_helpers.h b/tools/include/linux/string_helpers.h
new file mode 100644
index 000000000000..bc11a762be8c
--- /dev/null
+++ b/tools/include/linux/string_helpers.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H
+#define _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H
+
+#include <linux/ctype.h>
+
+#endif /* _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H */
+
-- 
2.34.1

Re: [PATCH 4/5] memblock test: fix implicit declaration of function 'isspace'

[Mike Rapoport]

On Thu, Jul 25, 2024 at 01:41:56AM +0000, Wei Yang wrote:
> Commit 1e4c64b71c9b ("mm/memblock: Add "reserve_mem" to reserved named
> memory at boot up") introduce usage of isspace().
> 
> In kernel source code, memblock.c include the definition by
> debugfs.h/seq_file.h/string_helpers.h/ctype.h. Since it already has
> ctype.h in tools, let complete the include chain to fix the build error.

I think it's enough to include ctype.h in
tools/testing/memblock/linux/kernel.h 

> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
>  tools/include/linux/debugfs.h        | 2 ++
>  tools/include/linux/seq_file.h       | 2 ++
>  tools/include/linux/string_helpers.h | 8 ++++++++
>  3 files changed, 12 insertions(+)
>  create mode 100644 tools/include/linux/string_helpers.h
> 
> diff --git a/tools/include/linux/debugfs.h b/tools/include/linux/debugfs.h
> index 4ba06140b1be..a99b0e0c5414 100644
> --- a/tools/include/linux/debugfs.h
> +++ b/tools/include/linux/debugfs.h
> @@ -2,4 +2,6 @@
>  #ifndef _TOOLS_DEBUGFS_H
>  #define _TOOLS_DEBUGFS_H
>  
> +#include <linux/seq_file.h>
> +
>  #endif
> diff --git a/tools/include/linux/seq_file.h b/tools/include/linux/seq_file.h
> index f6bc226af0c1..8614fc2ca695 100644
> --- a/tools/include/linux/seq_file.h
> +++ b/tools/include/linux/seq_file.h
> @@ -1,6 +1,8 @@
>  #ifndef _TOOLS_INCLUDE_LINUX_SEQ_FILE_H
>  #define _TOOLS_INCLUDE_LINUX_SEQ_FILE_H
>  
> +#include <linux/string_helpers.h>
> +
>  struct seq_file;
>  
>  #endif /* _TOOLS_INCLUDE_LINUX_SEQ_FILE_H */
> diff --git a/tools/include/linux/string_helpers.h b/tools/include/linux/string_helpers.h
> new file mode 100644
> index 000000000000..bc11a762be8c
> --- /dev/null
> +++ b/tools/include/linux/string_helpers.h
> @@ -0,0 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H
> +#define _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H
> +
> +#include <linux/ctype.h>
> +
> +#endif /* _TOOLS_INCLUDE_LINUX_STRING_HELPERS_H */
> +
> -- 
> 2.34.1
> 

-- 
Sincerely yours,
Mike.

[PATCH 5/5] memblock test: fix implicit declaration of function 'strscpy'

[Wei Yang]

Commit 1e4c64b71c9b ("mm/memblock: Add "reserve_mem" to reserved named
memory at boot up") introduce the usage of strscpy, which breaks the
memblock test.

Let's define it as strcpy in userspace to fix it.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 tools/include/linux/string.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/include/linux/string.h b/tools/include/linux/string.h
index fb8eda3019b5..41e7fa734922 100644
--- a/tools/include/linux/string.h
+++ b/tools/include/linux/string.h
@@ -12,6 +12,8 @@ void argv_free(char **argv);
 
 int strtobool(const char *s, bool *res);
 
+#define strscpy strcpy
+
 /*
  * glibc based builds needs the extern while uClibc doesn't.
  * However uClibc headers also define __GLIBC__ hence the hack below
-- 
2.34.1

Re: [PATCH 1/5] memblock test: fix implicit declaration of function 'virt_to_phys'

[Mike Rapoport]

On Thu, Jul 25, 2024 at 01:41:53AM +0000, Wei Yang wrote:
> Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys
> alloc") introduce the usage of virt_to_phys(), which is not defined in
> memblock tests.
> 
> Define it in kernel.h to fix the build error.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
>  tools/testing/memblock/linux/kernel.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/memblock/linux/kernel.h b/tools/testing/memblock/linux/kernel.h
> index d2f148bd8902..ca56f36ef296 100644
> --- a/tools/testing/memblock/linux/kernel.h
> +++ b/tools/testing/memblock/linux/kernel.h
> @@ -9,4 +9,6 @@
>  #include <linux/linkage.h>
>  #include <linux/kconfig.h>
>  
> +#define virt_to_phys(p) ((unsigned long)p)
> +

There's already phys_to_virt() in tools/include/linux/mm.h.
It'd be better to put this one next to it.

>  #endif
> -- 
> 2.34.1
> 

-- 
Sincerely yours,
Mike.