linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
	Oscar Salvador <osalvador@suse.de>,
	Miaohe Lin <linmiaohe@huawei.com>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>, <linux-mm@kvack.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH 3/4] mm: migrate: add isolate_folio_to_list()
Date: Thu, 25 Jul 2024 09:16:46 +0800	[thread overview]
Message-ID: <20240725011647.1306045-4-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20240725011647.1306045-1-wangkefeng.wang@huawei.com>

Add isolate_folio_to_list() helper to try to isolate HugeTLB,
no-LRU movable and LRU folios to a list, which will be reused by
do_migrate_range() from memory hotplug soon.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/internal.h       |  2 ++
 mm/memory-failure.c | 21 +--------------------
 mm/migrate.c        | 27 +++++++++++++++++++++++++++
 3 files changed, 30 insertions(+), 20 deletions(-)

diff --git a/mm/internal.h b/mm/internal.h
index c5bd24c4fa3a..2484191c0764 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -403,6 +403,8 @@ extern unsigned long highest_memmap_pfn;
  */
 #define MAX_RECLAIM_RETRIES 16
 
+bool isolate_folio_to_list(struct folio *folio, struct list_head *list);
+
 /*
  * in mm/vmscan.c:
  */
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 99d92565cbb0..7e0f143bd51a 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2659,26 +2659,7 @@ EXPORT_SYMBOL(unpoison_memory);
 
 static bool mf_isolate_folio(struct folio *folio, struct list_head *pagelist)
 {
-	bool isolated = false;
-
-	if (folio_test_hugetlb(folio)) {
-		isolated = isolate_hugetlb(folio, pagelist);
-	} else {
-		bool lru = !__folio_test_movable(folio);
-
-		if (lru)
-			isolated = folio_isolate_lru(folio);
-		else
-			isolated = isolate_movable_page(&folio->page,
-							ISOLATE_UNEVICTABLE);
-
-		if (isolated) {
-			list_add(&folio->lru, pagelist);
-			if (lru)
-				node_stat_add_folio(folio, NR_ISOLATED_ANON +
-						    folio_is_file_lru(folio));
-		}
-	}
+	bool isolated = isolate_folio_to_list(folio, pagelist);
 
 	/*
 	 * If we succeed to isolate the folio, we grabbed another refcount on
diff --git a/mm/migrate.c b/mm/migrate.c
index e7296c0fb5d5..51cab1103502 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -177,6 +177,33 @@ void putback_movable_pages(struct list_head *l)
 	}
 }
 
+/* Must be called with an elevated refcount on the folio */
+bool isolate_folio_to_list(struct folio *folio, struct list_head *list)
+{
+	bool isolated = false;
+
+	if (folio_test_hugetlb(folio)) {
+		isolated = isolate_hugetlb(folio, list);
+	} else {
+		bool lru = !__folio_test_movable(folio);
+
+		if (lru)
+			isolated = folio_isolate_lru(folio);
+		else
+			isolated = isolate_movable_page(&folio->page,
+							ISOLATE_UNEVICTABLE);
+
+		if (isolated) {
+			list_add(&folio->lru, list);
+			if (lru)
+				node_stat_add_folio(folio, NR_ISOLATED_ANON +
+						    folio_is_file_lru(folio));
+		}
+	}
+
+	return isolated;
+}
+
 /*
  * Restore a potential migration pte to a working pte entry
  */
-- 
2.27.0



  parent reply	other threads:[~2024-07-25  1:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25  1:16 [PATCH 0/4] mm: memory_hotplug: improve do_migrate_range() Kefeng Wang
2024-07-25  1:16 ` [PATCH 1/4] mm: memory-failure: add unmap_posioned_folio() Kefeng Wang
2024-07-30 10:20   ` David Hildenbrand
2024-07-31  4:46     ` Kefeng Wang
2024-07-25  1:16 ` [PATCH 2/4] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() Kefeng Wang
2024-07-30 10:26   ` David Hildenbrand
2024-07-31  5:09     ` Kefeng Wang
2024-08-01 20:10       ` David Hildenbrand
2024-08-02  7:50         ` Kefeng Wang
2024-08-06  9:29           ` David Hildenbrand
     [not found]             ` <1e6cccc5-fedc-8df6-1deb-16ceb52a4094@huawei.com>
     [not found]               ` <1e14d86d-0d17-41da-9400-16c9c6f93f8f@redhat.com>
2024-08-09  2:02                 ` Miaohe Lin
2024-08-01 20:14   ` David Hildenbrand
2024-08-02  8:02     ` Kefeng Wang
2024-08-06  3:44       ` Kefeng Wang
2024-08-06  9:24         ` David Hildenbrand
2024-08-06  9:15       ` David Hildenbrand
2024-07-25  1:16 ` Kefeng Wang [this message]
2024-07-26 14:21   ` [PATCH 3/4] mm: migrate: add isolate_folio_to_list() kernel test robot
2024-07-27  7:56     ` Kefeng Wang
2024-07-30 10:30   ` David Hildenbrand
2024-07-25  1:16 ` [PATCH 4/4] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation Kefeng Wang
2024-07-30 10:31   ` David Hildenbrand
2024-07-31  5:13     ` Kefeng Wang
2024-08-01 20:16       ` David Hildenbrand
2024-08-01 20:23   ` David Hildenbrand
2024-08-02  8:39     ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240725011647.1306045-4-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-mm@kvack.org \
    --cc=nao.horiguchi@gmail.com \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox