From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D73C3DA61 for ; Wed, 24 Jul 2024 21:37:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A1B96B0088; Wed, 24 Jul 2024 17:37:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451F46B0089; Wed, 24 Jul 2024 17:37:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 319656B008A; Wed, 24 Jul 2024 17:37:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1756A6B0088 for ; Wed, 24 Jul 2024 17:37:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AC9A41A0BBF for ; Wed, 24 Jul 2024 21:37:27 +0000 (UTC) X-FDA: 82375957734.05.D4F5806 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 95B271C0017 for ; Wed, 24 Jul 2024 21:37:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=eHYkav2j; spf=pass (imf20.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.54 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721857021; a=rsa-sha256; cv=none; b=BFjrgq5xyDB7Pc/7JweZco3TEcJQakIFrIgfnJOZfdRCIGDDNHcZWb+524DVwn+0d8tvve YWeneMf3aey/Xz3mCuBa5/MyrC/7oYDkwUjgXR47kscpZontlJS3TNnfUbP9TdA7uhpx6z 1KnaNyrRtbB6tfc6MzlprF8EDOJBKwA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=eHYkav2j; spf=pass (imf20.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.54 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721857021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lSSTgQ5w2hw67L9Mcy84Ur9n6hJfVLNLfjLoLub8gmE=; b=E7bSpI1e57TMCUqpq24jI19SCO74Pg0+Q6f/o219JwdYVzEuRi+tBgdDnHotCiVBqCcNx1 IdG/U4mre6O8LZDQjCPE0RFQFmE0IkGbKZEDfN8kaGZJ3mIkcWrByDtZPyNb6q3DUNetHq zSbybFIPr1Se0jTSehlemyO7zemc7uw= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4266f535e82so1851255e9.1 for ; Wed, 24 Jul 2024 14:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1721857044; x=1722461844; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lSSTgQ5w2hw67L9Mcy84Ur9n6hJfVLNLfjLoLub8gmE=; b=eHYkav2jEMdf6FBzQMtJxzk3UW114IuksW3pTGJ36n8gJUCshv7RmqOwXTNStXUIKr rSzHl2dAzrG/T9fN04jIuBvhyeXVlY9yzG31svpFv9IDPTyslTJWVetsb0nAgaRLF7f4 OqpUWVjfUgw+WPIcdZG0HpneQg9o1KsMhalEkccEALMed6P/fTna6o1R2CuRct7Fx6X9 NnPAug+nt1fz7mq3idf0SqNLbW4zdoSb1bW1aZIcLIrMcb+t69Ui5c1dcMTMsF4uTEho 6YntYZYwOq8HU4hKxceyAg8ptEqCJa+6cvP83W0SGMiehc8UjBBEQShwbzafDDovyH6k bRcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721857044; x=1722461844; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lSSTgQ5w2hw67L9Mcy84Ur9n6hJfVLNLfjLoLub8gmE=; b=VCEirwJ4uXve0BZSGOE7zf7y3ze+DC/AprC3qy65SA9YX84so4kgLPhaaduBCZNLzL oiQ0VIbHxRqFt4ImRp/posCLviAgo3Ak/5QauR9tRxWb+2k1dzARQYt9HHRuf4ePqNm7 xyi0r/Bkt4N+sCSqqYwFWrQRn7KPqsEPHFWNc8xZoG3EXZqPiPMXigo/sE7UaJemNN5z DtJXWy1ugojDkyQa4MSZHVHfnlke1ZjQXQj/qr6YTIQRCvcEbo7Aaqx9A9SLciMD4hP8 dGyC0uqLRh/B3Hq9avR05uSkxLfY6VJk4hPp0rpssfs0j0gzVlAOOu9+qAoPnSVEM1RI 79fw== X-Forwarded-Encrypted: i=1; AJvYcCVRXTskUtmcIUA/AslC3g0mdKdDNRVw6WFoZwmYvCfejdkYFCodICV8Ox1P2QkqjXS/PQqRfy8IiO/q31fPc96DZmw= X-Gm-Message-State: AOJu0YwN7iCMlcP2qTxOjC9JGtWjGH6zzp6XQJhbo1dB+DYcFzMzAgtd GtXbMkHCRzpbX0EveLuPcIRt+C8tyos9XF/YhfAhHPVanYf9Abx4pTaAC+4pduE= X-Google-Smtp-Source: AGHT+IHxyEu6XDaUe6E5/O/ti2ZJ+Zq2UF8NgvQ7RAEgPsm6Nw77tpqzyjgNHrWmlsbprqB15BLpBA== X-Received: by 2002:adf:f40e:0:b0:368:4ed7:2acc with SMTP id ffacd0b85a97d-36b3638148cmr6859f8f.5.1721857044110; Wed, 24 Jul 2024 14:37:24 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368787ced28sm15366726f8f.88.2024.07.24.14.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 14:37:23 -0700 (PDT) Date: Wed, 24 Jul 2024 22:37:22 +0100 From: Qais Yousef To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt Cc: Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 0/3] Clean up usage of rt_task() Message-ID: <20240724213722.4fcmambn4ry23qhw@airbuntu> References: <20240610192018.1567075-1-qyousef@layalina.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240610192018.1567075-1-qyousef@layalina.io> X-Stat-Signature: tqwrypaxti3nu47ojhy9dgfypay5ecwb X-Rspamd-Queue-Id: 95B271C0017 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721857045-711744 X-HE-Meta: U2FsdGVkX19KrAN26v8BMkzqucyBkCqYhen+tCXlLMGZR+2Ewp+F5jBycVy6XkSqF/QFN0MyjyN1mDNFFHLXb+0yy7xVsWNFa0zjd3A0+MxGcbqWWa8aYQh5A5aVpI0RLSw56jDSya/2Qs5hEgOnIaGAIUJUXtIxbE9FWEP6QZ8v/04HLmycMfqTdjxmyaJWmOtvvsqqhROQn8yuYY5O5nfBwGDIo9D8paxjUJL5/q/vIqN/dL24jZs1s5QT+9upCa0OyDfKkf1XrqdTM4njVstjPgxx/Ny0csORqnVB7ZUNTG2gHOAk39fLgpRY9wnBLNm9fWm+nOO9xsI0bDg36vEuRRtMcOOyxGNndicvIz+lfMPb5NL7SOTDt9aI1zPdu+ueGhU66PI1PjWgcAOIZ81DL8WQgl7yQUMn8CZlJ47E7dchS+k0cfPXOuhXR3NEnkQ//0kAXVLVOVCQ7wojJN67/dxlt3lnenPr7AIkbzyw45Uqme2jrr8U301K/H3BRONHw7e1o5/dMHKQsbYlAnru37txJ6nuNjxYKmTBD7NopYfZsQQBtHvufWqvQZJWp98mFjSpZmCmsARzbx6jjjjVBVAwhe5k8OC3Rprxuz6XwKdnDd+CSgunlPe6dhXirlhM/bUYMKr9dl2Cp5mYjPE5r7t/tWzW8kyBNjk3JwZELVUzsibOX7jE8Kt8+xNe5mp76D1lsO9Ye7y9vbOafHENEUqSYR4i819HAFjllNU14iC2RyIm+NjsDnfkZXYnbEFz+gta6bUIpg9znyyH7ww1uIgIuATuYhzN+GoeuPNLBOIVo0Tckfe2Juor7qb5rSwbzxip0hHFIkuCQgFcXqZvc4nErFO7vWa5EIjUKKEJuHeXSKTItHOYa6YhyMcQqXdiuiK4EvyMbcDP080HzKz5OKI0MosaGT72xZ2s9jb+sJxc/gAJI3DhE6RYA8HUQB6ACpJmFrKT3jm0YjA 94zkksLQ RJGl3rFDyfbQoUueeYfuJ3N0H0lSlkx/46Wz0Te0SJl++arfYBZyg/20V2PzfCVkkpfu067D3oQEHfkAa6m82t0rTA+uBtXsSzoZoUu/LfhQBqCrKFdz6zXqK/UtrSGfAHTsVt672qMnIt3OLM3qdBpgyzX32aLRmGWAVxTzJU74g60n0Rm0tengw6o3WwV6KXqEoHAqt8B9/FSUfeoDqMLwlquEIYiR4eVa9V/SwsN8IMsmWzHf3kE4QoLu4kKHSkRy9YNmsfWMtDxB9bQ4yNP3L5GWXfvNEhYIzMretLICFcr868jKSE62I5ybsZkspI9zjQEQDwhwDbZi3Ra3z8/grmACE81XZJjdmUasHsJxR9TUqDLeVLZ3B2bZ9/4J0e5E2BkM4/0xq8zgm/C0a/DY9+O81DcvjK/ockr+jQan6PHjJC7FusUfYUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/10/24 20:20, Qais Yousef wrote: > Make rt_task() return true only for RT class and add new realtime_task() to > return true for RT and DL classes to avoid some confusion the old API can > cause. I am not aware of any pending review comments for this series. Is it ready to be picked up? Thanks! -- Qais Yousef > > No functional changes intended in patch 1. Patch 2 cleans up the return type as > suggested by Steve. Patch 3 uses rt_or_dl() instead of 'realtime' as suggested > by Daniel. As the name was debatable, I'll leave up to the maintainers to pick > their preference. > > Changes since v5: > > * Added a new patch to s/realtime/rt_or_dl/ as suggested by Daniel. > * Added Reviewed-bys. > > Changes since v4: > > * Simplify return of rt/realtime_prio() as the explicit true/false was > not necessary. > > Changes since v3: > > * Make sure the 'new' bool functions return true/false instead of 1/0. > * Drop patch 2 about hrtimer usage of realtime_task() as ongoing > discussion on v1 indicates its scope outside of this simple cleanup. > > Changes since v2: > > * Fix one user that should use realtime_task() but remained using > rt_task() (Sebastian) > * New patch to convert all hrtimer users to use realtime_task_policy() > (Sebastian) > * Add a new patch to convert return type to bool (Steve) > * Rebase on tip/sched/core and handle a conflict with code shuffle to > syscalls.c > * Add Reviewed-by Steve > > Changes since v1: > > * Use realtime_task_policy() instead task_has_realtime_policy() (Peter) > * Improve commit message readability about replace some rt_task() > users. > > v1 discussion: https://lore.kernel.org/lkml/20240514234112.792989-1-qyousef@layalina.io/ > v2 discussion: https://lore.kernel.org/lkml/20240515220536.823145-1-qyousef@layalina.io/ > v3 discussion: https://lore.kernel.org/lkml/20240527234508.1062360-1-qyousef@layalina.io/ > v4 discussion: https://lore.kernel.org/lkml/20240601213309.1262206-1-qyousef@layalina.io/ > v5 discussion: https://lore.kernel.org/lkml/20240604144228.1356121-1-qyousef@layalina.io/ > > Qais Yousef (3): > sched/rt: Clean up usage of rt_task() > sched/rt, dl: Convert functions to return bool > sched/rt: Rename realtime_{prio, task}() to rt_or_dl_{prio, task}() > > fs/bcachefs/six.c | 2 +- > fs/select.c | 2 +- > include/linux/ioprio.h | 2 +- > include/linux/sched/deadline.h | 14 ++++++------- > include/linux/sched/prio.h | 1 + > include/linux/sched/rt.h | 33 +++++++++++++++++++++++++------ > kernel/locking/rtmutex.c | 4 ++-- > kernel/locking/rwsem.c | 4 ++-- > kernel/locking/ww_mutex.h | 2 +- > kernel/sched/core.c | 4 ++-- > kernel/sched/syscalls.c | 2 +- > kernel/time/hrtimer.c | 6 +++--- > kernel/trace/trace_sched_wakeup.c | 2 +- > mm/page-writeback.c | 4 ++-- > mm/page_alloc.c | 2 +- > 15 files changed, 53 insertions(+), 31 deletions(-) > > -- > 2.34.1 >