From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B701C3DA70 for ; Wed, 24 Jul 2024 07:24:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6470D6B0082; Wed, 24 Jul 2024 03:24:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CC606B0083; Wed, 24 Jul 2024 03:24:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46E0A6B0085; Wed, 24 Jul 2024 03:24:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2AACA6B0082 for ; Wed, 24 Jul 2024 03:24:26 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 95116C06C3 for ; Wed, 24 Jul 2024 07:24:25 +0000 (UTC) X-FDA: 82373808090.29.4392445 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf30.hostedemail.com (Postfix) with ESMTP id 5FDEB80005 for ; Wed, 24 Jul 2024 07:24:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=A5y2zwDN; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721805828; a=rsa-sha256; cv=none; b=pEeh677vAXcyGPTSWnOZXDfqY800iuWEAGGazPWaWtcioE1hDblEmiP9Tg/mMhPnLKJ76v 6TBmPzyFuUPjmOdWp1zfecMEtCU/UruZJoivGxcx5xiZNv8IoS0rgM3zTr2+CMPDmMGO23 BzlSHThz8nC+Y8GXqLLnsEG63nmpqLc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=A5y2zwDN; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721805828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eNsiHqQeP2nEVh3ttLItW7JxxSNTBAFBmtSNFqQgxa8=; b=Ct/nv0O6trkhi/TmR3UnYXF3BH0q8XoVekitigYOexCKbl4/oIswdzE9MiqKGQno4j7ayU eIhdhcV1HxtDebyIP4AfB6Ybeqi1Bu30Su9ezH9Gb5R1eoynUgSxKQBH550b/F6YzUnnAH jVivMaCEFuu+Yxo58ZDWBQnDg8MA2hU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721805864; x=1753341864; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RIhHgfJroKe6Mfcs5vXrAnocs66PZUvwmQcjPpyMdJo=; b=A5y2zwDNjFuPDsjwKAZJKNVjdZxo4MWnQCrn42YRdy1G532oJgQTDFrg tMgXvwqx5/OLoD0bSKVDlXcBfb349JJNHX/V/JLSmHGsvlnB7lD6kGhEf Ypc5mtHUk1FK+zRsFOl+szQc+hSD9t3YMyUUTZbvM7m6hOjBDpyLgr9MK 5FuyafREsMbfjTQPhb6EgoSVwuD7bsZC0VIoRuUwPtUTJm/V4FEEZcGXo E8yRzsqrj+FKkPlHiOLhxV8gkSGhr4L8/KCaHWDEsQ9InSOwOnaIYReRL 6yqnmQ8iNjx/YXoFLclCvCEAbv3+Jf06Z7EkC70pjND5Xgf/sW/DHwRhr g==; X-CSE-ConnectionGUID: BuV1XfUsSdSnzIiDAYEHMQ== X-CSE-MsgGUID: rb4YZYkyTKeUsiBtAuoeqA== X-IronPort-AV: E=McAfee;i="6700,10204,11142"; a="41993545" X-IronPort-AV: E=Sophos;i="6.09,232,1716274800"; d="scan'208";a="41993545" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2024 00:24:12 -0700 X-CSE-ConnectionGUID: hJtl0w8yQKaU+5S2w1LCgw== X-CSE-MsgGUID: U5gOuR/LTfqEsK+Wrph9dA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,232,1716274800"; d="scan'208";a="52402923" Received: from lkp-server01.sh.intel.com (HELO 68891e0c336b) ([10.239.97.150]) by orviesa010.jf.intel.com with ESMTP; 24 Jul 2024 00:24:10 -0700 Received: from kbuild by 68891e0c336b with local (Exim 4.96) (envelope-from ) id 1sWWM3-000mm1-2W; Wed, 24 Jul 2024 07:24:07 +0000 Date: Wed, 24 Jul 2024 15:24:05 +0800 From: kernel test robot To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Matthew Wilcox (Oracle)" Subject: Re: [PATCH 2/6] mm: Constify page_address_in_vma() Message-ID: <202407241541.GgplaeTD-lkp@intel.com> References: <20240723153503.1669586-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240723153503.1669586-3-willy@infradead.org> X-Rspamd-Queue-Id: 5FDEB80005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5urgyhre9kwdbmee9moy1ekjpibhjia4 X-HE-Tag: 1721805863-376713 X-HE-Meta: U2FsdGVkX18n+Peoj2lNmPDY7u64aOnoIKiZdTqHNoQbT3lRUQanXNOceoqzJjKgNWT3QpmU+wHqZOCcDBAiYL2/5GJU19TUUyZta48vQc2DyLHVas4XR5go+MIyZeok6ltt4r5K4VjZvWelozGV1gmcH7yJzpEeQWzSoUWxIj2Ep/fQeUn4AxI+OkbCdtYTYuuvF0UwYLoXzvrUJQPM47N14mmyF9ztYgW4weawl3bFA32Qy0NdK9hHrWAn0qmyfgGUQ65J93xqt6HDSQ6LCOlhlFCsYNm7vmBXIMKHpACNeE0xvNIUvQASG0clPN3UjWzMe2sbj270LV1lPBxSwx+tA/e0OyiBhqHo4KI7y4Gy84gRGg0/ZKsEtbIEQ7AVAGWs5KZnc/O7JnM370myrTv/qFZ2wWWuJ5vhxwu4Vqji45knVKdn120YXl4WzZKQOXBokgmzleYHKpeZC6Nbqj7YBMTGE13QuPHxghp/y7L+7ScPfdpGB7hN/rio+YzEMFx93hKaGpojWlXUA9Mr52iAmkW7sZ/G7V7L/YoY63X8xcKaMoWlKeTuAdOjImBJg9Gzy2ZXIHKoZ6VmMrtfi8TT+jpf9NKxyiIIvsH6an+DgyO2dCrHzGdYuvF0o4OlInAtUJtVtB88xkWiUK+sozIXV0P5xm7dUEL32KDnU3FZGpKPetsHYv7AayamTG2o5txjeVf8bHHKolhNpJPxciS9sty+6OFZEWPl+FpR3R69jARc5d2hCVR0O4jnxA0yBivrwez3+u0vrpRzRfLwE49l9Sr2CIp81iR/D+mPhlq/Bpi2M5ApLkI0VnPF2hn5EKJxKDSPdVXtXEsz7EYFF+oPbsvT0w/c5BWgGzhMShb+qNzskw444micr45xPM5v2TOR3OdOx4k5cAWup9YR7E5W4cuxJPpY8Fu6uIuWyhLToesp94k1tI52Bk/XY6kauRrZB/vniXETjRvVaiE dvCoNdjY 9A68SiFkCQEM7dI4ZAz4qocW6J0ShFxWe1nhcTxEcExIj2C/KMA7gWGTi4Ka+Me/ln6UuvUzJLf0NHGT6jp1JGA59B0yyG4zo4Q+5Ue8FvSMvMobmFgU9Bn2IzcgpEjkDJcjprPr9oiNro1yppULwPgpVGXK03DtWCU//7YQQcULHmBWWWcUqXXQy4r4rHPws8rAtguXj8TDlhERT77Umtg/ZHQs7KUvWmOa3XKufiHyL0JbXbmTabidxbFVYsqwhL7B2MIQOXDltFulD4V+xPbmQBaupRlxt7sUNtSN63u5BZjnAsaCkMhQrz/depegsVI89BLMXNcnEwg0PbHnuqT2M7E9fqCFPff0/hRV4HA8rQ71UpLgjuSCO/jNjIDEYfiCSANbqMhsO6O/wYVUPOwArPbVFBAnkwrUBaKSSVZYVYjAH3x/OQCvbOK/mEuNP29i9Z0B21vLM6aV0sSHjk5GZMVgWGlVIWv7NOZJr9a8UvepVA9xeXO3tInOIgK/Srtng X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Matthew, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on linus/master next-20240724] [cannot apply to tip/x86/mm dennis-percpu/for-next v6.10] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/bootmem-Stop-using-page-index/20240723-233932 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240723153503.1669586-3-willy%40infradead.org patch subject: [PATCH 2/6] mm: Constify page_address_in_vma() config: sh-migor_defconfig (https://download.01.org/0day-ci/archive/20240724/202407241541.GgplaeTD-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240724/202407241541.GgplaeTD-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202407241541.GgplaeTD-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/rmap.c:56: mm/rmap.c: In function 'page_address_in_vma': >> mm/rmap.c:796:47: warning: passing argument 1 of 'folio_pfn' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 796 | pgoff = folio->index + folio_page_idx(folio, page); | ^~~~~ include/linux/mm.h:216:69: note: in definition of macro 'folio_page_idx' 216 | #define folio_page_idx(folio, p) (page_to_pfn(p) - folio_pfn(folio)) | ^~~~~ include/linux/mm.h:1877:53: note: expected 'struct folio *' but argument is of type 'const struct folio *' 1877 | static inline unsigned long folio_pfn(struct folio *folio) | ~~~~~~~~~~~~~~^~~~~ vim +796 mm/rmap.c 72b252aed506b8 Mel Gorman 2015-09-04 769 ^1da177e4c3f41 Linus Torvalds 2005-04-16 770 /* bf89c8c8673223 Huang Shijie 2009-10-01 771 * At what user virtual address is page expected in vma? ab941e0fff3947 Naoya Horiguchi 2010-05-11 772 * Caller should check the page is actually part of the vma. ^1da177e4c3f41 Linus Torvalds 2005-04-16 773 */ eb7052fd71d991 Matthew Wilcox (Oracle 2024-07-23 774) unsigned long page_address_in_vma(const struct page *page, eb7052fd71d991 Matthew Wilcox (Oracle 2024-07-23 775) struct vm_area_struct *vma) ^1da177e4c3f41 Linus Torvalds 2005-04-16 776 { eb7052fd71d991 Matthew Wilcox (Oracle 2024-07-23 777) const struct folio *folio = page_folio(page); 412ad5fbe9285f Matthew Wilcox (Oracle 2024-03-28 778) pgoff_t pgoff; 412ad5fbe9285f Matthew Wilcox (Oracle 2024-03-28 779) e05b34539d008a Matthew Wilcox (Oracle 2022-01-29 780) if (folio_test_anon(folio)) { e05b34539d008a Matthew Wilcox (Oracle 2022-01-29 781) struct anon_vma *page__anon_vma = folio_anon_vma(folio); 4829b906cc063c Hugh Dickins 2010-10-02 782 /* 4829b906cc063c Hugh Dickins 2010-10-02 783 * Note: swapoff's unuse_vma() is more efficient with this 4829b906cc063c Hugh Dickins 2010-10-02 784 * check, and needs it to match anon_vma when KSM is active. 4829b906cc063c Hugh Dickins 2010-10-02 785 */ 4829b906cc063c Hugh Dickins 2010-10-02 786 if (!vma->anon_vma || !page__anon_vma || 4829b906cc063c Hugh Dickins 2010-10-02 787 vma->anon_vma->root != page__anon_vma->root) 21d0d443cdc165 Andrea Arcangeli 2010-08-09 788 return -EFAULT; 31657170deaf1d Jue Wang 2021-06-15 789 } else if (!vma->vm_file) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 790 return -EFAULT; e05b34539d008a Matthew Wilcox (Oracle 2022-01-29 791) } else if (vma->vm_file->f_mapping != folio->mapping) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 792 return -EFAULT; 31657170deaf1d Jue Wang 2021-06-15 793 } 494334e43c16d6 Hugh Dickins 2021-06-15 794 412ad5fbe9285f Matthew Wilcox (Oracle 2024-03-28 795) /* The !page__anon_vma above handles KSM folios */ 412ad5fbe9285f Matthew Wilcox (Oracle 2024-03-28 @796) pgoff = folio->index + folio_page_idx(folio, page); e0abfbb6714244 Matthew Wilcox (Oracle 2024-03-28 797) return vma_address(vma, pgoff, 1); ^1da177e4c3f41 Linus Torvalds 2005-04-16 798 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 799 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki