From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF87C3DA61 for ; Wed, 24 Jul 2024 19:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C47AE6B0089; Wed, 24 Jul 2024 15:55:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF7B76B008A; Wed, 24 Jul 2024 15:55:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE5D56B008C; Wed, 24 Jul 2024 15:55:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9657B6B0089 for ; Wed, 24 Jul 2024 15:55:19 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 49079A4446 for ; Wed, 24 Jul 2024 19:55:19 +0000 (UTC) X-FDA: 82375700358.11.F5719DA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 732F410001B for ; Wed, 24 Jul 2024 19:55:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="R9A/sF18"; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721850893; a=rsa-sha256; cv=none; b=NHQ7z4fyCAqrMO8B3OzqI+KYaA+YtoHfPGxKm8Au6K+Awc1hz6XytmXRWD9onhaSsxKLgE Rcvgt6+kufLD7QXeZdIAKO9GBZb0kjhCBL9lXZVZ3CZBWp3EFE1gvNt5YGnkHOkz/eY5SW xNAYhbITDPdCdSqIC6EJnXgGyhJRTlA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="R9A/sF18"; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721850893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lhgp59qOXDMqTg21VnZZX4LY9fxPny9TNSA+HOtBH70=; b=ofyCIAHH+isYJicC3pDdOg3Xo+Vsv44wonucT4sRg2ePWwSYGwrdcX1bohOeQwIWEkTlYB +a3vpMChq/0Czx/33dUUkMFcZVd73iyQFJAq8OoK5qwamYERSbTHhfrLQBxXLqlLWCDQI3 AnCqxk9QI2KqXvXCxsNYYTloFFwClUg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8D75C6126D; Wed, 24 Jul 2024 19:55:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06D08C32781; Wed, 24 Jul 2024 19:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721850916; bh=AeVzJzfx+eqp71s07hx1jErZV8mnRMLNVTYjy+2tzHw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R9A/sF18DTCPJ4RAxck0P2jBF3EHcUCnPS48jGsrt+Lxk3Vv3jr+UfFa4ZOvlAF7n kamu2/sB5eIR3AFtSDlsgCO27sBZRf4+v62gqUt4kkfim28GQ5lIaIF3btVcGIBs68 XFLhAs7OblhQwxoqUUrQA78vRwV21Hi7WKYTUeqc= Date: Wed, 24 Jul 2024 12:55:15 -0700 From: Andrew Morton To: Zhiguo Jiang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , David Hildenbrand , Matthew Wilcox , opensource.kernel@vivo.com Subject: Re: [PATCH v10] mm: shrink skip folio mapped by an exiting process Message-Id: <20240724125515.6cc3bd8479ea8bcdedaa7eff@linux-foundation.org> In-Reply-To: <20240710083641.546-1-justinjiang@vivo.com> References: <20240710083641.546-1-justinjiang@vivo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: t5zx9scpaxbkm8oemte8zk3p96qfqdnk X-Rspamd-Queue-Id: 732F410001B X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721850917-462117 X-HE-Meta: U2FsdGVkX1+/UMzMSMwZaPBAkzvoCeESla+VfoUPr//kNLOjH4bbOGv06rV25mt0MUC3jU2y37bTzGSlyS3f2RzF0FUiCZFH4QNuyzwNFTZLMpBQS6FQPjBIv0B2JhTim5aqNhysEbdxbCb6X6/wk3gVxUXhqfkuY4OqKy6DLv1h/mFp+D3ToP1CutdrT77BLPXygToF0SkvldlCtPxJgBlxnau3SL0C+sHTpXrApLeUBQAMRbpQHutWNkQE4MjisPQHKfEl7CDqzP1hi91j552ry433MYJOHEhTT/PZWinUFHYTUF8c95d8uLAsMhr0SabynJbUoppxgJiaNOlaMgsRcHckFKoMDK174XqIuWb3KDrohksF/MPNNMkfxMUXfJBfbQF9xqYNLEpXiNwx5OpUCi+VvsW5Rifd+wdXO6Y/M5Bbi2Zg766Bt0SKe/0C6b9bWH0QTm3gE6cxW4lkDr7F2lrxOhLFDidxtGnc8zq5GrVkbe7dcpzes0ErAzfCBbwJ2M7+3rNqh+o1F0PyF2nZ4RG8Ik+57idlu2g5Q3g5izD+NH7D88rgq3tHKTSJqtsrUJsNMUmVrpRb2nYf8du3I9StzUjkiTfaxjQfCvjtCgN8azH+cob1tdAnNqMaM93U+DdcwiHFj33r3rwk0vLXkvx1OWNuYOp0+dHzaNNkwCWXHocUNfGp+9eWdbY2GZpjg82IfYwGRhHSj3nHfgJRTes3LcBEma59KZ8NrePxARHEPF0oJ2XxkS2svgnR36ivwMeWZUuj0XFLexdr8PKRizXcLMTR+n1KYWB01D2zwIGxDa6cCFJcxVb4P2XSiikeckutcVAd9aypFdpi4n3GiQRlRLma5woyaCpHyD5FICaH2etrIBhTDz1kUevrexXNPl9c49RwifxwnVYGIPqfemGy5wsuNklHaXv/rse0Cxtbhd6Tu8hgKHWGIeV3NfOXvLupbZYs+YNGmBm Piwv8oox X6qa+TX/Wv+g6NmVDraqfz3t1oLVSb8p7/fzImS3MozBzlpdED3CIn3tJQwmzFtvlaXWulXCYGEE7z3U5xQ7tJnJWWbjZxgTH+tbC33tqx91LwZu/6B3RAEBbysOO6bs5tzoPDm6hQEwQDyQS28pOws63Ss09W8p5XEVouJNczzd1AKTtc+Nj2QtwvP6LA9NAqwu90c8j6ofA6+8Pgmn1jY3BHYGaJIpEXI9lpfOzHCdl2Q8VILqESZm2LFJ3BmFPUGB3kgtQfuJ2C3WwiaemnT0ukw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 10 Jul 2024 16:36:41 +0800 Zhiguo Jiang wrote: > The releasing process of the non-shared anonymous folio mapped solely by > an exiting process may go through two flows: 1) the anonymous folio is > firstly is swaped-out into swapspace and transformed into a swp_entry > in shrink_folio_list; 2) then the swp_entry is released in the process > exiting flow. This will result in the high cpu load of releasing a > non-shared anonymous folio mapped solely by an exiting process. > > When the low system memory and the exiting process exist at the same > time, it will be likely to happen, because the non-shared anonymous > folio mapped solely by an exiting process may be reclaimed by > shrink_folio_list. > > This patch is that shrink skips the non-shared anonymous folio solely > mapped by an exting process and this folio is only released directly in > the process exiting flow, which will save swap-out time and alleviate > the load of the process exiting. Has any testing been performed to demonstrate any benefit? If so, what were the results?