From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0A4C3DA63 for ; Wed, 24 Jul 2024 19:14:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E75776B007B; Wed, 24 Jul 2024 15:14:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E26656B0082; Wed, 24 Jul 2024 15:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D13FB6B0083; Wed, 24 Jul 2024 15:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B96476B007B for ; Wed, 24 Jul 2024 15:14:18 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 578F0120BAA for ; Wed, 24 Jul 2024 19:14:18 +0000 (UTC) X-FDA: 82375596996.04.6242FF0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 4C2B61C0024 for ; Wed, 24 Jul 2024 19:14:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xXQMZQCV; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721848402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ASVuqVjomr77UUsY4aBYfvzYsVpQFNe+WuOQIBPar/g=; b=43P49ihqVjwE0BGI683qieV5jDjTZzky3Gqvp+BCe/bang5w/6UNfpe3o9moNzzrRd+HW1 4KwiAGwq6kmeGlB0bRznUmLQP9aRmyVjN5zswjokJmzdj80O2e1HIIvUIEJK8r++Bdu6S9 iNOc72cNg+lslnVKVTsjnTmJ2/lnnxw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721848402; a=rsa-sha256; cv=none; b=zyQLoGOdnqiPrtrf5/4NJE0IkiDE7sGbdDBUJnYEqmnpvTp2CSfRNdBQwVupcj00MLZSpk ovzDxVKm7OlJdCT6YLqFpNAkU74P4SS5u0Ix3+cNnlAx0uf0pn6Mg05l1l44R2fuoG0gI4 tRJ0KkP+7RxuSXQKLc3f76r07AeDE0Q= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xXQMZQCV; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E8EC461261; Wed, 24 Jul 2024 19:14:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B4B6C4AF11; Wed, 24 Jul 2024 19:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721848453; bh=J5EXpzSAXq9MlniUjingyvdi5dGIQLOMLHcvs33VHHQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xXQMZQCVFKxqS/ZDxC2AhlL6F4r1GJ491M4q51sG7ctao5Qcg6eeKOVViNKGeNrgJ 12KYl4jYkxKLDlBznYKz3sTkYzt7DOuogQfif4bzIzgn83CQoH1F0sjoZRpVYCz9RI hsV2roIbXSDPGjWlk0S6NHLje5GrwNK5joz6HnLE= Date: Wed, 24 Jul 2024 12:14:07 -0700 From: Andrew Morton To: Baolin Wang Cc: hughd@google.com, willy@infradead.org, david@redhat.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, ioworker0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] Some cleanups for shmem Message-Id: <20240724121407.a81ef1cfdddec3ee348049fb@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4C2B61C0024 X-Stat-Signature: 3k74szkacf87qhayujedjjy3ywwxpsyk X-Rspam-User: X-HE-Tag: 1721848455-276294 X-HE-Meta: U2FsdGVkX18rvUmNQHHsA1SwaW1dXT8rMZ2x9DWZm9rcxuwCRlRr+kq69V/EEefaKYiF2awNkQYwhaUrjYP+5XHVfRcXw2Kt7jXxWladQCDz4x3OhtK6EFeNb7r2z13+/UqWwaf1JPxi9s+5xCYyEfZn1ERqRAXcxibrwHHJtl59pjuMI28aSrf8W6uoz72BwJ1qN+iIsYk47o8lQYIaVDXB3Tg695/PcvVsyERZZkJcWgLcOO8mWIzciWaL90uxgADmuUJzxttVxC90L374UsrMNQmnT0O78L8aOBX9RSEH+aGC1uLt+wiHOWRO4/6ReFLjNG1bhsKjl6GY7Bgh7X49tT942QELM479WXZilyt1mQGNwkWg+8qub4RRXAQDka4eGpUxrBqT3A+zQDnG7o8QguZrM7tAYNZp4fw9VNyb+BybtjorE0rOOcNnJ4C2jvgQAZWJ6VuXBVchnlr+U13xihr0HW9dezaHZTG695UV1R+mX/9MyaB4I2NEW5N8fbIS/9Ws9Pzy368Cs4HV6sDspqIVG5geEKQMR2buN8vKkAR/LhO+bD6fRPhKBDRSeex9A2mqIV58dZBMsbfZYtbZeKlD8TmsfcQIyat0hnYInpZ8fqpHV2JP2akj6zGMAy0yZVkL1ZRDN0lTz1XfGPyuvJ/AnVc5IC8alNxOAZK63Tz3Ms2zAHbVVC2LD4NG08tMgzRxEHEQzcTSJSMrCMYoWnb2Cwkvxg8vmaE+y978fRN03qqiQXdKwNiTVqTz3nIQyCrqfEaA5pN+3P0b/KYd5Q9yXSSpg0739HZL7aAdp45+P9CeUGCYO7xwzPFkALWQP9v8GtJabmjaybep4TbEkujU/EtmphyryZ53fl7DtRNYQcvD0+4qEUxw9JjJsDjSRgWAYWTir2WaUcMU4oKkkg4YqHzy6uv0JkvOdjLvs6IYIs3e8y6kxbtYavcx7qu5lsQ7ynpq7rvwTto 1w+3Av/0 HZIEkyNk4vxKadx8T2znTF/62Q2uiXFweY+K7WMBYikY8WLahYSj/07arlJj3CTeFA5YMgiaWJWwKPrNy75KHR8g46JrQLa1S34ZR20y17mq9LDCLxa0qWrFVP4zINrG+Bt93R2OxqV69qoLP27+Aa0Q0JqGtqGBZdAkWaAblcb6dAV95YC7J0VVmzffGyeQ4UGHLYyCXOC9vajxh6DIBYvZNMqsi/oznJgiTAOi5JOJMFZCjKbuKzyFmbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 13 Jul 2024 21:24:19 +0800 Baolin Wang wrote: > Changes from v1: > - Add a dummy function in case CONFIG_TRANSPARENT_HUGEPAGE is not > enabled, which fixes a building error reported by kernel test robot. The only difference I'm seeing from the v1 series is the below update to [3/3]: --- a/mm/shmem.c~mm-shmem-move-shmem_huge_global_enabled-into-shmem_allowable_huge_orders-v2 +++ a/mm/shmem.c @@ -549,10 +549,9 @@ static bool shmem_confirm_swap(struct ad static int shmem_huge __read_mostly = SHMEM_HUGE_NEVER; static bool __shmem_huge_global_enabled(struct inode *inode, pgoff_t index, - bool shmem_huge_force, struct vm_area_struct *vma, + bool shmem_huge_force, struct mm_struct *mm, unsigned long vm_flags) { - struct mm_struct *mm = vma ? vma->vm_mm : NULL; loff_t i_size; if (!S_ISREG(inode->i_mode)) @@ -583,14 +582,14 @@ static bool __shmem_huge_global_enabled( } static bool shmem_huge_global_enabled(struct inode *inode, pgoff_t index, - bool shmem_huge_force, struct vm_area_struct *vma, + bool shmem_huge_force, struct mm_struct *mm, unsigned long vm_flags) { if (HPAGE_PMD_ORDER > MAX_PAGECACHE_ORDER) return false; return __shmem_huge_global_enabled(inode, index, shmem_huge_force, - vma, vm_flags); + mm, vm_flags); } #if defined(CONFIG_SYSFS) @@ -775,7 +774,7 @@ static unsigned long shmem_unused_huge_s } static bool shmem_huge_global_enabled(struct inode *inode, pgoff_t index, - bool shmem_huge_force, struct vm_area_struct *vma, + bool shmem_huge_force, struct mm_struct *mm, unsigned long vm_flags) { return false; @@ -1638,6 +1637,7 @@ unsigned long shmem_allowable_huge_order unsigned long mask = READ_ONCE(huge_shmem_orders_always); unsigned long within_size_orders = READ_ONCE(huge_shmem_orders_within_size); unsigned long vm_flags = vma ? vma->vm_flags : 0; + struct mm_struct *fault_mm = vma ? vma->vm_mm : NULL; /* * Check all the (large) orders below HPAGE_PMD_ORDER + 1 that * are enabled for this vma. @@ -1656,7 +1656,7 @@ unsigned long shmem_allowable_huge_order return 0; global_huge = shmem_huge_global_enabled(inode, index, shmem_huge_force, - vma, vm_flags); + fault_mm, vm_flags); if (!vma || !vma_is_anon_shmem(vma)) { /* * For tmpfs, we now only support PMD sized THP if huge page _