From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BD3C3DA63 for ; Wed, 24 Jul 2024 00:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2F676B0083; Tue, 23 Jul 2024 20:10:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DED96B0085; Tue, 23 Jul 2024 20:10:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A75F6B0088; Tue, 23 Jul 2024 20:10:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 691A36B0083 for ; Tue, 23 Jul 2024 20:10:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E17F9160502 for ; Wed, 24 Jul 2024 00:10:08 +0000 (UTC) X-FDA: 82372713696.30.CBC7E3F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id D204318003C for ; Wed, 24 Jul 2024 00:10:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="ofG0/hpM"; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721779760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UBKPYHIo/0dHReZDUIv9UmBi4i2gl9hvkPOYcr7+Y84=; b=QDdnXbLv+mp+CPmvYLQGUhzCQWrt8qhRQiXAMTluio9KgCbN7VErVqy4ULILVE2rYmFB9f bjcxaa2coOihh8dVXeYFF3RRqjRnFkeY4U4tMPpc/gewJz309RrKRL7nbMEvv4iufLhMxq maK3v7acwbwjGXG+nr8wrszQ0SUHsl8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721779760; a=rsa-sha256; cv=none; b=pOmw6rzpoVRGhsY04mSIYle57rVmRZ8NORCYuCatuB7PmxQnmML2SrQRQZhBpNT2THR22b l0r2T99ochyNVAKigrhyGUjMibtE89dZuTHFT2p7BSiggQINmyJ/CKdbHV7wx0e7NBu93/ CoB5CwXT46MCsPiD+bubdoGb8IpYLhQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="ofG0/hpM"; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D0319CE0F7D; Wed, 24 Jul 2024 00:10:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE322C4AF0A; Wed, 24 Jul 2024 00:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721779802; bh=9CN/RY4vfRdpsQn9GxNUWkqYSbCQ29VfUME3WRQQBF0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ofG0/hpM+KYsG271zku1f35HqiIkqLg/+sWaFtvXG/hvDZf8fmfu/6xkZutI5NjEG ncinuBc6bsLQoblI+p8ntHWR12ZdZZxkSCKcfhSSHkMf6a3FiIXxtopKpQ6DZkFDjq iWWSl4zDt12PtPYDIV0i1TIJHA7ECh8ZyuE4T50Y= Date: Tue, 23 Jul 2024 17:10:01 -0700 From: Andrew Morton To: Pasha Tatashin Cc: Shakeel Butt , jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] vmstat: Kernel stack usage histogram Message-Id: <20240723171001.b06f0a8053efaa7ec40e400e@linux-foundation.org> In-Reply-To: References: <20240718202611.1695164-1-pasha.tatashin@soleen.com> <2fbbxcsjs7vtzpb6a5wudbppcr2wgc2xwdw3cgs6ejzx6rioze@z2sct6rbulng> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D204318003C X-Stat-Signature: ajtqg3jc5tptinwuni9qy4oc9punouhs X-HE-Tag: 1721779806-339308 X-HE-Meta: U2FsdGVkX19+N/GYLxL9BmtP+gY3xdP1sEcZVeOt5HRSR+SCWdwTy61cEIMUFto84NuUPzfTCSfLV13AqxNzF8V7aekFTb1qA0rDFFuJT6foew2DNQTE0LBddMV7iI2gpeg7vVUh83UqmjNeqvVRHXgnJEYafX5+UepNL3PKXz5AatmegmWPlLFS6NkfGHi4u4h1e8td77c5V+LNwLsDugnJzYwLSC+DgqtYkthH1NUX/ccEqiPXM+V4pJAm6qZ08i87Vuwx5jauTBqgzLAhvcqQVOgSVSf5ykh+aS+HpsTY7+lkXy5nR9/wot/BjjsrryXb8Snn15fAWMumMdnuV8rT6AMzPZtgc1jdKyYnlXW1fUSmdflbI2sFftRCqdKUKRb10ubiEfni6mDFY3PdtrfYipga2m0fBLUZSkFpSwCLKEtB/F0X/BGQzXe0cevUu+KGWyIhEG8UsC9gnQffiUKJzLUAzxIgvK18Ex7Giduy049lq5+JvM9K2M0uaE1yurlgc7lSyzM4ge1IzEGry5xl8DXf07PcoC8pCpatEtq65BDOXWKZpDn7v/oPA1nqxhKlrSgdaWaZiQQuh6WlbZxy8zKDyCr4Z3AbkwMCrVzMyvqjkZNJx7BZCL8LxrmMLPm9rmF6Iz6rzBApwQe0qIpFkP/doDoRhjk6fTRccrl3kw+PIojwVgdmmh0WghZg6qrPP4YtaY+D/AUTZOO1fQbZPLf7Lq2VGQwJYhQze8hrsCxqbm0cT2/51KfPVDycojrMP6Xug2JheD/vfmZteKDdAkRXs/7VsrS127f81WhL3FJTrZ7B3S2IrLZ7hK4HTihGbuOLmXBs9FUeeRVYio8fOVW+roUk2TYA0n5g+mxQNBvcsNNTaavIpDS+rN3/TFlU6SIAbqrQFs9vGXQ557El5+scZMJ+/K5XFEyHQZ3xLkp8qMrPikkWMeJx3cinlF+XRDcft/fp/+ACYuN c81RiwcO LD/c61/80/qQpyqFuAICIKh1F7vcKI7JFa1KQVa3YF2ClOO1UfEvm3fH1BB+p8xKDJFyu7FjE0N7ed/ueEEYvAR53QXGKXpvFVTSVnhmgBPbFTaDmsqwDqEREmUyMneWTSIm2ygwpR7A/wE8psQH7EXtmTCYmISFxriBvsm9V9ajMButu04CmRIJak0Zir/AwpKSN+ZkUBaJViCrCx42u//pXI/W843/2UrGEB/7jdnvQt3C8uG6QAgnLKOWAHpYtYNFA0yPhCTWuowgLLsujF8NlvTL93D575mgU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Jul 2024 22:55:17 -0400 Pasha Tatashin wrote: > > > > > +{ > > > + if (used_stack <= 1024) > > > + this_cpu_inc(vm_event_states.event[KSTACK_1K]); > > > > Why not count_vm_event(KSTACK_1K)? Avoiding header include recursion? > > I could not include "linux/vmstat.h" into "linux/sched/task_stack.h" > because it introduces some dependencies such linux/mm.h and > linux/fs.h, uapi/linux/stat.h, and when all of those are added it > still fails to compile on some architectures, so it was just simpler > to stop resolving the conflicts and use this_cpu_inc() directly. Presumably uninlining stack_not_used() will permit this to be cleaned up.