From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83A9C3DA63 for ; Wed, 24 Jul 2024 00:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C9FA6B007B; Tue, 23 Jul 2024 20:09:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17B016B0082; Tue, 23 Jul 2024 20:09:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0690C6B0083; Tue, 23 Jul 2024 20:09:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DCFE56B007B for ; Tue, 23 Jul 2024 20:09:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 805A5160502 for ; Wed, 24 Jul 2024 00:09:18 +0000 (UTC) X-FDA: 82372711596.10.0305B64 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 507901C0025 for ; Wed, 24 Jul 2024 00:09:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OSHv8Grq; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721779708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BVNcQRyQNpncfxgNJFLA64BYdMh1q+bQeGI9fRfsSVY=; b=yfAvLGCA726j8YPLSWAlWlqDzh/vmO1VnR/Hu5HBHDrBK04w43o2l2lDWlnuNXXmtXXJOs /G0XtS/RuP6EVzpKaI6wW9dwhB5IHn+ls/r+a8/fDNB5q1cJe3cp3cpRsJbhIBJF4mexIa gr/rRYDxFwCs7oRKG2VxlLCHExBsl6g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721779708; a=rsa-sha256; cv=none; b=lPkII/EmFM4u61BiM44YvmoOaIe/VWkeiyIGYi2uCYcRsI0LgWPkvbaNe/lnnKqGEkE2Ld xbW8SVMJBOF+s1mT0/8tA86s7NZn+2q0UERYNOtqmrKU3/VHm6F5AAzY6aXTxDrKkwLL50 Gyx0qQHcdu6LydBuaEFzzsBrgaumOUw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OSHv8Grq; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2671E60F83; Wed, 24 Jul 2024 00:09:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D16C4AF0A; Wed, 24 Jul 2024 00:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721779754; bh=FTVVSpZk7VQoPlV50fSkq47XODk5/K3NfAmbZNp4/Pw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OSHv8Grq83NHqLdImqmyr9oVCjKtVJCSDJgZuaaaxVRnznRa5hdFZfxSWOpUZ/6Es ZRe6pbJhm54VbdLQagrVB/HXuJb7NMM2br8zxUmmcL56Q46QiuR5IO8tc3vYi5xSfJ bM8GwDLxqhJb5ee11k0j+oYvGwRkwyqcg4aaBdNE= Date: Tue, 23 Jul 2024 17:09:13 -0700 From: Andrew Morton To: Shakeel Butt Cc: Pasha Tatashin , jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] vmstat: Kernel stack usage histogram Message-Id: <20240723170913.07bfd0ba8a2557285263912e@linux-foundation.org> In-Reply-To: References: <20240718202611.1695164-1-pasha.tatashin@soleen.com> <2fbbxcsjs7vtzpb6a5wudbppcr2wgc2xwdw3cgs6ejzx6rioze@z2sct6rbulng> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 507901C0025 X-Stat-Signature: kqidpr1ng5jx3gkjnaio4nxkps9iep74 X-HE-Tag: 1721779755-353833 X-HE-Meta: U2FsdGVkX18AM/oVBSeyC5M/aNF3L3ddQ/dg7lKvNIWb7PdO8SNfasudHcvyXK6i1JOU/MdFV7bJ3YkJ5kbf2ZL9+qe0BnvZtjypQiNGi0sv4Zcgv03hMINIWvWSxfppKHxWwGKKDPnD0IhAd8ixSTIKT/MTk2qPLezuimtEoLEIDyezfC1L6Kc24LQpkOOZydZoLKi+XkzEEID/CpoHzUExs3Mf7WKjQ8p6fdIkwG+nPCV/km86R5R+6ARjKmDMQhttHITl2WrAHweiWwMsC8aLy3T4E4HvaKK3u2eRvRIwYQbqmIcGXwo2ipfGhS3BnMR605L7k3ARVImPyBSuB+lPF4zzczavBAdPK98EA4+pHz1fHUuLEIX9m24Twza/oDqN5jiE2jOwX6Q7rMu6IDjlo5pBH7eAu9FGwaW/ikZ9JatYe1N+0M22ErlC0cN4VWU6Sqq1Jbpr5yac3TCR5B9xkPUhD1ZVSzONA/u1Z5ixjSwQNnMaeO/Pc88uGI3J3xzPoeccblXcg/Dk+s/it/CDasB7YlEXRRgLWh/GFCAHOjLnRJLQ87r4bWgiMBgAicxJKZSfhB73+WtaRCQmSCWQAGLuhpgwc2c99pYFt1/dh21jCNXxRuUNEZ354OCrLxo1NqQYy0jSk187US/hLyE0Y3Nc4RvT8Se2e7TC0u7FGywWdzJlq8fxCAuKM4kpc+tgupQNfN4g+0HN9LkWhouyaLJrnYo2IICDgUKtF0YPo4hYYdeDBMJaoNGnZlNppxEaNB1sUHQmWmg7pqcLr8vPYjkHhSfrKCRj7GMCHZI2pjbw5P9QOzFdKhpDTWmx7sRuAsJWhalQWe157Ie6S5vY4MJdJwoVCUOxs7VpFR7TguBOEx4Xw/YRfZXIE7NmYIPHLetitKUFbWfqYKqVTXNS3/18NHk6JgZ5s+mZKAg6AtIBigxtMGa0Ugki6QJZA5guAGkz4EW8hV/b1G+ NQ+cpd1Q mznDpo8BtWnb7ky+8FP5bHwbacI6zZ8stc7y5+R+fncNir6ebefVSEb2m1csrFTZHImlZ/csTFQ7APEGTS0AOyvvtA83GqfE2neI6PCJRn7yKLEsTw1KWe/2KpOpO2YzamWnGR0VxK70GIOb4+14OA5B5Esv5omFho3y2RqVjU/4Puhmfrdlk6hl19lM1t78hBWfNq+jT9MeixUM0wii0jH5u2VzvppO0pfX8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 19 Jul 2024 15:04:40 -0700 Shakeel Butt wrote: > > > Any specific reason to add this function in header? > > > > For performance reasons to keep it inlined into stack_not_used() which > > is also defined as inline function in this header. > > > > Is this really that performance critical? Nope. stack_not_used() is for CONFIG_DEBUG_STACK_USAGE and stack_not_used() is slow. I suggest that stack_not_used() (and hence kstack_histogram()) be uninlined. This can be a followup patch.