From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2757C3DA49 for ; Wed, 24 Jul 2024 00:00:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F09AB6B007B; Tue, 23 Jul 2024 20:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB9286B0082; Tue, 23 Jul 2024 20:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA8DF6B0083; Tue, 23 Jul 2024 20:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD7966B007B for ; Tue, 23 Jul 2024 20:00:52 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 647891C0F93 for ; Wed, 24 Jul 2024 00:00:52 +0000 (UTC) X-FDA: 82372690344.16.40FAAF6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 05154C0027 for ; Wed, 24 Jul 2024 00:00:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EzJL24fz; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721779212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vzFnI6Y4felxfS74OTxRTJ+vCbnVkwuB6xpFmwtc/OM=; b=bnM699AB0VcKfS2V4DV+VPUdyNwZyaoWDC8kEM24IfflbfV3h9rrMn4/nvJxsCTk3lTf0D LGRcCMcr6Dj8WR5yGRmEINn4e+kLSgJDcLWxSaX91P65I4Uvk2zoi4G+0ycdMLJ10uRhqS rYv+RR3XSlffRynSYDptkgqpTh9iTZk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EzJL24fz; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721779212; a=rsa-sha256; cv=none; b=69aqeTHaKQDUQ54zfYxactLyQcZc51n94o6/DN8He1gY0ILPDVwkVioRduuHsf3zL2vkHa HTS4bdjtUDFJmQCb3eGsGPZdcfU/H4oDvvB/Ahw2rXaoBLW1sCDXdgVUGKrp/3+1isenMS Blt9HzktBaps9WyMAgUB0OVIrXi88f0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 71236CE0D9E; Wed, 24 Jul 2024 00:00:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E6B3C4AF09; Wed, 24 Jul 2024 00:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721779244; bh=rmPwjbRwV6UTdwW/TMU/GQEr4t+ww1mvGbY0I1Jio4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EzJL24fzv8TXjAMRAncNA302gR1raXLAmZS8qFPzPtg5BQDHZq+w+eGRadykzdRbX I+WIwhSzV9XOf5c4B/DZN/RifOkeM4r6XxmY5e+PgjJNKrhZL3MvP6NmVr1G8ZDC8z 087khawI0nFNKkk6Lxgxr8uvTpVS5dx/1egnwT9Q= Date: Tue, 23 Jul 2024 17:00:43 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Mary Strodl , Christian Gmeiner , Christoph Hellwig , Mary Strodl , linux-kernel@vger.kernel.org, urezki@gmail.com, linux-mm@kvack.org, lee@kernel.org, andi.shyti@kernel.org, linux-i2c@vger.kernel.org, s.hauer@pengutronix.de Subject: Re: [PATCH 1/3] mm: vmalloc: export __vmalloc_node_range Message-Id: <20240723170043.4f17a3d0b6280e57561ba1f5@linux-foundation.org> In-Reply-To: References: <20240718143103.82e33c556b2d1b6145ae43e0@linux-foundation.org> <20240718143924.43e22f68cf639b064a83f118@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: hao8hmqmuxrse6wmxsoz8iqeb7dtdjmm X-Rspam-User: X-Rspamd-Queue-Id: 05154C0027 X-Rspamd-Server: rspam02 X-HE-Tag: 1721779248-563857 X-HE-Meta: U2FsdGVkX18R/LdwNCQM9ULe8K1mgoLnxW8O3UcvWBIfsH4TnpXUNHlxOeX1l7uXjytrnjLmzZ/pCQUP3JY4SU6W6R2LqqKtUNjyNWzD6w/m2tiLuhxcTtdzvdh0T0V0cd9n1ghB0Eyzgp74s80Nv07evztVdDLJKbEdHQoyGz7GXHNG8BXpxbs4LXiUJyEnEM9Kq646ybnoOjOUudOxpePpPxF7ADzw504lRuHcnDnaJf0Ysy8tvJkBBFqxrwnktA6ykHdRWCju/ANA+B4UaW7uIhGnaqnt3iBIxsSBWptDEBGRDKBNTiMoSstPwyEDQklanjdHK23w6UL2qmWKfCWVI+Z7rhQnJHCIPaW+fJTPhD1sjdJHu3S86l9RMt2UZkeWSY7dy//jdMTA1JJlWf8+M4eiOpjxpWaUfCo3vH60BrHY1uwaAdOb5qYPB3Zcht6YoX6IZ+xi/Lw7QD0++OwPlYnlyNV6y4sXmeeGBlWpwKXSNfKDm2viZCOI0farJDQ7pO1HZ9O6Km5C8TmoisiIFN6WsiQ2JF90rG+JvVd1pA/YfAJj2Vx0dckLbjj0VoTQKPFr4qyyQjoKkv3OqgtYY1sB3uSWJsZpMYuEa73QQpQmtlN7EsFFZ5KRxn5hIpzBSfQGbAxh9lTKv/xL2xTlLlWdF5eqIPaSlExx0IZGbbwYmA3Jf1ERztR4SWqfvtLd3hUYcIpwXewgdpNeeSQK1LFKR3kNpAbgtcBiAkAEEYgVwU7CBETm3FZaX6RvVjzoWq8YWJGTOBGjy3URcQxl4UeJk8vHOS04bAG0rXaThKy40oA/tzskAq+9gm3MNMYJa6h0kmBdxXBvWkt86F+yEn3m+1hkeCZkoLO5rANHpNiq6KRe8YPhLx4upU8SnJs9WpKSqdTLoq2tD8JT9naFXEo/bLNVvM5mBfopqhMOJQUa0l+b6Z7oHrh+4AdiF3qy3dd8NSqyMXlEmJ7 luxJQpKG Jdtvy6jS2IcR/v5gZ+I353P6RE5kHigF9Rna1RxGQ1uBzbP+RZOE6KU9yeFnZ1WUOLyzdUZdDODFoea+gpFikEwdaMwtW8E8uyi+z5+vQqd8+vfY0vpQdRejmib7vZj57h6w0EwBwTE/5pWLcJsac1iwao09aybCcHSqW/urCTq6PCdlv6i5gO2m10ZUL5WqglxONguqrYjQgVmpvrz0NOZKrxo4EHTZEILCRQLOFM+SYAA+NmERQ5dftMXI6uLx8MItd5fi9VHyZpIElqW9eZhpoOCMNriyOhdd+0fEhbraI2EaQ+Nty4OFf/dx2BoOhQ9PbOI/hFd7xa0AFcduLuaXa1CxgruDkxa1BmxTvP/0N8FXurgbFDVgpn+VWhVF7SqKbls5gY8+aAZTdmQvE7x4SDkf5YoWq8PWhFLaOrdt9s3c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 19 Jul 2024 13:42:40 +0100 Matthew Wilcox wrote: > On Fri, Jul 19, 2024 at 07:58:40AM -0400, Mary Strodl wrote: > > Maybe some of the stuff the driver does right now could be moved into > > vmalloc? In other words, we could provide a different function that > > allocates an executable page, copies memory into it, then marks it > > read-only. Would that do better to alleviate concerns? > > No. We are not running arbitrary x86 code. That is a security > nightmare. Sure, if such a thing were to be done we'd want it localized within the driver rather than offered globally. But if there was some hack within the driver to do this, what problems might that cause? What are the scenarios?