From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54014C3DA49 for ; Tue, 23 Jul 2024 16:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D30316B00D3; Tue, 23 Jul 2024 12:08:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB9846B00D4; Tue, 23 Jul 2024 12:08:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B59E16B00D5; Tue, 23 Jul 2024 12:08:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 963436B00D3 for ; Tue, 23 Jul 2024 12:08:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3674D80244 for ; Tue, 23 Jul 2024 16:08:54 +0000 (UTC) X-FDA: 82371500988.17.F2D1EF9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 218434001D for ; Tue, 23 Jul 2024 16:08:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jb9AvqCN; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721750885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GG7qwBZzr2wjNPZU6JiIInJ39mSnopHAQkP/I3BXx8g=; b=dVD0V9o6llPzcJJgPB3gLvFSHFueE0Ez4sy+bCnqD1qkNSiJfqZ6/jK6ZZLrHxF8Z3lpFb nbHWYrpb21l8+UD38WFv8Ad/MiVe1SXAY/Z0E35jsCNqb2TJfAHyL65iQfEMLIiaRJq9Bm dXKgh+XvoM6MCmhOc5+2Rde1pf2EzAo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721750885; a=rsa-sha256; cv=none; b=yOtOOeZdL7wgflU8eQMeBQs+F3/JloUdSMf/JxjFUa4pnyIJQYo499y0tQbsR2g21B2AvY t+K5OmoDEljAZ9+UzE1lcdZ/5oaVovMIBMdjgF5+Xw3Z6GdRn6ETgQPjl0HYA+epRRnrUB wwZk0ssIvUg3HC+oWvsofmrUGZald9Y= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jb9AvqCN; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 23BBDCE1103; Tue, 23 Jul 2024 16:08:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A813EC4AF0A; Tue, 23 Jul 2024 16:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721750928; bh=TVPc1L8ah/pJaakJ94/QGIwGWqWh3TdItfYh+mGDVDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jb9AvqCNPdExLJtTo6a2ZcsaRTiO0dyFlFtR/UqyspiF3PDDwv2yd0p3EY1Wz7xKO IgoxhsD2rMksoB7aqVXCf5LiegQu7stE64K2RFXYlw3GqjUPzxlDiVpzKvDRgrmLZ/ JlzC0iB/At05koblM47UiNrX77yPLKmmRgXT4y0pj2q+NI6Xx50BhKws2NXvtk9tDV X5zdhb/nO1R9EnmvTVtShDs24gEu5zRZP0s29FTlZECLvWghB/cybk8iS+RP0uOy8l kvdyC/fMVKGuMmXQeGS4QgYbCxy7b+CxKh4OWu5T+DQY8xd7ij7Yy63YLZnSuj+W+N jK4c4kdRDxvsQ== From: SeongJae Park To: flyingpenghao@gmail.com Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, Peng Hao Subject: Re: [PATCH v5] mm/damon/lru_sort: adjust local variable to dynamic allocation Date: Tue, 23 Jul 2024 09:08:43 -0700 Message-Id: <20240723160843.99979-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240723035513.20153-1-flyingpeng@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: cu56jjdwuaesn71463mpg6y5y86gjns9 X-Rspamd-Queue-Id: 218434001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721750931-656959 X-HE-Meta: U2FsdGVkX1/Db94PzU2AE7Zbb0c4xKFjnwmcneoWL33UbwoOoLhOviGa3R6pj9wWeJ5NMCwtltKO8EJLmkTQi0oewsVZIL8tcdYXlLiuKuMGg14F1jZZDtIF5wbm8wwaxq9YeJhJ030RdqtT0rNCr1IkzDLjc5i+ZYxfyQjD2OE9w5ACisDM1E7mr59EceiYNmiwBPRoXLYnHpTaH+I5uvVY+0ng9oDHB/bwZ8/PMxHzXcUuCsxn0Njjn73sXLat+CD1IK85m9js5owJPW2rD0RuBX+6IdmAvk2K2iCIBgOY9XyqankKMMn0EaziGUAyp1kSRf48D7ivFkouW/obHAC5sWqnUg7leYdGy8hEMwTYwp6pBddXwj8Kh7IRnqBVcW04f3KB0gO0yNiAWiyrNwxQzxTVOoeo9mXxjQK4LrEbr02s4yUFJ6dU3zpPqCqDA0mDE8AOYNqDCW9h5d7jMu6C8m2jO+yaji/d3HrZ0NPPTxb3+HT5f44YlhtJ4wRTntZikegbknwsnyxugVNR6FpW6wVv5PvH8+pzcjyCSzuMUJs0h6OvjiosYhAPGYCQkiRCrAEkPydiHEDieCr37Ytrybcakek31RQCoV0NRvKTrtxHCbT7CE+jEDY7c1oFsFgIzlbsKmshjqU+gqXg+fzde6g0JQ3oOxc3KV+T+kHU+siHlyTPhrgc9w2xE3S9UYDEBvaUIhDZzuITKFgQgRkeSrxJRl/Nqh3MkOGe7xD4CA+6Nm/K9eH5R0TWtVrCGNSsWElEeBzp39edzZFkgzEf4ffzn91qTpu/TJlPfKIMNuUnWQPckID7IpYg4yWnkVwG6WZnr/nRaaaAUzP5r5wDmeB4tY2jAxaKAJzr7dDoOkj604Hb8MfPQj9x0VBBIeNe9JHKAOCfJOSbs8C3uqxTBeBovhiSj0CPqVP/IFrPPKxEb92kk6KYj2rS4QG+x8lF8bXiIc4RJrK/Xnk sQGGO+xT czOvJlDQ6op2r1rnQO8G09Vb+D5RmYIh+Y39m65/ltpzNLws55OqHo4C+yxN6NRYzJ402jSC/vRqapTV7bguwScYAGMeLgrLLW5YT3Q6nUs/M1gGWeDLU9h0JorHcsq65h1AwUjsH23Glx/xccCdlMUrmPAhKW0IfzVsrbUwph6pOz/5OB6Dfi+ZmjfAagsTFVkbCx1Ez7aAuRmNRIzzELm7UTRlkXCJ+ZVVFjK5C42nH/w5SI157nmkk+YJYpJWp6cDxpdjsBeDqd6wtnEYHmCl/3GZ/RRV9YR6eBEaVwUWk9R450v5e/cpWjdDgGFEZkCPsTGZN/LMg/TZl1A/LwUJ2n5459vdl9QnagzlEdaSt4mE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Peng, Thank you for patiently following the discussion and sending this, Peng! On Tue, 23 Jul 2024 11:55:13 +0800 flyingpenghao@gmail.com wrote: > From: Peng Hao > > When KASAN is enabled and built with clang: > mm/damon/lru_sort.c:199:12: error: stack frame size (2328) exceeds > limit (2048) in 'damon_lru_sort_apply_parameters' [-Werror,-Wframe-larger-than] > static int damon_lru_sort_apply_parameters(void) > ^ > 1 error generated. > > This is because damon_lru_sort_quota contains a large array, and > assigning this variable to a local variable causes a large amount of > stack space to be occupied. > > So adjust local variable to dynamic allocation. > > Link: https://lore.kernel.org/all/20240711081051.66560-1-flyingpeng@tencent.com/ > Link: https://lore.kernel.org/linux-mm/20240719174234.47017-1-sj@kernel.org/T/ I guess above two links are for revision history of this patch? If so, it would better to put together with revision history under the below '---' line. If not, it would be better to add more clear contexts on the commit message. > > Signed-off-by: Peng Hao Except the above trivial comment, Reviewed-by: SeongJae Park I think Andrew would handle the trivial comment on his own when he add this patch to mm tree. You could post v6 with the above my Reviewed-by: tag if you prefer to, of course. Thanks, SJ [...]