Re: [PATCH v5] mm/damon/lru_sort: adjust local variable to dynamic allocation

[SeongJae Park <sj@kernel.org>]

Hi Peng,


Thank you for patiently following the discussion and sending this, Peng!

On Tue, 23 Jul 2024 11:55:13 +0800 flyingpenghao@gmail.com wrote:

> From: Peng Hao <flyingpeng@tencent.com>
> 
> When KASAN is enabled and built with clang:
>     mm/damon/lru_sort.c:199:12: error: stack frame size (2328) exceeds
> limit (2048) in 'damon_lru_sort_apply_parameters' [-Werror,-Wframe-larger-than]
>     static int damon_lru_sort_apply_parameters(void)
>                ^
>     1 error generated.
> 
> This is because damon_lru_sort_quota contains a large array, and
> assigning this variable to a local variable causes a large amount of
> stack space to be occupied.
> 
> So adjust local variable to dynamic allocation.
> 
> Link: https://lore.kernel.org/all/20240711081051.66560-1-flyingpeng@tencent.com/
> Link: https://lore.kernel.org/linux-mm/20240719174234.47017-1-sj@kernel.org/T/

I guess above two links are for revision history of this patch?  If so, it
would better to put together with revision history under the below '---' line.
If not, it would be better to add more clear contexts on the commit message.

> 
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>

Except the above trivial comment,

Reviewed-by: SeongJae Park <sj@kernel.org>

I think Andrew would handle the trivial comment on his own when he add this
patch to mm tree.  You could post v6 with the above my Reviewed-by: tag if you
prefer to, of course.


Thanks,
SJ

[...]