From: flyingpenghao@gmail.com
To: sj@kernel.org, akpm@linux-foundation.org
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
Peng Hao <flyingpeng@tencent.com>
Subject: [PATCH v5] mm/damon/lru_sort: adjust local variable to dynamic allocation
Date: Tue, 23 Jul 2024 11:55:13 +0800 [thread overview]
Message-ID: <20240723035513.20153-1-flyingpeng@tencent.com> (raw)
From: Peng Hao <flyingpeng@tencent.com>
When KASAN is enabled and built with clang:
mm/damon/lru_sort.c:199:12: error: stack frame size (2328) exceeds
limit (2048) in 'damon_lru_sort_apply_parameters' [-Werror,-Wframe-larger-than]
static int damon_lru_sort_apply_parameters(void)
^
1 error generated.
This is because damon_lru_sort_quota contains a large array, and
assigning this variable to a local variable causes a large amount of
stack space to be occupied.
So adjust local variable to dynamic allocation.
Link: https://lore.kernel.org/all/20240711081051.66560-1-flyingpeng@tencent.com/
Link: https://lore.kernel.org/linux-mm/20240719174234.47017-1-sj@kernel.org/T/
Signed-off-by: Peng Hao <flyingpeng@tencent.com>
---
v4 -> v5: rebase on latest mm-unstable tree.
v3 -> v4: adjust release point, tweak format, etc.
v2 -> v3: don't change histgram array in damon_quota, dynamically
allocating local variables
v1 -> v2: don't modify global variables and change the histgram array in
damon_quota to dynamic allocation
mm/damon/lru_sort.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 4af8fd4a390b..0b35bd5fb659 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -148,12 +148,17 @@ static struct damon_target *target;
static struct damos *damon_lru_sort_new_scheme(
struct damos_access_pattern *pattern, enum damos_action action)
{
- struct damos_quota quota = damon_lru_sort_quota;
+ struct damos *damos;
+ struct damos_quota *quota = kmemdup(&damon_lru_sort_quota,
+ sizeof(damon_lru_sort_quota), GFP_KERNEL);
+
+ if (!quota)
+ return NULL;
/* Use half of total quota for hot/cold pages sorting */
- quota.ms = quota.ms / 2;
+ quota->ms = quota->ms / 2;
- return damon_new_scheme(
+ damos = damon_new_scheme(
/* find the pattern, and */
pattern,
/* (de)prioritize on LRU-lists */
@@ -161,10 +166,12 @@ static struct damos *damon_lru_sort_new_scheme(
/* for each aggregation interval */
0,
/* under the quota. */
- "a,
+ quota,
/* (De)activate this according to the watermarks. */
&damon_lru_sort_wmarks,
NUMA_NO_NODE);
+ kfree(quota);
+ return damos;
}
/* Create a DAMON-based operation scheme for hot memory regions */
--
2.27.0
next reply other threads:[~2024-07-23 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 3:55 flyingpenghao [this message]
2024-07-23 16:08 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723035513.20153-1-flyingpeng@tencent.com \
--to=flyingpenghao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=flyingpeng@tencent.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox