From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6FFC3DA63 for ; Tue, 23 Jul 2024 03:43:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44CA86B0085; Mon, 22 Jul 2024 23:43:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FD6C6B0088; Mon, 22 Jul 2024 23:43:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2779A6B0089; Mon, 22 Jul 2024 23:43:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 07CEF6B0085 for ; Mon, 22 Jul 2024 23:43:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A4A64121B18 for ; Tue, 23 Jul 2024 03:43:09 +0000 (UTC) X-FDA: 82369621698.13.4ECE599 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 9EB1D100010 for ; Tue, 23 Jul 2024 03:43:07 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h4Mg0VG0; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721706164; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z8drHD9Jhai5CXRn1c7yaLoe/54xU5BshWoGMTrI9n8=; b=psRk0lX1/Esubjm6+aQ/fmzLeNGhDCMyz/LT+kS5Yu1TXE1AjMtJdy6Ofe/08c/nDz8Bww eOpVKC7dB8RMILohg9xRmEFZ94Ofs1r8S1OmM6bdWTQ57Oe88KUJEeevfzIsgXvOGmSb3J Gyz68y76iZwvFgTFC6IYfRdvMxtR+Cs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h4Mg0VG0; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721706164; a=rsa-sha256; cv=none; b=dYTS47LlwzdcQc9VDKAJkYptRoSlJF7mWcjNTX6rsBnYuF7fpgaHqJD+SrHheX5FADws9r vBv7nkpRW9WN9t3GyUPXXa72JOCjGABVM9Sh1VPogZi//Jb2OdrEU5KwGpRYE3Qx94NJv8 5q+2EDSfhFrvsXaSTXi+QsErq4yae8A= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52f04150796so2245319e87.3 for ; Mon, 22 Jul 2024 20:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721706186; x=1722310986; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=z8drHD9Jhai5CXRn1c7yaLoe/54xU5BshWoGMTrI9n8=; b=h4Mg0VG0DAd2/pUPnKShiiEiGFy4SWsrqLHtXG6lxG4enPPBuE9SkvTmrLm0ax9Xsd DPLeqwa5p2f+FXEPbxutc/wvLZvgddCr5kDGLhJANnywld8Bzcy71LCg/414D8CWZ6CR t6G+Jb2+5QKqBDoZ7UK/yfaAyPb1f51OxwWcws7FRbiEQzl1SGlutyZW3L7af+4HRKki raMuAMuv0c7EbnjNKLXaVY8iWEjhyxgvnZd+Y/MwvVPiT9aKwZolKtJsNqaB8TbacSMl sck+q1kV6JjkZXr/RpGnmVKjSOvFoRCoj+oR1xqxVgRzjcaT9j9HkxHX8cGoIS3CBDJD RCQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721706186; x=1722310986; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z8drHD9Jhai5CXRn1c7yaLoe/54xU5BshWoGMTrI9n8=; b=E3OPjqKPrKPdCguOvP8X0Orh5RdjPQkAHWqAPWc2AWaEYNsBNQh9iIxmCupjRoLDW8 uGkSoPl5VZsNUij1hbqbQO7wicdvna0hG8rR8ND/GO1N6U82p0vpoXegnKQAtSUBUHxv jKvI5gTKvtP0AygHEMllndylRceFSJGYhWiNzez3+kvQ6wy33warcnSEplq454acQUTj cuVLWR3QVhElSK4/tKtVheGKCf9TwwP2hKcEc8mDUD3hG6R2skEKH85v4AIELMYst2Am hQp8o35H8i5Ia8ooFPOp5SJ0DgaJlhE5tEqGfAdQVeaTVa5A9cEi4Kz0KSxogoLbHdKS hJHw== X-Forwarded-Encrypted: i=1; AJvYcCXBSwtVSMDH4p/M+k7yZItNrX0fD8AlX5S6ME9+7zWetVH4Q3EZwWmejFadGea/TEXZjdgBKPP5q2jCqDq4JPoMF8M= X-Gm-Message-State: AOJu0YzxxLbx0raKvKXP90TIX017I3l6wFqlpNaF19Mw8wXmgZ1C16Qx sVAQHXjGZQESpOBnFv7fa3A/pYVlx8rpXiVR7dv06mLxrYehNh+6 X-Google-Smtp-Source: AGHT+IF32v8kFk8Basd1MM0Ibyww+RyV7twqacJiRpCzVI455Xzz7OyQnvj7SRhtGGtqiOPkiemjbg== X-Received: by 2002:ac2:4c4d:0:b0:52e:fabf:5adf with SMTP id 2adb3069b0e04-52fc404c831mr829754e87.36.1721706185377; Mon, 22 Jul 2024 20:43:05 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c94d7fcsm484033666b.192.2024.07.22.20.43.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2024 20:43:04 -0700 (PDT) Date: Tue, 23 Jul 2024 03:43:04 +0000 From: Wei Yang To: Wei Yang Cc: richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, linux-um@lists.infradead.org, linux-mm@kvack.org, Jeff Dike , Paolo 'Blaisorblade' Giarrusso , Alasdair G Kergon , Andrew Morton , Mike Rapoport , David Hildenbrand Subject: Re: [PATCH v2] um/mm: remove redundant assignment of max_low_pfn Message-ID: <20240723034304.4kbzxsaapxanxms4@master> Reply-To: Wei Yang References: <20240615034150.2958-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240615034150.2958-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9EB1D100010 X-Stat-Signature: pniw9acqus4pngdb8zqobd6fyohqahui X-Rspam-User: X-HE-Tag: 1721706187-157879 X-HE-Meta: U2FsdGVkX18TA7vWBHx7Ynt9Y7Qb1MPvNaXm7t2XRZmHL5PUeAShYFAJeMTVbhWlqQmgmPo9mHW+GKKew/jUho21kaOCZLJ2lg1vIXqdsvoP636Rx/WMFTsYklu0jjLvUWZBiCXMbrFJwWNon57FkOfiow2svqFQxLl0WaCZTnC6W1QY754uT5arcNtFXt3wCW/aGpxXHLbf2qFyFgeq9RAHwUSaah/+UulMArnjADDpT1mxpWFzuk5MeZIznS67Y96dUDT11pU8JgMwRdNKstqw0gDNdBgerlZw419q819IrYhAQwhOTbcIpN58geZF+5MiKMUxkSPvWYb2VwyDfE2bfJSOgqC5m43/eXxg5Xt/Rn7bS4e9LtV7wqO6CwxX0G8i7Uh/aBEyHWsRNMITPCmwpyRn9kYYZluHX/akqnvSmGFLcBn4VR7Tp9y82Je8AfRU/RYGyYkQGyQu12PalW2fqBKjwzykhu1p17jQ7IvYtSX9L3BXPVduHdmNlRVotwqqqUIfqKdyTAn+jw3HWIHYaTdtOyw/gYMNGo/F6HrQiF9uaIohBszyJTbEX61vTvrJasjJ7E2N6+No9rK+ajkH+2Me+LJA9IQc6sZ/Q55fdGBPS2VjjuR/r2Fpgrm6yxtycAevg0BqmRWcFcscIup79TXJ/LaHcx6rdFdvi9wP1tShYzV35p7jDuxXzyLoQ5ExpSO4v+QhV+jXnitYM6lOXGs6aOUayY0q3bCONowDSRWa3QcWeE2lyzA4OAH6wYchshKpyWZvFdK9FPJE56xD403hCnM4ay5t8T7v8MPHFPkOW373LRa2U9dzts91s0H/xrf8bx1s5cmpg556ffTUyUcAu4eQl3nx+cMVP6/wbWY6QntCRmLTiByGIg8RmZu5y1vxmPNIY0zejaZj4osHHz74khlIGpi0843zpEhRvsszl47XmPcmK3PHMlc5rjFf8eNTCkfNmNWNPUR KtGlk7Ch OjF2Z6/qqPmFRQeig4CRRVpKONJMe43KNZEhrkazRjGUsDgY1LYab3w7yYrIPoovC8R8ohyyPW74vCAE0skvaItCKCTK3woCQKhnezIRwYq9ekGMSuXGkE9PIl/HT1lzW39jm0iD4BVy7Nra/qCVxBv9JUFyGahY2x+khHoOGrE7MXNrBV7xuOkHqr09qKZqGrzXDCV2YutRcjFUnxORmR9pgqablixrjZ3Ju1HoEAhjWX33NtCPbV+9OQLj3hmG9G76aN/Es4OducYBzmVJzYVuZNjSaVKGNo3SeOMvPqgLnVtX7i2eEmiifH+lbVNXcNhcNeFVWMP152eXIhueFhfgyZtSPXRDNYMC+rVzV/XCg72JWU9jw0U4IZTAyROL++cPydrWBE3xolHlZjpWbf5jI922sQn0gcSEiIQ4GgdCUI7+R5u61NrtU1LlyUvALkFPiZM/wN1XWrRFQFkC0+FW1jb/9T4Wv442qC9oI+vSOVBaZd6xF5nTbLgU4fhDQLjUZdG5wmKLHSfDVBhRjDc12cbaqwIaUcMQn8zuYd4b+p98ZR22K9DkRyJQDXKH5yjfcgb+ibQtyxB23jzvSEIMuojNOvDFJ5GUjJV2vqCl0WOKe3NhwgeQoHYPobOPYIg383k2Dlu+e4RjmgxqE4dy9HIzyM6OvAVxJeMYmsCkyS2Qp9o9mdXAhs5F1AUY0F38xe+No9gfc6ZBxYguQtD0+rf/hJBGrxv0+iTX15TgyUvBQBtk8K+hvYKC5aMbZ4JsWPnqMda8/HRmYpE7YkfUAxDfdD6Ty1EPtp6y+3BhakbuM/WIdXf+6lOlQFSY7t3/3HKsTxKLnHhE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Would someone pick up this one? On Sat, Jun 15, 2024 at 03:41:50AM +0000, Wei Yang wrote: >Current calculation of max_low_pfn is introduced in commit af84eab20891 >("[PATCH] uml: fix LVM crash"). It is intended to set max_low_pfn to the >same value as max_pfn. > >But I am not sure why the max_pfn is set to totalram_pages, which >represents the number of usable pages in system instead of an absolute >page frame number. (The change history stops there.) > >While we have already calculate it in setup_physmem(), so not necessary >to do it again. > >Also this would help changing totalram_pages accounting, since we plan >to move the accounting into __free_pages_core(). With this change, >totalram_pages may not represent the total usable pages at this point, >since some pages would be deferred initialized. > >Signed-off-by: Wei Yang >CC: Jeff Dike >Cc: Paolo 'Blaisorblade' Giarrusso >Cc: Alasdair G Kergon >CC: Andrew Morton >CC: Mike Rapoport (IBM) >CC: David Hildenbrand > >--- >v2: remove redundant assignment of max_low_pfn >--- > arch/um/kernel/mem.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c >index ca91accd64fc..a5b4fe2ad931 100644 >--- a/arch/um/kernel/mem.c >+++ b/arch/um/kernel/mem.c >@@ -73,7 +73,6 @@ void __init mem_init(void) > > /* this will put all low memory onto the freelists */ > memblock_free_all(); >- max_low_pfn = totalram_pages(); > max_pfn = max_low_pfn; > kmalloc_ok = 1; > } >-- >2.34.1 -- Wei Yang Help you, Help me