From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4542DC3DA59 for ; Mon, 22 Jul 2024 18:49:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 929B86B0082; Mon, 22 Jul 2024 14:49:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D8A16B0083; Mon, 22 Jul 2024 14:49:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A1116B0085; Mon, 22 Jul 2024 14:49:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5F7646B0082 for ; Mon, 22 Jul 2024 14:49:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 00F4AA1A58 for ; Mon, 22 Jul 2024 18:49:50 +0000 (UTC) X-FDA: 82368277782.06.AFA8D39 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 4211E1C0024 for ; Mon, 22 Jul 2024 18:49:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IBms8LWs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721674155; a=rsa-sha256; cv=none; b=cQy0kcnGiuLA/0B/e6qFMsRljYDE2k1aNtWr/9cjjvjPynlILMzq0YgEX3GemRbySPTYi4 3cqZjg81eU6zRdqhV8vcCOdf1QKaCtJEUkyoeJ9C/TWGF9wBPPCxVKMhry3KHRhfHWsMh/ RiC/LMX5TWKtpchGNGDciZgkXwOXqJk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IBms8LWs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721674155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p+mJXCCs0QuYv2+1xczCvSEuBwUy7Nf6op3myau22hU=; b=ql70876c/E7ou+elMzJEmIgw3/tCE4O4o2ZtwynN0ezZMdRptIxpSGebj0XYq+FdD6TtyS lSKGFhZACw2j5/OFgcxKUI8NZSflm8vDdrd1u1bVL4Z7BNO53Uu0aWgkao4jhFJWRhTWhC dAG1rC5yGvTvXGDcQ7C/yfRNaVWggR8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 26CF560A23; Mon, 22 Jul 2024 18:49:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C150FC116B1; Mon, 22 Jul 2024 18:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721674187; bh=hn2upQiYP7UVVh8YpM8DoUA/iiPMNNLXkyFWhtd6TGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IBms8LWs1INJ8qU8LQbNwfD24Z1JMH2ALkqUiz1+amOducuM+VnOFlLxwg4sSu3U+ XAibCPEgvlACgIljS48g6I++6RFK+HTnm32dmMc2SAxs7M7mgMkse7vfyb61ZTX6cr zTAMengMyghWkM8APV0aumjr4Pyom8l/9PmMPZDcxfZ1WLpLAuuhEBRxl2RT4Tz/mt /C+JeFVPa1x/DwJHd110I5P/944BxoevH2giXoQGAfnNGRwi6SvyOhlP8144j1iGb4 +Pq44mn9lLHInUC0ZEyG80RDIPJ34u2NNRxB82IV6hTA4NONZN7mp3xxDhxM2y4RPE AjDMvrh0QZirw== Date: Mon, 22 Jul 2024 11:49:47 -0700 From: "Darrick J. Wong" To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, ryan.roberts@arm.com, hch@lst.de, Zi Yan Subject: Re: [PATCH v10 10/10] xfs: enable block size larger than page size support Message-ID: <20240722184947.GJ103014@frogsfrogsfrogs> References: <20240715094457.452836-1-kernel@pankajraghav.com> <20240715094457.452836-11-kernel@pankajraghav.com> <20240715164632.GV612460@frogsfrogsfrogs> <20240722141220.yfxb7jder7mqwgod@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240722141220.yfxb7jder7mqwgod@quentin> X-Rspamd-Queue-Id: 4211E1C0024 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dxnswa8jjkwf5xtnwji5dtg4ch9rbsni X-HE-Tag: 1721674189-151080 X-HE-Meta: U2FsdGVkX1/CBDGXKpT+FPoXYWxrWgDD5+deE9ji9ldCqOQ6kuoEyfhyWn/QPgW8o3KTOMh14RCK1b/jW3p4qtacew4kvcW6OZDd1CV32mlK7+D2Cj3zvmTF+dijT0Ij+g6tweFVPO/JvKtj5wJr2tLfjr5xF3hxBCiD2ZbM0OcGEyirpKrJtgHMhkbkJVmpgmH7fAuNgvRPg4Lm3pg0sxIZTwODCJQn2173t7JEEPrwwvG5C8flVmKePy1fJziG0gN7D0ib+USUEE77nb0nVVb/CxW3JxouQkOYTr8oAlS2wvdTv5enY6P3lik6GofCTWfOW8T6l6RXRRR+5Xm7GkqmOMVqcgxf1wRY2fMYXAprQNIq5KlI1rsy7zZh2aj6j6iksyHob3fn6fZu/EXx+VCcOL78/JBDV74+jg16AVMj+nacNoIPCv+riR4u/TZeKCcQBxxpI1fR2L3IXRF0TAvrs0Gj4h/xKZwGKtaepkOK2Vw6aymIo9nLTizkSPYpyoZFDRspUyTJLbYFW8cqwGQk+HupwJEazTCH6GwZ7H8Uh64ia4KoUwqarkCMcMX+4Q+tyyelMcP/Bw3kRh6lwx7woqgGigBJ/b1mCsgMSMau58gbMZ5Dz2rUkcsmNFJ1SyGJ3gcveOORFBWpAQnZBhuj7tKl7gyscwsQuaex29E+lf3KTfPA1IKt41mGG42ilP1Uw+QF/oNb3U0KenH1hw3ai7JrHK7auAoQKw0L8xGKzlxt8k1kXVp7XK0TGGhto5ySqlBQIFjQv70GSqD0OuAMy5ogQqoAnoEdGuEI5L78i3TJMjXeOsOOpPH+xb/Bw0y/xi0aRI7kziQo5LnN3Rm+gLdtr7k7pD/7+fzRSUuYXNysIOmtGoDziDznObIr/h+sL2lxzHc9W8odFD6U36RaRNrhE8dz+9ucKkCS0XWFUQH8l0a9epXRk3ajWmQadSsqwS8eND7X7lQU1gz gfCtY/VD nacTQ6U/CUOvKCBDohHi5Wh0qDmm9RUHuCEqjecTz5mffJqaxvgt0LyW+73eKvsbxTTbNMGbJJj5R2p6SIXRe9rFxMn6E/5DII5k4AqMjpYb9yNMAyjZebuG1ewDM7eyaW6/9DRSyCMXb72pYxI/m9I02PcAbObW286QVCgS1TAXmaVQBbkWBgTa7eohtT6qZG7OIvErHWYIJZ9+Zis99KFuV+ns39XX4A+s/gT2oxMvKfxEZQOt5lb4c/aVuR8NVK72VRI74stS7dq/jrKxE66Vawg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 22, 2024 at 02:12:20PM +0000, Pankaj Raghav (Samsung) wrote: > > > + > > > + if (mp->m_sb.sb_blocksize > max_folio_size) { > > > + xfs_warn(mp, > > > +"block size (%u bytes) not supported; maximum folio size supported in "\ > > > +"the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)", > > > + mp->m_sb.sb_blocksize, max_folio_size, > > > + MAX_PAGECACHE_ORDER); > > > + error = -ENOSYS; > > > + goto out_free_sb; > > > > Nit: Continuation lines should be indented, not lined up with the next > > statement: > > > > xfs_warn(mp, > > "block size (%u bytes) not supported; maximum folio size supported in "\ > > "the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)", > > mp->m_sb.sb_blocksize, > > max_folio_size, > > MAX_PAGECACHE_ORDER); > > error = -ENOSYS; > > goto out_free_sb; > > @Darrick: As willy pointed out, the error message is a bit long here. > Can we make as follows: > > "block size (%u bytes) not supported; Only block size (%ld) or less is supported "\ > mp->m_sb.sb_blocksize, > max_folio_size); > > This is similar to the previous error and it is more concise IMO. Ah, ok. I suppose printing max_folio_size *and* MAX_PAGECACHE_ORDER is redundant. The shortened version above is ok by me. --D > > > > With that fixed, > > Reviewed-by: Darrick J. Wong > > > > --D > > >