From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B92C3DA59 for ; Mon, 22 Jul 2024 14:12:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C725D6B0088; Mon, 22 Jul 2024 10:12:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C22236B0089; Mon, 22 Jul 2024 10:12:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE9EB6B008A; Mon, 22 Jul 2024 10:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8F5B66B0088 for ; Mon, 22 Jul 2024 10:12:35 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DC02CC17E3 for ; Mon, 22 Jul 2024 14:12:34 +0000 (UTC) X-FDA: 82367579028.05.EFCCE2C Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf23.hostedemail.com (Postfix) with ESMTP id DD1E1140022 for ; Mon, 22 Jul 2024 14:12:32 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=PXuQRyta; spf=pass (imf23.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721657530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y5Xo3wX+uawUJqw7uA4WLjrLhTEALsLM/1oRvrJDUlk=; b=7ZOGRGTsqgMMvBD+4YivqUbU9KVQia6muHbaCqrMPEv2AZc8RFWUFrVAhuM6f8j1n8pwO1 7JFpSDqFz2/9j8nJ/P7sq/n3fZ6L5Dobp5KhlNlv6h+i1K+NKHX2JjASnp9qqh7++Xil8a e8K5V6/LwemSB7PpS/Lo12VSmEe2WxI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=PXuQRyta; spf=pass (imf23.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721657530; a=rsa-sha256; cv=none; b=VPnE6lo4v785VJCJwpvwpskXdBtjYkiRMWEqUl46i1ftAGqlnOuoFjcuNAuuHKvi0vSm9u 1XxMCG/wUtkJGQ3rAPb2cW/IkOcDPXr+b2/1A1UrXEj81ad3aoRdGR9ODogDauv31Pr/p4 0guVWg1udBbQso0AO3Rdlf/pJIGv4r0= Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4WSMfz5qRFz9stk; Mon, 22 Jul 2024 16:12:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1721657547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y5Xo3wX+uawUJqw7uA4WLjrLhTEALsLM/1oRvrJDUlk=; b=PXuQRytaUpGN7kf+yu98HpPlESNqnRQU/ex7u+sGLE06XGC9p8gwH1AoB3UQzjDxZYONAi l4rjOuDXiUIv1rRzRPPCiqoFKcmL98MYAPtd4gD8FTo6FzhhvI/jG/RgPy9LK/CGaKupYK Wu/52h6Y+pLTMg/iuyIL5CzGqEH6S6muUB/Y95kyFtw6UWygorgEyNidQjFJlOA0TYXn8G FqYivrOu2AV4sBmnR4lf45MW5rTOYBhAoTcbWLJ4J10KQupuIYBSCo7/wwtCJzL44GpYrS s1+ErgPmNvpenxQcvT3EARhkfVyZGNMBXPLrPBUdVXHTqQvK4Vyzky7ghMlEtQ== Date: Mon, 22 Jul 2024 14:12:20 +0000 From: "Pankaj Raghav (Samsung)" To: "Darrick J. Wong" Cc: david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, ryan.roberts@arm.com, hch@lst.de, Zi Yan Subject: Re: [PATCH v10 10/10] xfs: enable block size larger than page size support Message-ID: <20240722141220.yfxb7jder7mqwgod@quentin> References: <20240715094457.452836-1-kernel@pankajraghav.com> <20240715094457.452836-11-kernel@pankajraghav.com> <20240715164632.GV612460@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715164632.GV612460@frogsfrogsfrogs> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DD1E1140022 X-Stat-Signature: 94c7yfoiodiz9smaewihsiyi8rnnbtd1 X-Rspam-User: X-HE-Tag: 1721657552-351072 X-HE-Meta: U2FsdGVkX18XJ6mKR12ljRSn8MMotuk1CY7eibARK/I94Crib9HuW5guGhIMP+9m8aWdQbRZcletcLvZ85ZDTKggVoET8tT1sTuHHUVFXoIhZki6lSTVQx7RqAVChnxB0y02pgUkSe3poJylKuKS4fLsCFRoJyPj2NhLqVlivD+uX9923YDOXzQ7splbOo7Q6T2DXipDdwsFdNtSTFwkhdrcOUpiuyO259U7aAi2iZ9X255H275kw2o7xYZmikevYurSpggGEOMGfe97+BTANCUbimTbN68B9sCZFi+afmBRWbGEPF07dmD/zo5T+jLjjJ+sNCC5trP0zDtf8Mo2UK7q5JVXJHK1l3CAso9cJBEMYBwFL0Xwg4b3kR5OS9bVNqa1bXKmeGEWS0bV+QGOVxd2N/8trjYIyuMheHEK78Ij2uMwXcG9/OTm6EnqtqJvFA7pU0VbNkqbiNFBg57taCPCHx0tXkC0ud7b+lIsGVsgTZE3Fs33uDRaVPofmKzm5PRsZ8zsX8UjWIbFlgmfzN1QPnrAs6hlL3ePdxo+WMGB6R8kwUx6kxOreyu59mTbV/uucZW/Vx2NKamr4rgoeCxQqdD5b/nku6SqApOUrRUPlxvcwO11YbPxaExD2hOn9rBGfpybX7oF8gQ6gsDICzi2or0Dtf//Mz6m9x2TbDYknLzH3iEo1QwUDpSYh4K0WlvK/ciQhWCpvSXgrgRKoDQ1kW9CBZMIfLIhtjPR/JTkHXQws0tDTjPKgUEqoFD4E1sW+S+tdGudm7bLhBo0JXoZvXjFr1PwNAArZscsEU1/M/gS30eVG8Zppv0OqWBkQJ1d7qFWPA1dOVW+RrUyBUFyycGvFadTTGYX0EZg8LFnVfhHpxYLrcrWpqSTcv5rC6h9MCFHZsqp6PVYeNPckVciki3BRUKeJ0eORZQLJrvxtWPzfKxwIUkNRAM6oYrHZRsjduHVUocFVLrCoH7 XVYDPkF9 WCP+KKPordYt7CoskMO+SQHT8CD6bqCBC0M/FMXkoqpZNUUAgPP1UFHjxleaF1Yg/H514mJKKtBBgU+T17yplkH8XaFIms+twATOtKcgtGrWvqFPe9ma6V69JAZwnJQWk8ojwuZj1KsRl7dLnEhHYLchyHd+naVvH1EMt5b1iWDXHe1obUOy2yuwQbKBkf13VytKegd/VEnV/uDHzsCrbV01+4s6ERfWCkGJ284CSmXbzQzabRWj59h08dC8nKoST+gJ7KSeFHYhpXQMg97ZvMnmiYK14AF/vHpNyZN8pzKjLFpeirKef7+YRHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > + > > + if (mp->m_sb.sb_blocksize > max_folio_size) { > > + xfs_warn(mp, > > +"block size (%u bytes) not supported; maximum folio size supported in "\ > > +"the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)", > > + mp->m_sb.sb_blocksize, max_folio_size, > > + MAX_PAGECACHE_ORDER); > > + error = -ENOSYS; > > + goto out_free_sb; > > Nit: Continuation lines should be indented, not lined up with the next > statement: > > xfs_warn(mp, > "block size (%u bytes) not supported; maximum folio size supported in "\ > "the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)", > mp->m_sb.sb_blocksize, > max_folio_size, > MAX_PAGECACHE_ORDER); > error = -ENOSYS; > goto out_free_sb; @Darrick: As willy pointed out, the error message is a bit long here. Can we make as follows: "block size (%u bytes) not supported; Only block size (%ld) or less is supported "\ mp->m_sb.sb_blocksize, max_folio_size); This is similar to the previous error and it is more concise IMO. > > With that fixed, > Reviewed-by: Darrick J. Wong > > --D >