* [PATCH] generic/732: don't run it on tmpfs
@ 2024-07-20 7:13 Yang Erkun
2024-07-22 14:20 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Yang Erkun @ 2024-07-20 7:13 UTC (permalink / raw)
To: zlang; +Cc: fstests, linux-mm, hughd, akpm, yoyang, yangerkun
Like what 4fd042e0465c("generic/732: don't run it on NFS") say, the same
options for tmpfs won't share the same backend. Skip it for tmpfs.
Signed-off-by: Yang Erkun <yangerkun@huawei.com>
---
tests/generic/732 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/732 b/tests/generic/732
index 7a40f49b..2b83f216 100755
--- a/tests/generic/732
+++ b/tests/generic/732
@@ -22,7 +22,7 @@ _cleanup()
}
# real QA test starts here
-_supported_fs ^nfs ^overlay
+_supported_fs ^nfs ^overlay ^tmpfs
_require_test
_require_scratch
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] generic/732: don't run it on tmpfs
2024-07-20 7:13 [PATCH] generic/732: don't run it on tmpfs Yang Erkun
@ 2024-07-22 14:20 ` Christoph Hellwig
2024-07-24 13:24 ` yangerkun
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2024-07-22 14:20 UTC (permalink / raw)
To: Yang Erkun; +Cc: zlang, fstests, linux-mm, hughd, akpm, yoyang
On Sat, Jul 20, 2024 at 03:13:23PM +0800, Yang Erkun wrote:
> Like what 4fd042e0465c("generic/732: don't run it on NFS") say, the same
> options for tmpfs won't share the same backend. Skip it for tmpfs.
>
> # real QA test starts here
> -_supported_fs ^nfs ^overlay
> +_supported_fs ^nfs ^overlay ^tmpfs
Can you please spell out the explanation here?
We should not have a _supported_fs call without a comment explaining it.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] generic/732: don't run it on tmpfs
2024-07-22 14:20 ` Christoph Hellwig
@ 2024-07-24 13:24 ` yangerkun
0 siblings, 0 replies; 3+ messages in thread
From: yangerkun @ 2024-07-24 13:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: zlang, fstests, linux-mm, hughd, akpm, yoyang
Hi,
Sorry for the delay relay(something happened, and cannot use pc
before...).
在 2024/7/22 22:20, Christoph Hellwig 写道:
> On Sat, Jul 20, 2024 at 03:13:23PM +0800, Yang Erkun wrote:
>> Like what 4fd042e0465c("generic/732: don't run it on NFS") say, the same
>> options for tmpfs won't share the same backend. Skip it for tmpfs.
>>
>> # real QA test starts here
>> -_supported_fs ^nfs ^overlay
>> +_supported_fs ^nfs ^overlay ^tmpfs
>
> Can you please spell out the explanation here?
>
> We should not have a _supported_fs call without a comment explaining it.
>
>
Yeah! Thanks for your reminder, will do it with v2(maybe until last week
I can do it).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-24 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-20 7:13 [PATCH] generic/732: don't run it on tmpfs Yang Erkun
2024-07-22 14:20 ` Christoph Hellwig
2024-07-24 13:24 ` yangerkun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox