From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00AFEC3DA63 for ; Thu, 18 Jul 2024 17:46:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EE9F6B0082; Thu, 18 Jul 2024 13:46:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09EC16B0085; Thu, 18 Jul 2024 13:46:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA8CD6B0088; Thu, 18 Jul 2024 13:46:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CD0246B0082 for ; Thu, 18 Jul 2024 13:46:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2C1141A0187 for ; Thu, 18 Jul 2024 17:46:16 +0000 (UTC) X-FDA: 82353602352.03.10FD193 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 1F7794002C for ; Thu, 18 Jul 2024 17:46:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nj3znlN3; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721324733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5tJOiP9geGh+PBDaSIwd4EWhLjZg5oYwlg1OmW/ness=; b=CjcyAZ4fW55mC2+cj+gLmJGT/En5w9CH5xd5kcpv1G8KP5JBtTgurfqDpwMRp6S0JWOuw0 OfdEDgI2XbUsF25LNIEJ6NPsOOdgtM1OI217yy5t6BHKB7v6G1fPuk7PSL/zvdE/ySrBBU mtqTWnqgqCwf/GBloU90ge4dn8piXKc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721324733; a=rsa-sha256; cv=none; b=o5Bf/3hNo7zTqAQIPzC1hzMAge9+Mr4zdhbDxrat2pBsTOAbfobXKHO6OiULA92/m2UY5B VEJtPWL5GaowG9SkH15ssMfWBhWTyoeqKuDFNIbuy+1c/hB+BR32b0jR72nr6jetSTv9wI qD7pXI74MoV0hS3JRZMfnVeolq6vrUI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nj3znlN3; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6555DCE1A65; Thu, 18 Jul 2024 17:46:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AE0DC116B1; Thu, 18 Jul 2024 17:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721324768; bh=FZDUnmMzTHtLAXj0DJWdawnws+McoB3ISL8JL9ZoqBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nj3znlN3AMkMwF5rQdgZV+lF2XeAWxMV018XmeSJrCra/irgx1ml+Ts4wL5XHFGDn IZh75axRhZ4XO6r2EZ01HBw3E/RtbbPg//PY+ffUvFRO+9k5nNT9qxsslUst13h7TL GmP8K8LH1nvt6u/Lu9zly1GlcC3zTczZ5TGX1mzqjStBvM8EsD1CUjLXM2EkIu0WSp p24PS0vIPCjL9cUeyWvwiBYToHOD/Tp/XnKFpLuSHvSrFvsEK8jnTYwToZlJ956nlx ZvDOSyDkG6jG4nE9B+pAPwZMm4Oluk9q8a7KadRnGtFIBm5IltlobcQxQTOf3jtr4T LGX0zyysQAIqg== From: SeongJae Park To: David Gow Cc: SeongJae Park , Kees Cook , Al Viro , Christian Brauner , Jan Kara , Eric Biederman , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] execve: Move KUnit tests to tests/ subdirectory Date: Thu, 18 Jul 2024 10:46:01 -0700 Message-Id: <20240718174601.64851-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 7do8mr79wd8mwhtxormyea4r5ta63wts X-Rspamd-Queue-Id: 1F7794002C X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721324773-411972 X-HE-Meta: U2FsdGVkX18L//RM4CzH1k0PfxGnwP44D9L8cFxnVnDMTZ9DP/VARFFd1wPVaUgS2aP6jjpVxU2P5fXRbZORaCGHtWNAyHOp+VztNluT8Yw3T2FvI1OxJ56lGExl77nzZbfjlfBu8PA2AQ34JkV7riWHefcSdn6IccTQEMw/bhR0+tj/8RlbSYABXnwwGTIgTXzod09RYULzPDVovWirESU5eP54wKfF/d7Ys49vMfkhJW21ipLXG+OBGd2eLwMD29FAM7NmeLzRKJcePOQSVnbNURyuieBo/5bfX+8+tVy95hqaR9h+7/C8hKNFYYORHKqW0HfOQsjbW3v7BsjRZGkJW27r6xRPZrd8kEJ8AhE5BO7hQdY/SdiTDf8bRaAjwXfeBWgmW4X5qFz6h9Tpz9kCD1+krPjGDcvFE6NUu4IOxHqi1IcAd4ID12/tujIw9d/h+f8Mx6PVFaG3KrF+Qo0pfZvWd5uDyDHnop5BkNCUE157aXb2fV5Szqv7IHsDfrlI1lqTuxpbuZ455W3M8nhJeXeTLYjw/mkI/eimvY2uTnHD0Tx/QECVMLm/FnluvlXf+OmCiq3tipCN9qwbrOq8UErVn6c0lWzC5FrI2NMKFedbtaG+HfqqtpfiLnFjsSYSWIXhFNQbUw8XZXSQf8sSavd6RIFnjuDWqFHm+Up8DfelIihbvEKN55lXcTTNrzELUOD/NImTYlMaudLaCZYSYGg8/7ddKvP7/Vz9Ivr+WZ9fAeG0L2CYganxVbhAzEy92ObsOl27ZEc8sRQIm5wZt8VvsHuTf8dt0iNS1Eil1ZCMxoaaS0qmVbNOuCL+rrc/MG0JJ9dmOTaQdWok+kIMyf0ZVm1kyg47OcZadIg5L/tsDPOLskhRyX5h5my3edth6kVgvTvWQpl3ascQQ+KtruDJi+TAm7DP+/TAt1RuT3EfjBEBF1DC4BRchCZ72yMSs7+YKnk9pbhKsly +5UAx5RQ cC7dhuIaY4rpKiZeT5OipVkPS3a/AH9/6hHFKovcQNiWnAncSY1xTKkOsLzeaL0Px2tlehE3ok7tgFKFbhflk6wsiJyA644+NJg3RAuQ1dJoWLLgaPcOcZOwAbaqLyPGyLyZOCt/AS5piNyqCkVYcJSIeT8NP3T9vkXs3jkDCFyj5svh89/91L7YFbRxXRs8oXb8f/PmI8wzlLv73nvXM4gG3xCBRZggRLuvnNOMNt99tdxr5GgDnDBfGlC/z8g2pZS6GICprOSnHO7e6mwnkYQT08WXHoUYRHp7AFnK3ChWs9udzXZcEfOlR/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Jul 2024 14:04:14 +0800 David Gow wrote: > On Thu, 18 Jul 2024 at 05:22, Kees Cook wrote: > > > > Move the exec KUnit tests into a separate directory to avoid polluting > > the local directory namespace. Additionally update MAINTAINERS for the > > new files and mark myself as Maintainer. > > > > Signed-off-by: Kees Cook > > --- > > I'll toss this into -next and send it to Linus before -rc1 closes. > > --- > > With s/_test/_kunit (once the docs changes are sorted), this looks good. I have no strong opinion, but I agree to David's rationale [1] on preferrence of _kunit overall, and would prefer having a consistent and simple rule. [1] https://lore.kernel.org/CABVgOS=B29PcKyhVXtTk47k_BhjSaoxL8eF15fVhzty_0syeSQ@mail.gmail.com > > Reviewed-by: David Gow Reviewed-by: SeongJae Park Thanks, SJ [...]