From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA423C3DA4B for ; Wed, 17 Jul 2024 13:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5B896B0096; Wed, 17 Jul 2024 09:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0AAA6B0098; Wed, 17 Jul 2024 09:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAB576B0099; Wed, 17 Jul 2024 09:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8F48D6B0096 for ; Wed, 17 Jul 2024 09:09:24 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 100B8C079B for ; Wed, 17 Jul 2024 13:09:24 +0000 (UTC) X-FDA: 82349275848.26.D0CCA67 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 88B684001D for ; Wed, 17 Jul 2024 13:09:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xzJm8ufW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w1N8++Kj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xzJm8ufW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w1N8++Kj; spf=pass (imf11.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721221721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1X5zF2e3ed+7pjk1P5AqGhiD9y5udzLMGekEyZDkQwg=; b=5tCMaWJ8E9haVNwQObrRQfM31P+oJ/drmoszKiX0qSZcFsYXOx6CTpO6JwtDqlbI1Bzkh+ nZF8YuSvDL2GE7WHQO0RVxn+PeriHGwgsCTmrXZ5xlBnLxIXj+ImFrJcp6ZS9/APCM79i+ wuDbaQ1NrQiw2Vz5qwNwE7mqIRxr5rI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721221721; a=rsa-sha256; cv=none; b=Y22mRS5pC5yF3WG8DrQGEBAShK26kOKfbDDakx8IJbnvWOyRKOQ0eSZqmZJtKSHH+k+xk5 +1Lx98TA+cup2iYV5rGe5/fDTM9f57AUyg030grZ5U8NPkdQrQssh3kuQNTldVNHSdup/3 ZIsPVhk7RSLT4jT/Jw3TZtGveYFzFXg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xzJm8ufW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w1N8++Kj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xzJm8ufW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w1N8++Kj; spf=pass (imf11.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A7D71FB7F; Wed, 17 Jul 2024 13:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721221758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1X5zF2e3ed+7pjk1P5AqGhiD9y5udzLMGekEyZDkQwg=; b=xzJm8ufWPOXoASQt/+4WPUw3gFMHZJKHC9QAqi5cBAEYq5m5uedEsrgPOqPFf23LRAv7Ip F/A+08iE0bjIXCSgktBfCH1PnFyY6a4E2B67Cfie/7KaS62NYFGm9JI8mBQJMu8GQ+xfsB b3gv1K/z4/cy7EMbwh9ThTsh55GQetM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721221758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1X5zF2e3ed+7pjk1P5AqGhiD9y5udzLMGekEyZDkQwg=; b=w1N8++Kjxoge/oODrFK/HCgJ5Kn+60DCUumksA8HPskvOnFtl4pyFlNoO+2Mult3/WJj8k D/MNpz5UgpeGEAAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721221758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1X5zF2e3ed+7pjk1P5AqGhiD9y5udzLMGekEyZDkQwg=; b=xzJm8ufWPOXoASQt/+4WPUw3gFMHZJKHC9QAqi5cBAEYq5m5uedEsrgPOqPFf23LRAv7Ip F/A+08iE0bjIXCSgktBfCH1PnFyY6a4E2B67Cfie/7KaS62NYFGm9JI8mBQJMu8GQ+xfsB b3gv1K/z4/cy7EMbwh9ThTsh55GQetM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721221758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1X5zF2e3ed+7pjk1P5AqGhiD9y5udzLMGekEyZDkQwg=; b=w1N8++Kjxoge/oODrFK/HCgJ5Kn+60DCUumksA8HPskvOnFtl4pyFlNoO+2Mult3/WJj8k D/MNpz5UgpeGEAAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 037A0136E5; Wed, 17 Jul 2024 13:09:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WTTWAH7Cl2ZSawAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 13:09:18 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 9E773A0987; Wed, 17 Jul 2024 15:09:17 +0200 (CEST) Date: Wed, 17 Jul 2024 15:09:17 +0200 From: Jan Kara To: Joseph Qi Cc: Kemeng Shi , jack@suse.com, mark@fasheh.com, jlbec@evilplan.org, hughd@google.com, akpm@linux-foundation.org, ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/4] quota: avoid missing put_quota_format when DQUOT_SUSPENDED is passed Message-ID: <20240717130917.sbxkbgglhwq2wcrg@quack3> References: <20240715130534.2112678-1-shikemeng@huaweicloud.com> <20240715130534.2112678-2-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Stat-Signature: 5bwmkowe769wewr6p3ox538cso9wuyfg X-Rspamd-Queue-Id: 88B684001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721221760-583726 X-HE-Meta: U2FsdGVkX188drDhen/dOIj1I9g45Nus2N9k46x6h5Skcfe0j80idCwRlLUHYI4Rq4ILyxgh+dVBZrjdF3LWMY39hjh1yB5xbY3UlnGRljdIX3U9FpVQoLBqs/X5OslElTsQOO9Anlwh5eXYYSMZkIIuwQZ30X5R9pl9G2JPBjyow9n+ND2eweKLlvHNmuYwxmF3q+I4Qp1/7kTOrh8/bY6Y8mcp9GIUvXiPZWBN95zFqZHM3fqzt/mVXIzyIiRjrNi+IR+5EFP8QOtPlmE/400Tws8N5nC5R2UE/Yk7whk52kBKrUK9Lji4xu9/2uBoDSD4srJ6bWJAChzhbJ3D3zjVSLqTWENiWmHWGeIxwkLOEpUZ1Q6s67AEeDuRzYT2aDL7vZ3dYmcly2s65WCy3YYU1OJoIvTmRrD2yhxyrUID2NDjMNosQmS9A/xMUKkqe4jV+64Is0WQrNtvHwqxs3n/UyM3im97K/HUOQ7KzkU7hmuicLhTWQ7MK92sZUaiUDg5gANK5EbDt6/gStqvb6qV7Tqrikyr3pdmEgeUKR+l14Wwla1CefzTxJggzxgMNEaDbXnweq5rOvhdqxyFvRMj7sf+MyMIC33ynKDJeUJW0QJSIPJLEAnwX1HM6T8hb5MUTc2DFGnFwkeDdYeCu/iBZUp3AbXTn+gRajcFTEYHSQnv0Mae/0UKKbK9voyUjQFfjJhvPfoYf7o1fxThhtBvzL1PZTHPeTEDXyfLPSFnNWbKC6RskbxPlDbMQeFS3B/IZVsLqREKwaC0JWBXiAxMarQaiwQIZnDBX7Q6uj+pRZJrwiT1obAceMk+8tu+XiA2TpfcMMn3z9qbJoo4LGR2j3ycarjYy5jo7Dr4FKctKmtcxL99pjXi/h5DBSFcDOTyuSgrfSloobs95CQ8Xq7V7337ejldoh4tU2+jLGJbdcoEWB6pX9KcMnIrayOCMZM+GGXCzYBrN0cYAfI ikltRkcX q74nRaXMxAj4gnGqWiaGme60yvSAebZ/132UrYRBHRur6iqOPfs9on+gaYrSHnlyoAzZ0qKUFrRoqvGA56mKDWrZHGkh5YtfG1kr5GKSErYl4AfVJAGi1YgF/TMUH9dFtyNR+Tph8cfCoFGjKPjV/kSRTjPNctVk1NuBP1fVdymfUr3d7/a8jvLqCxGtLsMGESWLf0TtSHL4K0vehIdX3OkcwFuqXFAj9aAKLFmbAuXvXqDdi4iqo2++47jhb+A1xCVWo4HM4rV/dLxBAJdr/qD1FdqnOB2UGtYoM7Y9oyVGtpRVCL899UiYc5z/5wbyIQ1vTrghrGGHaoxQ4wVOeG1/AsvH9S0pOGe8d07GVCpolLd0MPuOgcsWEZWBZ6xzABPv9TICsXwJ7THkKR4JFZ3bOxkdf3MJl2TNuQ7XNd+TihnJ2ayukqr7zPM3Gj/bDtbj9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 16-07-24 09:10:18, Joseph Qi wrote: > > > On 7/15/24 9:05 PM, Kemeng Shi wrote: > > Avoid missing put_quota_format when DQUOT_SUSPENDED is passed to > > dquot_load_quota_sb. > > > > It seems worth a 'Fixes' tag: > Fixes: d44c57663723 ("quota: Remove BUG_ON in dquot_load_quota_sb()") > > Other looks good to me. So with the above addressed, feel free to add: > Reviewed-by: Joseph Qi Thanks for the patch and review. I'll add the tag on commit. Honza > > > Signed-off-by: Kemeng Shi > > --- > > fs/quota/dquot.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > > index 627eb2f72ef3..23fcf9e9d6c5 100644 > > --- a/fs/quota/dquot.c > > +++ b/fs/quota/dquot.c > > @@ -2408,7 +2408,7 @@ static int vfs_setup_quota_inode(struct inode *inode, int type) > > int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > > unsigned int flags) > > { > > - struct quota_format_type *fmt = find_quota_format(format_id); > > + struct quota_format_type *fmt; > > struct quota_info *dqopt = sb_dqopt(sb); > > int error; > > > > @@ -2418,6 +2418,7 @@ int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > > if (WARN_ON_ONCE(flags & DQUOT_SUSPENDED)) > > return -EINVAL; > > > > + fmt = find_quota_format(format_id); > > if (!fmt) > > return -ESRCH; > > if (!sb->dq_op || !sb->s_qcop || > -- Jan Kara SUSE Labs, CR