From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0684FC3DA4B for ; Wed, 17 Jul 2024 11:33:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 904936B0089; Wed, 17 Jul 2024 07:33:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DB826B0098; Wed, 17 Jul 2024 07:33:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C206B00A4; Wed, 17 Jul 2024 07:33:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5A2746B0089 for ; Wed, 17 Jul 2024 07:33:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EFA6980A0D for ; Wed, 17 Jul 2024 11:33:07 +0000 (UTC) X-FDA: 82349033214.18.0DAED17 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id 9E7E84001D for ; Wed, 17 Jul 2024 11:33:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hMsptBmj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tq3u9ahV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gaNocMnS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kKm7CLs7; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721215952; a=rsa-sha256; cv=none; b=6G82BKRuDNrV9hNuJFzW7QS1TJRHg4CvAsx9stnps79xdGaT+dZiv/uOJZw+1G7ZhqcTks Cw8Moydo6fvJyUS0KByr9oMElaDy0EIOExnAY5Z26g6XAWGf9wxseIhWu+jJicFgFyIFER SelaW2C1IyP3pbZ9uIUTsTteOWkZRo8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hMsptBmj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tq3u9ahV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gaNocMnS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kKm7CLs7; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721215952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GDWXncWUPfRdiXS4Mf0WhNRYE+bpXbuIBFaPu+Mnb8M=; b=2Ec+cAaTJIWUzIvEEWvQCd0lM1QN3g24DRMo1zz1tjLysSsWjJOmkA+uHXGSQH0PYop4+8 I3N3UU2QXYMOPYI7Z1CQ4+sIdNmdVqj2QkP0Bbd15HKCTFc5oQLr9P8SX7HwmAnc8xFopr 4ohgIjB7EEnvI6pwJtFSmjQQc4vwmSw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D370721AA5; Wed, 17 Jul 2024 11:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721215983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GDWXncWUPfRdiXS4Mf0WhNRYE+bpXbuIBFaPu+Mnb8M=; b=hMsptBmjNU6rqyIbeaU0d8oEGFKY0kJZSYd1H82L1btAT4NZJeeX7O6DtPDjKwe1RdEtGN kuL/edSLPdLI7UqkCK/iqOAXpEVP8VdjHX08hvzY1ntyMInBT9hIzC7E5ot473OCdVvtZT 19v1iwk38lAPRsKM2Okzv3cS6LelyXA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721215983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GDWXncWUPfRdiXS4Mf0WhNRYE+bpXbuIBFaPu+Mnb8M=; b=tq3u9ahVvypk4IIzTiz7d3p5367WC4QsQ3UC/ero+aDb87v/meTbgkVXAYTv0/Ytu+UCzu Mx2YAQGQ4qWIa/AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721215982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GDWXncWUPfRdiXS4Mf0WhNRYE+bpXbuIBFaPu+Mnb8M=; b=gaNocMnSgqxFpDhUTYHX86oOpSRl2YwuWzfWq/F3wFq0uHTLY7toMcsxVIaHD7UrWI5w3u oXyuFPyUxCVTlweug8NXhjudmXpKzR32KAVF1K/7BW6nU+GWJzvFpRfQphbUswfzLDxtAC o8OJBsfIBdoGYWk8Wr/x79KwKqVv/Sw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721215982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GDWXncWUPfRdiXS4Mf0WhNRYE+bpXbuIBFaPu+Mnb8M=; b=kKm7CLs71ZBkvKG9H9zYZ959pvqlwWLAwKrP5XNx/vMlVd4c73gVswVHt/fatpIK0lXVgq r+ZkGVAjrXgSCZAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C341C136E5; Wed, 17 Jul 2024 11:33:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id A52mL+6rl2Z5TAAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 11:33:02 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 7CEB5A0987; Wed, 17 Jul 2024 13:32:47 +0200 (CEST) Date: Wed, 17 Jul 2024 13:32:47 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 7/9] ext4: switch to multigrain timestamps Message-ID: <20240717113247.hih4trvudsdbrwts@quack3> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-7-48e5d34bd2ba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715-mgtime-v6-7-48e5d34bd2ba@kernel.org> X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9E7E84001D X-Stat-Signature: 64dy1znanmqujxpj3g1y9n4orzbwm569 X-Rspam-User: X-HE-Tag: 1721215984-453943 X-HE-Meta: U2FsdGVkX1/AoF/cEaOTnTxxBbCppxgOuRUsHy+v6YwQRl7RF9V8P8MoXl/HMMHlK5TRtIN+q7TGnF1RQ0VrwxcOfOCHkyvOPKyJrV0WiSpbjWSkaHlinpeMKDH8U3j14URx2pi/cLRGqxjzKwVt/+0alzWqMKsWKFkqB1Bv7JAubTW4+Fq4t8qhn/khJKmoYs4Y+dEm3M9Bk0aj42cRL/pke/zJ2GnMUW35PX/Z2ThrVk41C+4qntNf/yPiMk/Xzmw/1K+/vWl7Ec8/111PWDwuYnXGVcLD9F6hToVng9wxVXmn3uvDOMNFqi8RLG0nVj3Vktw6fvIiA8tWb/4M8+0b8DoI4Y373BZh2LsZ+lfb98SULPOjXAIK0PDSv71b5AFgpBG0Cjo2dLfmIz9g8fSn6nRswdVCgC8X9dTGREttM05YTN2tS0NnV/qGPk5Gc23j2Okig3aUxfu3+cwAHyKjtqCwK3SU90uZ/LXAUqXV99JMIlnWtye8XYen4HWE37a3n2Lhl2d4y7hVpSnBzU57JpSimbOD1Zcn6Ix4gZbtLAbx/454qc7X3o3BM7lYnflalD8x+7tu+66yQ8S0vBa0Yb9/s5DA2fa+gB86L0uiUKhJcBqjzvzLrOlBJskOfWPnNlCRbLf0W834u8pAP/ZDZMdEkUAlIe4RTEh6BqoU9uetLH37vj6QUSu13CEbBK9YEPvFRzYVe/EzKVINQQz5vUI1FfHMSNLcNbaiRUuqkDmAZ7/Q393IhKIBukiNWCk8NEgQt/qEOm3aaELHmEILhpE2lhgUumpAbglx0JIP1CC4te6DXyy0LbBKHHu4t4ON/a4bZF/8XDD/tSMEI3+SHMmULEIGSKnYB/rnPIYBZ9s+IyTo611q5RZK0skuVjrgrI1Y7sO/TJwQB/y6IupWk1+m/y5VkRXc7TcLiZnJh9YpVkfCweSs+ahwN8necBtyAUqoZsuAkzRVFFW aQ5NexIk w0HCMjRB9fabhd9PpmDP0IMicus6h5YLHEqfUeHYbnX1HDL+ZD/vZ5kzrnFM8ESdDQP7spHiMhh6nCdYIUjyvcGe1MuL7U7uJv7vUq5ILOexyWC2UQl/E2pyQ2FidvbAIK55/Mt6r3zPav1cJdMh955qtzAybv8aJvJRBNvMCDu90AqSgQ1SkUT9c4U4C3xGOlL0AzBmDqE2eiZqX9cJobJdq988K126Y9r+STBFcW5EbW/t1rGTsLFvrMEx6z6A3e8gzDjZeXV83RLUCJMqJgZMs+99ok+YwkhLhenhUWTUqo5d7ryPaPRSS3m3cTXLDGCTwlgAfLyWu1r/IAmixLGVE+jV5s2P435N3Zuo+0HK3laU7vKy+AqcV/oAz8zLefCmBns7Iob99bGqjwVX0WjBZTpBApVqnkaxQH1w7dbGxJoepmYgDRS4kuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 15-07-24 08:48:58, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > For ext4, we only need to enable the FS_MGTIME flag. > > Reviewed-by: Josef Bacik > Signed-off-by: Jeff Layton You, I don't think anything else is needed. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index eb899628e121..95d4d7c0957a 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -7294,7 +7294,7 @@ static struct file_system_type ext4_fs_type = { > .init_fs_context = ext4_init_fs_context, > .parameters = ext4_param_specs, > .kill_sb = ext4_kill_sb, > - .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS_MGTIME, > }; > MODULE_ALIAS_FS("ext4"); > > > -- > 2.45.2 > -- Jan Kara SUSE Labs, CR