From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17EA1C3DA42 for ; Wed, 17 Jul 2024 11:24:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C67E6B00A0; Wed, 17 Jul 2024 07:24:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 776286B00A2; Wed, 17 Jul 2024 07:24:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 616D96B00A3; Wed, 17 Jul 2024 07:24:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 491016B00A0 for ; Wed, 17 Jul 2024 07:24:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C8110C1289 for ; Wed, 17 Jul 2024 11:24:15 +0000 (UTC) X-FDA: 82349010870.06.9A55C38 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 73F841C0020 for ; Wed, 17 Jul 2024 11:24:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xHHXrqW5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jeMSvCSD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xHHXrqW5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jeMSvCSD; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721215433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jPlXmgWWykiwYFaSI8TaQFNF/XILIXsfXxcyJiCt34A=; b=CYCx7BrUghuNHaUCPrQNIGKIK32AMSUAh3YbIoed4KyWXIlyPT9hN47NDXvML3Yt0eXfZU EOdVHOT4hBiLSEKYhaOR1NuVdZNKvTSfTIAkaw+86J7YV4WV0YKax6ZL1tj5+8VI/M7Du/ s32v6lgG1bu0hH3PFlVGm8Lyid81090= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xHHXrqW5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jeMSvCSD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xHHXrqW5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jeMSvCSD; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721215433; a=rsa-sha256; cv=none; b=Bv3cJN+CTsAsuByHZVhxAek8Tx85lT2y8vJX1KApwI2ps8g+cawO7Hl+l+fFd+5W2xQBXw dO1BvWkHsN4nnNr4sYT0k0q0p7RufDaBDyMB6UuI9NtXaG45hzMM/l1qoS7IJqQvLQXLoL 8Gd5hth5ijjzop9NYFozW7f3jr2FSRA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 78055219DB; Wed, 17 Jul 2024 11:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721215450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jPlXmgWWykiwYFaSI8TaQFNF/XILIXsfXxcyJiCt34A=; b=xHHXrqW5bIRudLPppzia+s31nSmZamC5ymFM+PaRsjxwdyx1VJBX5p8/pURD9S2QlaJ6Wz CidO86qEPm9wnBz6T598LscytA1ioT36iZ7eWgA1ngLtsXufWGVoV1SZsJkVzW/h91glSR fIR1Q7st9Z5i39BIFO6svmt8MVjbfdU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721215450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jPlXmgWWykiwYFaSI8TaQFNF/XILIXsfXxcyJiCt34A=; b=jeMSvCSDSmNWHb7lMjTSPMQUjiQ/RzIzyF/kChiOPKjH5cYlVIm2dh81c9x+9XkQcP4af3 Vd0hwQieyZK94sBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721215450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jPlXmgWWykiwYFaSI8TaQFNF/XILIXsfXxcyJiCt34A=; b=xHHXrqW5bIRudLPppzia+s31nSmZamC5ymFM+PaRsjxwdyx1VJBX5p8/pURD9S2QlaJ6Wz CidO86qEPm9wnBz6T598LscytA1ioT36iZ7eWgA1ngLtsXufWGVoV1SZsJkVzW/h91glSR fIR1Q7st9Z5i39BIFO6svmt8MVjbfdU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721215450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jPlXmgWWykiwYFaSI8TaQFNF/XILIXsfXxcyJiCt34A=; b=jeMSvCSDSmNWHb7lMjTSPMQUjiQ/RzIzyF/kChiOPKjH5cYlVIm2dh81c9x+9XkQcP4af3 Vd0hwQieyZK94sBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 58BF6136E5; Wed, 17 Jul 2024 11:24:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IU5QFdqpl2bjSQAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 11:24:10 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id DB671A0987; Wed, 17 Jul 2024 13:24:09 +0200 (CEST) Date: Wed, 17 Jul 2024 13:24:09 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 4/9] fs: have setattr_copy handle multigrain timestamps appropriately Message-ID: <20240717112409.i7qdiy35yxdyznng@quack3> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-4-48e5d34bd2ba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715-mgtime-v6-4-48e5d34bd2ba@kernel.org> X-Rspamd-Action: no action X-Spamd-Bar: / X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 73F841C0020 X-Stat-Signature: jxogdf144nd8a6firkwwqrhg9gaeihzq X-HE-Tag: 1721215452-191020 X-HE-Meta: U2FsdGVkX19MDxjKa9817MUgFz6O8rdiwHJkiuVHHxTfs3+LMhqD7T/7Sz4TPHFeZtnT+yQ7wU2h3OZoep+RR10UwP//9ULJov+cJc6rHKQMC2NSqMhrXCtNcCUTBbnDDbx+H06knGtWfsVxBmneE+98P1kj3NJ9cqcZ8ons+/7AAa1rT4bHf80BAA3p+JMWjfO4QigMXcS3tRfydRmU1bfPxxCn5eKk4KIiBuDUKHrRlA0JhBGvAeYFPl5fgHun2aeI1qKFD/UAOf5yiGpU8RN0ARaY1z5l3FfEqQDiL5sSaQWjwdr/JSLjOUtmZWC/UNCqtdKVlBLTqNW9MUQBuFQ7Y3mXoKfbXzQE4Yx90JxG2I9FGAdFYgiHzgETX4SH6jBABp8EeuJHyMSkpjMB0ZVFAT83RstHDENIa2x23zFZXnfNqrgxTy0RSUEkVjyHEIZ61XwEhjgF3vmHzNH80vsAGCtF+F8Th9UBRZXk9Pc8X61Mlz6RfAG0Qe9eU/66MSUdHsixRaMSCKW3LjM2wagHQ1pCBdnvTFWVQgKmuijCE4MLzxO/WeKaRg7t/Khhkst3381zlZmiR2VhfgG2x2jUPPXG5FtdG4FVE83DQ8qbLeuyRm9yf27oE5rBvJ/g6t4JQ9tz2h1x3D3+zZn2RvGETzL3TKFrwtnHt4cNaXOnGF3VD1dNO29VZcM8oim6T+O6Kvu2tcSbwbbPsNCqMNIUNFQNxIrLGf9z7fGOFiI41ewVh0ov3Q922Bd6hV3CzJiXNFmPMR4PTxhFf0kUrAgXigTw6R2HYVeRSy/qpuhHz0nDMEjN0TOhbYjIK0fPpW4+rVQqJZzS+JPIxpVm2AsiRT+yBsYnJSs0xxFVqsy0zkZZVauXS/mOTHlMo8/m4YN5RP0dG+Gi5dcZMCEEQT6mOQpJI3M5dm9/0HoJyzQX8lpcfUjrZrqgMIU7/pAw1/CqhWBs5iY3vQgqVoF u8JyAEJm 9UHJDZajUGFMPVNyDsYGO21ay4vVp3JZbOCvjJhXFHhT18fD6fbm+7vss4AynOmiO2yRhZwxR9QgRMwQpFYndOfWBv8KW5BmppIugAVBcd/tWan8390XbQZU+Feuns+G3HzK7qOSzhBz8jolv9oDq2GYdAkDkVMMKuSITz2ag9yAw7CKNpRYSbJM5ld5A92WhFsnecbC3TNE8KhhncmSuIlFzXFe3np98/kjTdkcvXJWNwKsQo8rIi8WL7+hZgwMG/hfUGvXtE2BONgA4nnAENmF/amkr6bcrjHtICYi/L9rdtPt37bTogsEbQ03DEbCuKeWYvzIU4eJ+LGLl6A800a1+yP1pz0shdraueWIXY+KGuMF+YoAvQZ8edsi8t1cA7jZlDkLGJPV79n9EpppeDtK7aEq8dvf/mWOADIdjWa7u63l1/DQ8UmqXCrYC3qSz20g3/rKt8G2JcjGahW5aNmO32koIImYj0Et+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 15-07-24 08:48:55, Jeff Layton wrote: > The setattr codepath is still using coarse-grained timestamps, even on > multigrain filesystems. To fix this, we need to fetch the timestamp for > ctime updates later, at the point where the assignment occurs in > setattr_copy. > > On a multigrain inode, ignore the ia_ctime in the attrs, and always > update the ctime to the current clock value. Update the atime and mtime > with the same value (if needed) unless they are being set to other > specific values, a'la utimes(). > > Note that we don't want to do this universally however, as some > filesystems (e.g. most networked fs) want to do an explicit update > elsewhere before updating the local inode. > > Reviewed-by: Darrick J. Wong > Reviewed-by: Josef Bacik > Signed-off-by: Jeff Layton Looks good to me so feel free to add: Reviewed-by: Jan Kara What is a bit bothering me is that it's now confusing that ATTR_MTIME_SET / ATTR_ATIME_SET is handled in different place for mgtime and normal inodes and I'm concerned this will bite us in the future. But not everybody is using setattr_copy() and unifying the handling of timestamps seems like quite some work... Honza -- Jan Kara SUSE Labs, CR