From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF04C3DA59 for ; Tue, 16 Jul 2024 17:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7425B6B008C; Tue, 16 Jul 2024 13:40:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2606B0092; Tue, 16 Jul 2024 13:40:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E0946B0093; Tue, 16 Jul 2024 13:40:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 40FE86B008C for ; Tue, 16 Jul 2024 13:40:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B8CF51205CB for ; Tue, 16 Jul 2024 17:40:24 +0000 (UTC) X-FDA: 82346329968.12.88DE3F0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 94E5C4002A for ; Tue, 16 Jul 2024 17:40:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jnG4iEP4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721151594; a=rsa-sha256; cv=none; b=XTeUKdd3lvHeZQzq+D3h2pr3NVygr2J0fEtzMpfsfzUuBf26Sw+G/BntGaaKxoFZNCtMh7 Xf2mjdwRxW2Jsj2KkytpU02R6TSg4BCIQ8PQVt7+vmXyns/JMms1XpqBXz3ZMtWGeeuJoA lfGdyn3uFyBkT4ixLi4SVtBCb62tV2s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jnG4iEP4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721151594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SsSjF2xpuUpMLnYWky/h2LODrWyh7Q/TVMkRjN/n77M=; b=IP/4WaHZRVBHLChayIHv0BQcAwDlM7utKnJyydO1Kec5JpQTEPYIa2XB4OcDFnSUyB6km8 Ameqj4F2PP0e3Hrjs/9v/yXsCFfNPZzJS/6Nnur7fBGVc8kSDfrOPuxGBMWXAHhszSw2L4 96RrIim8iznpGBPLOa8rfpxIi5FlCcU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D0CD2CE138A; Tue, 16 Jul 2024 17:40:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E687FC116B1; Tue, 16 Jul 2024 17:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721151617; bh=/DWRRzlwPclikws22W4iLFI9F32izmSn+UFrDAbSZ5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jnG4iEP4JUqetBoPTMZyAsGFAaYNtgCfXuqwuKe9v0neIVIxyJ2dkW8aaCQYFB+VL t3HPOBIiGhUHUdi9EQ9UfrU5dCgDUOyOPb3fpVpqHpczhhxFKsFsHU0m4FDKJg0ljb Vnp8jEPky8TJiCbnWtFVfF2Eafx17VmCr3LTR4UerjscPcONdbddRQqJ4tM4d2pinM H9CJUTcyz+3Z/mF7X++iFZtZzRlAaBcTa+2BYMbuJu0vgrEGGJxoorHzHqVF9F7S75 cOdYE1z6WYYy1EYclanvs8RerANxPhlG02Dj0xuNIgIVL59OAg1A3I7eG+HxkWm/aY v04NdoJCtHwNA== Date: Tue, 16 Jul 2024 10:40:16 -0700 From: "Darrick J. Wong" To: Matthew Wilcox Cc: "Pankaj Raghav (Samsung)" , david@fromorbit.com, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, ryan.roberts@arm.com, hch@lst.de, Zi Yan Subject: Re: [PATCH v10 10/10] xfs: enable block size larger than page size support Message-ID: <20240716174016.GZ1998502@frogsfrogsfrogs> References: <20240715094457.452836-1-kernel@pankajraghav.com> <20240715094457.452836-11-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 94E5C4002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: e9rioecsjemzwzn6nkkif1tet8ubu496 X-HE-Tag: 1721151622-800361 X-HE-Meta: U2FsdGVkX1+NvOyoGj0+cAH+D7hmpN/F6F5MygYYIAJwzkf81F1rhPhX6g/GCd13GpM/Ou1a21uWmu2EjAm1bg3ZM8tGmHi/w37niN2RgizHHMtQEdS/Yyw6mQZLbdayCsk7MBrnIV4DPFe9UOZwmukaFN+DA26o0wWUEg55Aim1r4wu0LCRJ/u/I8Q2HvV2xIzh1J0MivF2yBLtRuZlmRf+Z+YvZcBfjaIreD2ARZl7iUVNVb3JPlgJtpXkkuuxO5mTKwEZwHn+9qSTf1ct4givxVgCD0FlL23o8OhAFFxFK5BvncEaAP0wDiYt3WtaCR2zl1H2ElKxZ1ePwcK0gXFMgO3zlJMGVFsneyWa/ZIyeQe0/PRhSKR0/UyT5/RdehfNvfxYYfqveQBwwXYhVpxfNkR2n/T7fVOlICS8fBwO/0KrKm49zHJsu2St2mi+UTnlH1OqZi7uJl3XShKOGVe4v+XLf15snIA7NQfr/CVmdRUOd/8oQXkLN52lsrtDgPhnNCrO1ughczRI7nJY2dFnJ8nkvrM34txvqWoiYLK/+6ci1DuoFmolOgIhqMoz12i6fleBAZIA7e/PoNxt/THD/rzE88marvLhPWsxvF4g5EwWS1YKZdBeQBxIMDvig5Kl86DHJ+R4AfeTlpobG+LUpmYbaWU7qHXcEE79hOP6V2ZklEqPvqiJS+BXjO37R5Igi+YRQkpaA6Dk3o2EHPrsSyO9fPFjCWaVLixSYeOLOsTkVuuLT2I0mIGGBKC3hVjXGh3nu+Na8HerszS6hQLAyqlBUrgGxUAWlMX/+yEgYXhawcUCjzm/PzTlref8oqdRLnUseeJsceLNsi6GVn1/HNsMliMijwT8up+ZYA4g8KuUHIGkDt5/PoScCe285TUO+/mK7RomBVOTw0gU5V50kSHJfIBya/u8GQTcXIGdbiOvQMcDArSLjtXnWcnrxZfz07fuymbunkdCnRs LtwaRC/s Tmhm+UNNUQcE3s5cGweDNNL5zq4qMaMUqMOr8Ke2sv/9WB6aO2FaCDrKuQCdmOtkZ6l0HW0N3i0iMEHqpWGiNgc2qIQwHiis/7k2PJNzgrUg7pHtr77nBHXBY+F+XaDxEuIPDJYk0orYtDbuKeudKljwVtbr7s/NfqFMYPUL2AVL35Rwqi6I1luHO3fsVYR/kDhjnv8FepmrPiC5K2/mTQaGdHqH3NAJQVWHB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 16, 2024 at 04:29:05PM +0100, Matthew Wilcox wrote: > On Mon, Jul 15, 2024 at 11:44:57AM +0200, Pankaj Raghav (Samsung) wrote: > > +++ b/fs/xfs/xfs_super.c > > @@ -1638,16 +1638,30 @@ xfs_fs_fill_super( > > goto out_free_sb; > > } > > > > - /* > > - * Until this is fixed only page-sized or smaller data blocks work. > > - */ > > if (mp->m_sb.sb_blocksize > PAGE_SIZE) { > > - xfs_warn(mp, > > - "File system with blocksize %d bytes. " > > - "Only pagesize (%ld) or less will currently work.", > > + size_t max_folio_size = mapping_max_folio_size_supported(); > > + > > + if (!xfs_has_crc(mp)) { > > + xfs_warn(mp, > > +"V4 Filesystem with blocksize %d bytes. Only pagesize (%ld) or less is supported.", > > mp->m_sb.sb_blocksize, PAGE_SIZE); > > - error = -ENOSYS; > > - goto out_free_sb; > > + error = -ENOSYS; > > + goto out_free_sb; > > + } > > + > > + if (mp->m_sb.sb_blocksize > max_folio_size) { > > + xfs_warn(mp, > > +"block size (%u bytes) not supported; maximum folio size supported in "\ > > +"the page cache is (%ld bytes). Check MAX_PAGECACHE_ORDER (%d)", > > + mp->m_sb.sb_blocksize, max_folio_size, > > + MAX_PAGECACHE_ORDER); > > Again, too much message. Way too much. We shouldn't even allow block > devices to be created if their block size is larger than the max supported > by the page cache. Filesystem blocksize != block device blocksize. xfs still needs this check because one can xfs_copy a 64k-fsblock xfs to a hdd with 512b sectors and try to mount that on x86. Assuming there /is/ some fs that allows 1G blocksize, you'd then really want a mount check that would prevent you from mounting that. --D