From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B11C3DA4B for ; Mon, 15 Jul 2024 18:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6E886B0093; Mon, 15 Jul 2024 14:47:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1E636B0095; Mon, 15 Jul 2024 14:47:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E7206B0096; Mon, 15 Jul 2024 14:47:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 70E666B0093 for ; Mon, 15 Jul 2024 14:47:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 30BFFC01B8 for ; Mon, 15 Jul 2024 18:47:47 +0000 (UTC) X-FDA: 82342870974.07.AD200BD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 7E0F940016 for ; Mon, 15 Jul 2024 18:47:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MWHmYEFh; spf=pass (imf12.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721069227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Otf1zSvqXW9wsD9FovMHeHOtoilr6Y7LoAFx9Yn/ldU=; b=P0zppjpLp1br7wBesmdpWamv5VXgKcW2oz/pxAdy59lw+KTYBW2QGwoqPtcIvf3uTxKmgW 3lp4A9L3kzwY8TMxvScdAO+ygrGEP+U4SjUVPtYDKvW767QwAoaIavVs8vnQoBOVtYg8VX F7pwMSkX/vLVwoahphWYWavRIM1RqaU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721069227; a=rsa-sha256; cv=none; b=oJ6sCKSJO+tCVDfXJthT2pGFD6FO238UwIsgPCE7KoQpfYcsSeGUqSY8+HCWqy4DYqqBp/ YfIukK17CCf88cMCjkBrC/0+/0ckOWVdvGf/gvk4Zl+VBjoIWlQZKEM/EybtuKEc1+Z6PG 7h5xnQc1eSJzt/vvrUjUHHjVGXjPNHw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MWHmYEFh; spf=pass (imf12.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 62AD1611FD; Mon, 15 Jul 2024 18:47:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDC25C32782; Mon, 15 Jul 2024 18:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721069264; bh=gHBpMyl77vyIqwD/HbHQNCcjFMsWAzPACHCRguL7WCc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MWHmYEFhGc1J9fZ7fmffBU84nHYBBkr4R4bpUVUzsH5Kd8Uez7QLFOzCUWPLxWayA II+N5FcGFiEAjW8sbYOr4aWAHAF9fdO7+uiX7kyETqs/nEFxeGclcDudiFXKb4D1YF WvkDApHTWIotWb4dB6JxCOdCS7RHgjkFbVG2WnCLBOnSNiWkM+/ZpRALMQX0uWNzwj 9HIR4Z50P15P8bfIHSwGp/zfjffwQcFTfOvlYFhmZ6Qla6BeiwOmivLGKWiBYsASQr BRqjHzO7lbSrE9Kr/W3OcmSjPjbxv9i+ODjwXzApnAcj1l2S1jX4WPjXmYL6LE0QEK WIuXhYFM/oKkQ== Date: Mon, 15 Jul 2024 11:47:43 -0700 From: "Darrick J. Wong" To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 6/9] xfs: switch to multigrain timestamps Message-ID: <20240715184743.GF103014@frogsfrogsfrogs> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-6-48e5d34bd2ba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715-mgtime-v6-6-48e5d34bd2ba@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7E0F940016 X-Stat-Signature: pbzmqmxdtmw94ok867u9x7tb4qhmaira X-HE-Tag: 1721069265-304351 X-HE-Meta: U2FsdGVkX18BG/c7rjy/wv2BDXOnntN1xAYOoyu3cAy81/TDJxpK75SRWvLD0cHph9eiBSeLa7iJd8ZkGSn4nCwRPgrq4XpitoxqQ/CNbMp6gWmWddzd5HTeayfcHsSznzQ/ZsMACa7beq4CHa+UXzt8WuIXoi1Wy5MjTipmcG5DviSS2Vf5DdnPa98x69Q405DOB95g5DRE9xZkAKsD50zHGpLakcihNhX77BnM//2VlpgrYDSMzexQEKd9UFipg/lKSaHLsyne5EkOLJ/MINQWb9zvySOnrQ11gkd36WIkg7PNV9glLdnGMNjDbiOjWIplPB6voqTWkYzoGqAQ1Ri25fc8qUrHC04KMndAWVnd8HFIZfr+TrvkJ5jjrSwJDVnBhp91H4xgxiozgMtHvWxdQXv8Z1StH8bRPaZPXbLHBLozKeIEnAf7SwC+ZwY7SqiUFmfqhJhfhDljDfyK4mvejBoWOYraD5EPuBur2oI0rQJI2J2IaBA97E3tPTciDugfr8en4ToFxJ1iFG/ZM6sCyK63Ai54OJLY2jSd4947rEZXRXqh1Wwmul4K8vWovcMqhw7AjKhxBnGDS5xMoX6ZOkp/xh5QBnegBAGaEhAACF+pbLvr1Y4+NPeYaTemccWkHy3tC70X/4tKHctmNT+UqDgNiBS71Otg+6VG9RIoYsn3CblKvqFEp9SYCRuUHNBlmfCL6cIRSH5Fyuqv0KmxZUb1cygbprk2sL+DeGTMHvZy+Ch+kVvQkg7BDWt/nqSXIjcWdz5W+1swwVIIF/eaP3StBvn0kHW1V+rV+zN+bDd4EahqcmsYmOe16U+bHPCmD8WaVe+SI+lHVAug2TXZ9sYQYsPAZyP7g7FCmkGGvunbMmNUeuPP8sx9VHJt647nfEFAhs3GJep8j2bBao0YfJkR3q6WOoxZ4DnJaa/Rmb4kJcYWnhHHPB/84gKkEe33Ou09LmTGhvv1jZh yY7H4B07 v9wI0+sNEpGBDJf4Gl1u9nve9erYrd0TjP4nvbHL77UPRSgeKekFN6AMpG38W/CJDTQoFMCATjbr7dAOXlcXv370XaiUfyyGQ5DAGxWdR6kP3BzxNDV+8xWmjLyfE/Z+S7ZO3Ie2/vK05+OUfXJOEraG7jWE4iE7t2XCJcqthXjFPqRTS+qtlvB96WnuMCo6tcrvo3bB1cZFZt50P/Iz3GckgHjaX/IzjhENgQMZP2Pa2qQqbFqoVtBC+JnbTrBig89YJ22DWzIxjl0BmKekFAjmUSK7wIUZDJgRVvBPK9VKgmzWnHR2SUIFdQgPeGREIvuBVQ/bdmnGsrTQeNtpSsYuVFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 15, 2024 at 08:48:57AM -0400, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Also, anytime the mtime changes, the ctime must also change, and those > are now the only two options for xfs_trans_ichgtime. Have that function > unconditionally bump the ctime, and ASSERT that XFS_ICHGTIME_CHG is > always set. > > Finally, stop setting STATX_CHANGE_COOKIE in getattr, since the ctime > should give us better semantics now. > > Reviewed-by: Josef Bacik > Signed-off-by: Jeff Layton Looks good, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_trans_inode.c | 6 +++--- > fs/xfs/xfs_iops.c | 10 +++------- > fs/xfs/xfs_super.c | 2 +- > 3 files changed, 7 insertions(+), 11 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c > index 69fc5b981352..1f3639bbf5f0 100644 > --- a/fs/xfs/libxfs/xfs_trans_inode.c > +++ b/fs/xfs/libxfs/xfs_trans_inode.c > @@ -62,12 +62,12 @@ xfs_trans_ichgtime( > ASSERT(tp); > xfs_assert_ilocked(ip, XFS_ILOCK_EXCL); > > - tv = current_time(inode); > + /* If the mtime changes, then ctime must also change */ > + ASSERT(flags & XFS_ICHGTIME_CHG); > > + tv = inode_set_ctime_current(inode); > if (flags & XFS_ICHGTIME_MOD) > inode_set_mtime_to_ts(inode, tv); > - if (flags & XFS_ICHGTIME_CHG) > - inode_set_ctime_to_ts(inode, tv); > if (flags & XFS_ICHGTIME_CREATE) > ip->i_crtime = tv; > } > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index a00dcbc77e12..d25872f818fa 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -592,8 +592,9 @@ xfs_vn_getattr( > stat->gid = vfsgid_into_kgid(vfsgid); > stat->ino = ip->i_ino; > stat->atime = inode_get_atime(inode); > - stat->mtime = inode_get_mtime(inode); > - stat->ctime = inode_get_ctime(inode); > + > + fill_mg_cmtime(stat, request_mask, inode); > + > stat->blocks = XFS_FSB_TO_BB(mp, ip->i_nblocks + ip->i_delayed_blks); > > if (xfs_has_v3inodes(mp)) { > @@ -603,11 +604,6 @@ xfs_vn_getattr( > } > } > > - if ((request_mask & STATX_CHANGE_COOKIE) && IS_I_VERSION(inode)) { > - stat->change_cookie = inode_query_iversion(inode); > - stat->result_mask |= STATX_CHANGE_COOKIE; > - } > - > /* > * Note: If you add another clause to set an attribute flag, please > * update attributes_mask below. > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 27e9f749c4c7..210481b03fdb 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -2052,7 +2052,7 @@ static struct file_system_type xfs_fs_type = { > .init_fs_context = xfs_init_fs_context, > .parameters = xfs_fs_parameters, > .kill_sb = xfs_kill_sb, > - .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS_MGTIME, > }; > MODULE_ALIAS_FS("xfs"); > > > -- > 2.45.2 > >