From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023ECC3DA59 for ; Mon, 15 Jul 2024 18:29:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D0A56B0085; Mon, 15 Jul 2024 14:29:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 380ED6B0088; Mon, 15 Jul 2024 14:29:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 248AB6B0089; Mon, 15 Jul 2024 14:29:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 06E6C6B0085 for ; Mon, 15 Jul 2024 14:29:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A388940128 for ; Mon, 15 Jul 2024 18:29:16 +0000 (UTC) X-FDA: 82342824312.08.AF08A90 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 26DB78002A for ; Mon, 15 Jul 2024 18:29:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WW8iEsT2; spf=pass (imf30.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721068135; a=rsa-sha256; cv=none; b=WqZ/zr7hnNnytAa5BCLctJq/Ws4bFdpBkN0bTjwvHur5NdQ7wwNcw31u51CmdC/g3iYhEa OcR7Fq0wcfbTcoiaVHFqKZCdRU1f13dn8DDe1TqKoJ8cFa2r2hQr120fsAuifRQmAa+Xiv WwfjfliAqa4a8KhfdDVLVvsEZ5obnug= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WW8iEsT2; spf=pass (imf30.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721068135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lzmt/e1bFxpUX97vhXwLpSYJOD1N5Gx/gzRvTF5v2ls=; b=yAPub63BBYjfjMwt1Vl8cJQkTZQv+ZWIuN2CHdcaKo0iTNa/u8umtMPgIGUt8BZ4uUjIA0 XT/tzxKriVaP/Z+d1fe3lr61Y9U/q5mo7xy/LPWB/gKJoR6bpTo0Rg/wbmTHsy3SRSXIUj Zh0Ekf6RNuQspaQjY+JoKvPWhnrv/kU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A053ECE1130; Mon, 15 Jul 2024 18:29:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6A1BC32782; Mon, 15 Jul 2024 18:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721068148; bh=fTKTqXvODxiH14W2JlEV67Ic+f/odwUbY+RedfTGRAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WW8iEsT27XWeAdUScm3j2X4Bh2cAg1X9i4WUdmMLYvtm9ybgPYTx6KiTuSgH7N6+N uRRGguxn96doXRGES6t/+aL41zanbegNtxTe94PzaUzvk+MsN282U/5p/QrJdVZCud e98mU4p6E/jmED8DQEMCu9sCfzUTGJ9eqdeBG8JHrq8y+WNOFEhOafoksGPn57SnkG GQkGHC+LBsDIQt6i3/aaZrSBWGcfQKufk+E0zF75Zh8CGEBuW2p8EMiguxrSEIjM4n zRzyhz/pyivD45aZtoqITSSGNIT32RoCiEoODnkQhVT4//xeBMEGcaLlcXpbe9IujP XljTMyyAvBiVg== Date: Mon, 15 Jul 2024 11:29:08 -0700 From: "Darrick J. Wong" To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 2/9] fs: tracepoints around multigrain timestamp events Message-ID: <20240715182908.GC103014@frogsfrogsfrogs> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-2-48e5d34bd2ba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715-mgtime-v6-2-48e5d34bd2ba@kernel.org> X-Stat-Signature: pqz58yzuxhxmwzusqwidnof41jnj7dt5 X-Rspamd-Queue-Id: 26DB78002A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721068153-764947 X-HE-Meta: U2FsdGVkX1/JJOUrT7gdNKSz6iaKxRYceXMfG2tYUsMMrXZHvDmDQ/yA8OGc8NLXjXSWheQxALGU+bv8iOJFGD+EF508gWNC6PTMWgS1C1bfVAh7/+eLtXwKWOS+X/quS/xLoggdgF6n5T08RVlMBKJbYsrUZIT6Xt17wgrFDPHvbmddCwjg3wYIYujhSVLiK2zvqNhov4FgaH76CLYzO9NcyKERMg7QG1vxMBFGsxuZVBsgpTtHGuVQyvupBSJipRLIXaHeLw6niysi+GlczLz65LQ4ELkGT3JgNjWRSyagV2B/fRg9KkPmeWzUYkV4vKdkn1xBA+4WiQUKcK6Kz6ItnNplAUNUzPeQJ5UvF1I8iZhhTg+zCVBLBT7rEBUgWpsKTa3R7rRyAMGOE7VOP9wILxVqTpQxRt5283yNuR8u4q8eONWIUk1XdI7DpYe0/9IKiJ+bCGHFBJxcPpH4wTiMwoUQGT1WTy6U8E+7nc4wOhlrt2vrO3+vqDxvkmtievcmSWTox/ViAiY1jDqDb0GvPJCSeaIJtTkjgPk02xGPJvd0z14UoONPoIQwENLPIbbhTPwPKlA4jPn5AAm72dPJUGU9FTX/uS8ftpe4WztEwYLIWrjKzNX8hmy+Fjlir1QCNM076KBcgBXyx2uuOsfkQ+OOGymEGN5FYXHi3qcAssvblp3UwSOHPN8OIk/lFZzmmjmtTOu0nCaVjp48bCMM3mg4DRB6M3YFQaBmOM7C0fSqP0HlpIEIfvmsUj8Ctw1/vnKH5hINASZnzMbKdcuLchswML627ofiD8u9D8m+gmiQ1ZjnxZOX1tZLxgiRujC+K5JS5ygqrPvcWe/vfiZ0+qVbHxusZ45iKbdFncs66dXhyJIkmfArZIPLK7UtHxArDANdqDEU87DxJvv5BMbk2PVzIdNQ00A7sTgOhinPTQly5SiXUOrvPjPRjDAs/D6rl1MoejFU/kdersA 3IPkzLkh 8o3OPKZSwx6f/4ykXVKNGX74bJ8K7Xkdnozkowx+1poB8lyTERQ6Tf9mRDHKKxWWg69CM250wZBtAgJz/4ILiOZcAuc6efMAzOu8gSYhUpqWTriqYH6PvG57FlZGigV8SnkIQitfMZ+KjDYe7d0GhAvDhviVtUhOKEFsj8L9pXj1XQwKCIvfoJZrBKrgKebJpHx7KdBeY5yN9j2QbljOqeD9IcbYS3+xctQ5KZR1GyCVGXDzne8N5Rbg32fnHmdBLBkmac/xQnpWiQXs1Lr4VKN6NyBU0H7ZMHvv8Pm45hW0GrF9ADaVOFSs3BH0j71VCcuNmirMybR2o6hX76FAlFW62tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 15, 2024 at 08:48:53AM -0400, Jeff Layton wrote: > Add some tracepoints around various multigrain timestamp events. > > Reviewed-by: Josef Bacik > Signed-off-by: Jeff Layton Woot! Reviewed-by: Darrick J. Wong --D > --- > fs/inode.c | 9 ++- > fs/stat.c | 3 + > include/trace/events/timestamp.h | 124 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 135 insertions(+), 1 deletion(-) > > diff --git a/fs/inode.c b/fs/inode.c > index 417acbeabef3..869994285e87 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -22,6 +22,9 @@ > #include > #include > #include > +#define CREATE_TRACE_POINTS > +#include > + > #include "internal.h" > > /* > @@ -2569,6 +2572,7 @@ EXPORT_SYMBOL(inode_nohighmem); > > struct timespec64 inode_set_ctime_to_ts(struct inode *inode, struct timespec64 ts) > { > + trace_inode_set_ctime_to_ts(inode, &ts); > set_normalized_timespec64(&ts, ts.tv_sec, ts.tv_nsec); > inode->i_ctime_sec = ts.tv_sec; > inode->i_ctime_nsec = ts.tv_nsec; > @@ -2668,13 +2672,16 @@ struct timespec64 inode_set_ctime_current(struct inode *inode) > cur = cns; > > /* No need to cmpxchg if it's exactly the same */ > - if (cns == now_ts.tv_nsec && inode->i_ctime_sec == now_ts.tv_sec) > + if (cns == now_ts.tv_nsec && inode->i_ctime_sec == now_ts.tv_sec) { > + trace_ctime_xchg_skip(inode, &now_ts); > goto out; > + } > retry: > /* Try to swap the nsec value into place. */ > if (try_cmpxchg(&inode->i_ctime_nsec, &cur, now_ts.tv_nsec)) { > /* If swap occurred, then we're (mostly) done */ > inode->i_ctime_sec = now_ts.tv_sec; > + trace_ctime_ns_xchg(inode, cns, now_ts.tv_nsec, cur); > } else { > /* > * Was the change due to someone marking the old ctime QUERIED? > diff --git a/fs/stat.c b/fs/stat.c > index df7fdd3afed9..552dfd67688b 100644 > --- a/fs/stat.c > +++ b/fs/stat.c > @@ -23,6 +23,8 @@ > #include > #include > > +#include > + > #include "internal.h" > #include "mount.h" > > @@ -49,6 +51,7 @@ void fill_mg_cmtime(struct kstat *stat, u32 request_mask, struct inode *inode) > stat->mtime = inode_get_mtime(inode); > stat->ctime.tv_sec = inode->i_ctime_sec; > stat->ctime.tv_nsec = ((u32)atomic_fetch_or(I_CTIME_QUERIED, pcn)) & ~I_CTIME_QUERIED; > + trace_fill_mg_cmtime(inode, &stat->ctime, &stat->mtime); > } > EXPORT_SYMBOL(fill_mg_cmtime); > > diff --git a/include/trace/events/timestamp.h b/include/trace/events/timestamp.h > new file mode 100644 > index 000000000000..c9e5ec930054 > --- /dev/null > +++ b/include/trace/events/timestamp.h > @@ -0,0 +1,124 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM timestamp > + > +#if !defined(_TRACE_TIMESTAMP_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_TIMESTAMP_H > + > +#include > +#include > + > +#define CTIME_QUERIED_FLAGS \ > + { I_CTIME_QUERIED, "Q" } > + > +DECLARE_EVENT_CLASS(ctime, > + TP_PROTO(struct inode *inode, > + struct timespec64 *ctime), > + > + TP_ARGS(inode, ctime), > + > + TP_STRUCT__entry( > + __field(dev_t, dev) > + __field(ino_t, ino) > + __field(time64_t, ctime_s) > + __field(u32, ctime_ns) > + __field(u32, gen) > + ), > + > + TP_fast_assign( > + __entry->dev = inode->i_sb->s_dev; > + __entry->ino = inode->i_ino; > + __entry->gen = inode->i_generation; > + __entry->ctime_s = ctime->tv_sec; > + __entry->ctime_ns = ctime->tv_nsec; > + ), > + > + TP_printk("ino=%d:%d:%ld:%u ctime=%lld.%u", > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, __entry->gen, > + __entry->ctime_s, __entry->ctime_ns > + ) > +); > + > +DEFINE_EVENT(ctime, inode_set_ctime_to_ts, > + TP_PROTO(struct inode *inode, > + struct timespec64 *ctime), > + TP_ARGS(inode, ctime)); > + > +DEFINE_EVENT(ctime, ctime_xchg_skip, > + TP_PROTO(struct inode *inode, > + struct timespec64 *ctime), > + TP_ARGS(inode, ctime)); > + > +TRACE_EVENT(ctime_ns_xchg, > + TP_PROTO(struct inode *inode, > + u32 old, > + u32 new, > + u32 cur), > + > + TP_ARGS(inode, old, new, cur), > + > + TP_STRUCT__entry( > + __field(dev_t, dev) > + __field(ino_t, ino) > + __field(u32, gen) > + __field(u32, old) > + __field(u32, new) > + __field(u32, cur) > + ), > + > + TP_fast_assign( > + __entry->dev = inode->i_sb->s_dev; > + __entry->ino = inode->i_ino; > + __entry->gen = inode->i_generation; > + __entry->old = old; > + __entry->new = new; > + __entry->cur = cur; > + ), > + > + TP_printk("ino=%d:%d:%ld:%u old=%u:%s new=%u cur=%u:%s", > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, __entry->gen, > + __entry->old & ~I_CTIME_QUERIED, > + __print_flags(__entry->old & I_CTIME_QUERIED, "|", CTIME_QUERIED_FLAGS), > + __entry->new, > + __entry->cur & ~I_CTIME_QUERIED, > + __print_flags(__entry->cur & I_CTIME_QUERIED, "|", CTIME_QUERIED_FLAGS) > + ) > +); > + > +TRACE_EVENT(fill_mg_cmtime, > + TP_PROTO(struct inode *inode, > + struct timespec64 *ctime, > + struct timespec64 *mtime), > + > + TP_ARGS(inode, ctime, mtime), > + > + TP_STRUCT__entry( > + __field(dev_t, dev) > + __field(ino_t, ino) > + __field(time64_t, ctime_s) > + __field(time64_t, mtime_s) > + __field(u32, ctime_ns) > + __field(u32, mtime_ns) > + __field(u32, gen) > + ), > + > + TP_fast_assign( > + __entry->dev = inode->i_sb->s_dev; > + __entry->ino = inode->i_ino; > + __entry->gen = inode->i_generation; > + __entry->ctime_s = ctime->tv_sec; > + __entry->mtime_s = mtime->tv_sec; > + __entry->ctime_ns = ctime->tv_nsec; > + __entry->mtime_ns = mtime->tv_nsec; > + ), > + > + TP_printk("ino=%d:%d:%ld:%u ctime=%lld.%u mtime=%lld.%u", > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, __entry->gen, > + __entry->ctime_s, __entry->ctime_ns, > + __entry->mtime_s, __entry->mtime_ns > + ) > +); > +#endif /* _TRACE_TIMESTAMP_H */ > + > +/* This part must be outside protection */ > +#include > > -- > 2.45.2 > >