From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E474C3DA59 for ; Mon, 15 Jul 2024 20:33:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0357C6B009D; Mon, 15 Jul 2024 16:33:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F274B6B00A2; Mon, 15 Jul 2024 16:33:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEF356B00B3; Mon, 15 Jul 2024 16:33:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B772D6B009D for ; Mon, 15 Jul 2024 16:33:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5C51C1A020C for ; Mon, 15 Jul 2024 20:33:42 +0000 (UTC) X-FDA: 82343137884.27.91FC23F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 694B020026 for ; Mon, 15 Jul 2024 20:33:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0F5WUGP4; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721075578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ICcpVjxBR5TQHpR8D24tX8Z1cY9/zH3Nyp2GCrQYqQ=; b=5sVdtLfIqYC35b4KsuWL6qOLVBQBkX4O2vBBzk42QhsxMrrhkuVDDcEsKx1ohHh/R37vif 733JmpgBc5CUy/MeUl0nwMbcJN4kFhzYwpBekUtqRIkWtv7GLmM4r+k4oQXPNqWfwYi8FH kcHNM+eIP4gegIOOSObUIImVPo2f3kI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721075578; a=rsa-sha256; cv=none; b=Qp9j3F3gZGgh00rosAaYC5QZYeAhBcUbaXfSTUNUziXsNYmz8zpuj3HK61++Mbo2HXCT8G wxO3MoSxH1mq1hXbI5tdI5zhzjb2VRM6oFumL7oj1RRGgCF62o2wvv2A3EOV/wMRLcOGcd xVX7V5Tf5jPtoL7F227olxg4peew8sM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0F5WUGP4; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 334E760BF0; Mon, 15 Jul 2024 20:33:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CBA1C32782; Mon, 15 Jul 2024 20:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1721075618; bh=onQcMoz8GPXOo1jUzaLuZp8M4wP24ok7J1K5zp1cIP8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0F5WUGP4Ij7cGXKtN+/fBZEoJUt0Mjcnmfcj87/GICSMuLtKjHR5XMObazRy88V5K TxYl7eSqtIra9eoJsRs5NS3B2i5Enng44alrOkW3irSif7ZTx3V6kkgZSSzuKPjd7V Fs7wXboWdhOPLfTw8ZkCVFExfeZngHIhPYs40HIo= Date: Mon, 15 Jul 2024 13:33:38 -0700 From: Andrew Morton To: Miaohe Lin Cc: , , Subject: Re: [PATCH] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() Message-Id: <20240715133338.fb8b3b9a99f05b086fc54b82@linux-foundation.org> In-Reply-To: <20240715102806.2638849-1-linmiaohe@huawei.com> References: <20240715102806.2638849-1-linmiaohe@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 694B020026 X-Stat-Signature: soqsfqej6xmbcetzamifhobduu8jc6at X-Rspam-User: X-HE-Tag: 1721075620-975168 X-HE-Meta: U2FsdGVkX1+m4DpEEr9rcVJEwJjuxT5ZIcalDU7PiPPtGb0Pqxl5e3TRT2STdEvntUEPM0LaQrOTQ22xUkxZ/joybRD5pSkdW5W7eGSYVCWa7Ul1xCD+kPuKb/9c7e1JEIigsJVwhoyY3+GSlcQMjk6jV0oscLPK9PoxNFOqcVwW1J8CzVebINkey3LjHwqHm9+h1+hgHoyFSeyU8IcnHASrv1cHxzBwmMUzJ04PZ8fQWC4igKMT56mITpiDAfrYU6B0Q3cEvjU1u4fwEgjlJtVwgZlL2DSaQakNvFfGkMvmjhb4lnfpxjUjHrTR5oJnbemTuzXDR7p/qTgRWRsq9fhDIQfohs9wXfF63lYBxSmis3njzLlNc8hS5kYlHEIrnuQde+0L1MG7Ng3Vg60JwfXoEI54FObOlVVMn2Kdvl40RrTWh54Oxv3RdskElE9PgLc22PO8rpQHLVKCql+6pNqJO0RQzxiLWLs/k5jaf0PSkBhHab/jhUmJh3gNKWAJHakyw2ldfoe2EBit6qqcVl4lrx0IXdis+/Vvfp+PP2ImsAq0/y4+PbjV3wvMu6Z1OHO9F6bbYbOy5UmFDM0SsJIcfqguB8mITS/mdAxrnVIEAR4SOLR/7q48cP2E6sAfwapl9Zx7GWH7AUSF/Vzs07SfzZDMzsJ0sER70K43oHM46HAyROd/OrZKPzi8vPFuep6lKHu1SUflltxWwjbES4AvpWKvim+uF5dkB5uzpPf95ra1AlV3lxWhwe463BckMtauir97SZF9WS3DCKj3cN10Gkw0cpd121OWJrSq6kuN1xZy2Gq6doV8vKVRJHXQtICApKYFM65HkZw8XTryRthhf2PsXvtFSKzv2b9ccIh61egsLoPiFfxVLoOTeYbpM5oyM5YARd+ek5S3BgnzboEAnY4HZccJ+wM8lUgE1fSXo5aPCB6j+s7ap6u90dijZtl5FbteZp4EGx6ezSG DS4lQZJW hPPCymFNGRCYRbhXzcIh3zisMhjv8Z3cjapHsj6U+SBuU9fIFZyL9RJC4Ou0CFXX4RIbc8KQbCRb9FQIrLmQjjKsRwp/k31TA7kvO3d844FoAIsx0RxzZTKgHMYZFPIgCJyF7MssdAgtMUEntE3hkqQI+aARjPqQk9WPrMn39hJIEpzOdIVTpTqyOLA7ja5lt9eZyE7T8DnTEX3GMd3pL/DxG6cK+7t+Z0OmDK6I/oZ+UW0qSVU+fpSbsgnU3h1idk34WsHbMZW6AYmf1hZTI4SyqRbq9A3BKRqjJfMzSAfvQRZRH7zqa2i3v3yR3oFxMBjZKaIW/Md3qVS++jNbFRvlzptu6CdEAvLZmBbpJlsr/qwTlwnzd8+xzmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 15 Jul 2024 18:28:06 +0800 Miaohe Lin wrote: > When hwpoison_inject module is removed, hwpoison_filter_* parameters > should be reset. Otherwise these parameters will have non-default values > at next insmod time. > > ... > > --- a/mm/hwpoison-inject.c > +++ b/mm/hwpoison-inject.c > @@ -64,9 +64,20 @@ static int hwpoison_unpoison(void *data, u64 val) > DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n"); > DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n"); > > -static void __exit pfn_inject_exit(void) > +static inline void reset_hwpoison_filter(void) > { > hwpoison_filter_enable = 0; > + hwpoison_filter_dev_major = ~0U; > + hwpoison_filter_dev_minor = ~0U; > + hwpoison_filter_flags_mask = 0; > + hwpoison_filter_flags_value = 0; > +#ifdef CONFIG_MEMCG > + hwpoison_filter_memcg = 0; > +#endif > +} > + > +static void __exit pfn_inject_exit(void) > +{ > debugfs_remove_recursive(hwpoison_dir); > } The new reset_hwpoison_filter() has no callers?