From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C456C3DA4A for ; Thu, 11 Jul 2024 13:24:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 853866B0099; Thu, 11 Jul 2024 09:24:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80E0D6B009A; Thu, 11 Jul 2024 09:24:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67B9B6B009C; Thu, 11 Jul 2024 09:24:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4BDC06B0099 for ; Thu, 11 Jul 2024 09:24:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E75AF405E3 for ; Thu, 11 Jul 2024 13:24:33 +0000 (UTC) X-FDA: 82327541226.13.C6C9B7C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf06.hostedemail.com (Postfix) with ESMTP id A152618001F for ; Thu, 11 Jul 2024 13:24:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d0Drj52y; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720704244; a=rsa-sha256; cv=none; b=XC3XUkUi6k4lPu+1BYp6n/LRT8bmgNSj7pbKGtq6pMhF2bS1uvszlwgqsd7SAUin5z39MA /M5LYffa3UA1C7831prT1duTjX5VE4xi+4VUo4PNqaZL1Sr4k1G4CGNPb5uW/gP2+jYyZQ 4Myy4CwWgUu668dBtqSnpOkkgHcl5Z0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d0Drj52y; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720704244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FaIxNp/Lckug/MmZXw2XJ6OnVtnaTGVGeHGJkkkFhKs=; b=CppxeuEMWhEy7+LelCUSxd4gZn0RoRVYwPE6uXP8B0VKjHSodeJ32iU5L8Nib05mNoLeGr O4FeSqgRxikFVBOHPKwAfl3MJ/9ay/84QDAyC8GL9ULqPf88NxaKeYp/Hh2ckPZRwvDqjz pxpvLw/omqAx/JRPeRBHRGAkBFlsqpE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720704270; x=1752240270; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KAnGBHpCxcNlVVtwdfdNAWR48fJas1MfIdvTMUQRyEU=; b=d0Drj52y/pS4MtzvE2+0iylL0FpsZTgYOTuyx9YZsH6yhXHCi8YXxbnx PnUsHBucZeRAdbeu1SXeG9xeyrWoyPG2RDiEBWNs6ZSi/QIo73bHzAm6Q b7zTSyutyKlU/dX0uuBR4h0FR1uQsd4vPJ13abel6FF+4bCNOnVvXeVPX fFmWsQCMh6XFaxwsv27zlhJgnVo3b8XI2n8/qA9afnFpwH/Cte4sEM9r7 V1sx3u1T6a4yPMczKTGpPfdd0VzRer/WvmZZHcGkBwGEZXiMtPThnyJxk UDEfbq1pcZ/Uo2Tj8SrgQJfWgUw7abHZvBKvv2n56hXKCR40llp4GEPF6 g==; X-CSE-ConnectionGUID: ctXjnnHUR3eElz4t40amtA== X-CSE-MsgGUID: EmU4adlET/qCmVIb7S8QuA== X-IronPort-AV: E=McAfee;i="6700,10204,11130"; a="18027813" X-IronPort-AV: E=Sophos;i="6.09,200,1716274800"; d="scan'208";a="18027813" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2024 06:24:29 -0700 X-CSE-ConnectionGUID: pEL7xV6+SeaKGCCdyc7XKQ== X-CSE-MsgGUID: Bzn3bDKVSPeVyTDsl7qAwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,200,1716274800"; d="scan'208";a="53733484" Received: from lkp-server01.sh.intel.com (HELO 68891e0c336b) ([10.239.97.150]) by orviesa004.jf.intel.com with ESMTP; 11 Jul 2024 06:24:26 -0700 Received: from kbuild by 68891e0c336b with local (Exim 4.96) (envelope-from ) id 1sRtmZ-000ZJu-2d; Thu, 11 Jul 2024 13:24:23 +0000 Date: Thu, 11 Jul 2024 21:23:52 +0800 From: kernel test robot To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Alexander Duyck , Xuan Zhuo , Andrew Morton , Linux Memory Management List , David Hildenbrand , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev Subject: Re: [PATCH v2 1/2] virtio_balloon: add work around for out of spec QEMU Message-ID: <202407112126.plGUWi8I-lkp@intel.com> References: <19d916257b76148f89de7386389eeb7267b1b61c.1720611677.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19d916257b76148f89de7386389eeb7267b1b61c.1720611677.git.mst@redhat.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A152618001F X-Stat-Signature: ktub8gkig1we3tffn66osq35fpri4w9z X-Rspam-User: X-HE-Tag: 1720704270-846826 X-HE-Meta: U2FsdGVkX18oZfnUPk6DAUKNBMii+0Umi1cXIZiqw7ZsTY6EkVj3PVGFck5USGhan+yjCHnOMEAiITJjC4S9Dx3HG0IcLRGmE/FvnCzHdR5AdMUwfKVDg29a+ozn89b8bCK8XFvpvMPX+N3tP2AkeDUiUBeel2j0pQrmx7jKM7MMRzFaUciDD0PpIb/tBbu2GikA6hJLxcqC68cOtxAT3Df7zDxQKm3XDswU3uF4GwOJ/Lvg5G/06BdAQTTfMupaIM8mq5fajIKt6RNwR/v8wjAYgbxIi3TAiXkAvFwfhlBL3CJQ6kg82E/5pX19u9oo8+1WIwH+0+tl9Jj6HFs4dghmcS6RCgUkUjTmosSNpnlIenfZcZReBeW6ISFy6BHTed+trI6M2YMvdD94vLjtppthhmb/AOMmZJoISVuHbNl2txpHYZ/QHkdu5SqM64tlJ91XLmZzBk4j8CUgf88F64geeH2As9cULjHVITDcH/USbqpRCP8/Fqx8nk4Aa4Zpe8bvviecJdDva1WVOMSqEpBLRpyMZRxb5++DH3eN3REP/QxP/QwpvkLpiD8p315wcd21dnL3gS5Xv9Bb8DIz5vKa//DgwCS4nai9kzsU4ElOuldIEDsrm/c4iXAVuViwCAFTrM0m3AkNiNOhy5WxufGFxneSF5bKKOqyvhfCeXQVMAKdH/sWPiblWOxjhdBuolVPC28KA3A5lBHSWsIOXxM3MN4phKptL3aBPpipDrlGUkknYxl4VfO4R6kh3E1WpTEefdLvskxW7CDmRNP+ttJzE1mLqUTVTPy0OF7qiLUE0n/1jTjVHIi8UUTlGsnq/YCCyfX3tJi63udrPzJWx0CAAY2dBhknGlJ1qSo93Wyk8zu1je3R2Rgh+BIt7BP4fXhz+Wwp/YI+HzJO+GDlQokibYsCcLFMlYaedcb9pDQ6qxHmFCGoXVBNM3G0c2tZFUuTt00v3V+XJotn186 oMmw89RB ddGSzZu8Yu0SHfVN3TR9GighfP32KNfD7ZF0sQkeaMq0z1Vd4ofJe+Vj9nKMECirb3dbkL7aptm6QkA9S5+n513EK04/2jO2jBe1NBKJ8s4j8YO2ewBavYbHbv7nz1XyHPRN0mDPjFFw2ZmveduPpx7zauLoVgJl1ukMMXcaaOX3JH2zg0bRG2fnQKvR1mgbaHRMRvo0Guye4OYqeUsPU0hgvLpKH7TU4yn897AIon631lUfsPY2Fm796USWBzUxIZ7YbcnUfVCyOU4z+xItF+21sUR7JvjpNyk5vk43ssyCq99DDBHZWZOt7W03SAYP4JQKRnLb1J+t7o2ZKi5pRwt0c/bA0ACtP3Mh3ZdTmz3zTiloJQJjMlQmECFZK47S8A1CwcCMHVDTCfDYBsIOn/+FeaXRr7p9AeQYkm21x36Jsjo2jvSRVbMFqKXPFakpajIfg+TOhY7jcsFkVvdLK1sjmvLufBlb/Q8919BjiVpyAMA+AByzj+wI10vS8N/DPdvvGKwxHXUwwIIg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Michael, kernel test robot noticed the following build errors: [auto build test ERROR on next-20240710] [cannot apply to uml/next remoteproc/rproc-next s390/features linus/master uml/fixes v6.10-rc7 v6.10-rc6 v6.10-rc5 v6.10-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Michael-S-Tsirkin/virtio_balloon-add-work-around-for-out-of-spec-QEMU/20240711-004346 base: next-20240710 patch link: https://lore.kernel.org/r/19d916257b76148f89de7386389eeb7267b1b61c.1720611677.git.mst%40redhat.com patch subject: [PATCH v2 1/2] virtio_balloon: add work around for out of spec QEMU config: i386-randconfig-005-20240711 (https://download.01.org/0day-ci/archive/20240711/202407112126.plGUWi8I-lkp@intel.com/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240711/202407112126.plGUWi8I-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202407112126.plGUWi8I-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/virtio/virtio_balloon.c:603:55: error: too few arguments to function call, expected 5, have 4 602 | err = virtio_find_vqs(vb->vdev, | ~~~~~~~~~~~~~~~ 603 | VIRTIO_BALLOON_VQ_REPORTING, vqs_info, NULL); | ^ include/linux/virtio_config.h:225:5: note: 'virtio_find_vqs' declared here 225 | int virtio_find_vqs(struct virtio_device *vdev, unsigned int nvqs, | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 226 | struct virtqueue *vqs[], | ~~~~~~~~~~~~~~~~~~~~~~~~ 227 | struct virtqueue_info vqs_info[], | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 228 | struct irq_affinity *desc) | ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. vim +603 drivers/virtio/virtio_balloon.c 560 561 static int init_vqs(struct virtio_balloon *vb) 562 { 563 struct virtqueue_info vqs_info[VIRTIO_BALLOON_VQ_MAX] = {}; 564 struct virtqueue *vqs[VIRTIO_BALLOON_VQ_MAX]; 565 int err; 566 567 /* 568 * Inflateq and deflateq are used unconditionally. The names[] 569 * will be NULL if the related feature is not enabled, which will 570 * cause no allocation for the corresponding virtqueue in find_vqs. 571 */ 572 vqs_info[VIRTIO_BALLOON_VQ_INFLATE].callback = balloon_ack; 573 vqs_info[VIRTIO_BALLOON_VQ_INFLATE].name = "inflate"; 574 vqs_info[VIRTIO_BALLOON_VQ_DEFLATE].callback = balloon_ack; 575 vqs_info[VIRTIO_BALLOON_VQ_DEFLATE].name = "deflate"; 576 577 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ)) { 578 vqs_info[VIRTIO_BALLOON_VQ_STATS].name = "stats"; 579 vqs_info[VIRTIO_BALLOON_VQ_STATS].callback = stats_request; 580 } 581 582 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT)) 583 vqs_info[VIRTIO_BALLOON_VQ_FREE_PAGE].name = "free_page_vq"; 584 585 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_REPORTING)) { 586 vqs_info[VIRTIO_BALLOON_VQ_REPORTING].name = "reporting_vq"; 587 vqs_info[VIRTIO_BALLOON_VQ_REPORTING].callback = balloon_ack; 588 } 589 590 err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs, 591 vqs_info, NULL); 592 if (err) { 593 /* 594 * Try to work around QEMU bug which since 2020 confused vq numbers 595 * when VIRTIO_BALLOON_F_REPORTING but not 596 * VIRTIO_BALLOON_F_FREE_PAGE_HINT are offered. 597 */ 598 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_REPORTING) && 599 !virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT)) { 600 vqs_info[VIRTIO_BALLOON_VQ_FREE_PAGE].name = "reporting_vq"; 601 vqs_info[VIRTIO_BALLOON_VQ_FREE_PAGE].callback = balloon_ack; 602 err = virtio_find_vqs(vb->vdev, > 603 VIRTIO_BALLOON_VQ_REPORTING, vqs_info, NULL); 604 } 605 606 if (err) 607 return err; 608 } 609 610 vb->inflate_vq = vqs[VIRTIO_BALLOON_VQ_INFLATE]; 611 vb->deflate_vq = vqs[VIRTIO_BALLOON_VQ_DEFLATE]; 612 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ)) { 613 struct scatterlist sg; 614 unsigned int num_stats; 615 vb->stats_vq = vqs[VIRTIO_BALLOON_VQ_STATS]; 616 617 /* 618 * Prime this virtqueue with one buffer so the hypervisor can 619 * use it to signal us later (it can't be broken yet!). 620 */ 621 num_stats = update_balloon_stats(vb); 622 623 sg_init_one(&sg, vb->stats, sizeof(vb->stats[0]) * num_stats); 624 err = virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, 625 GFP_KERNEL); 626 if (err) { 627 dev_warn(&vb->vdev->dev, "%s: add stat_vq failed\n", 628 __func__); 629 return err; 630 } 631 virtqueue_kick(vb->stats_vq); 632 } 633 634 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT)) 635 vb->free_page_vq = vqs[VIRTIO_BALLOON_VQ_FREE_PAGE]; 636 637 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_REPORTING)) 638 vb->reporting_vq = vqs[VIRTIO_BALLOON_VQ_REPORTING]; 639 640 return 0; 641 } 642 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki