From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B926DC3DA4A for ; Thu, 11 Jul 2024 11:08:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39E526B0093; Thu, 11 Jul 2024 07:08:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 350156B0095; Thu, 11 Jul 2024 07:08:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A0476B0096; Thu, 11 Jul 2024 07:08:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ED09F6B0093 for ; Thu, 11 Jul 2024 07:08:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 673F8C0536 for ; Thu, 11 Jul 2024 11:08:39 +0000 (UTC) X-FDA: 82327198758.24.00A1503 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 2AE6A40012 for ; Thu, 11 Jul 2024 11:08:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JNqlpCJQ; spf=pass (imf04.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720696085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lO+vKeSv7uIVC2/ZKMhRQIH1J+OUbASrL8o+t3AQg7E=; b=zpi+QIXMHZHKTNJUYxOp6k4KGTEzjKi3R7vZalaYZM8twLebtMUzuaG7L+01TBaNmegY82 NbEBUFhdHyDTf/ySX9ImZ9KZcBf+4B+uzxPBvpBuVVrgoXt9eLSS2khmFrBO9TF3z/rYf7 2vAs4qt0Hi85WAUx0nl7HyvduiA9QC8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720696085; a=rsa-sha256; cv=none; b=HP6pg0dJjppKEOYegEGpa/17NAsFZC3SjgnCq6HabAkQySkyfK9vNTIRAAsN1yR5A+d+6y i/yqWjGu3O0ei0d7gtenYoQUo/hVvLVcwR8II6MVtSOd7eCEkrNxGWczGT5DnOdPoJt+kh 4BF/+eToO8g+Cew3gLQfA/UAnA4FS54= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JNqlpCJQ; spf=pass (imf04.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4D48361D0F; Thu, 11 Jul 2024 11:08:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34BA0C32786; Thu, 11 Jul 2024 11:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720696114; bh=V0Y36Pam00rCiMQb26squSrDlnu7zkSekBYQGaNEp4g=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JNqlpCJQnzaR4gPRF+/O7iGm2A36GRWO+KYPfgCzi+SSbIJ978sLXFTiY7DHW2bE+ eGFmiXzdEx7tdFvxZrS8DXqAwndXrA2C1o5/vvB9K8i68QH2Ewh29kC00nDEodVbE4 FGz+TV/F2NmCZueArvI+bsTRWDzQUzQvURwbYUXojZlDeJ4qb/uL2WLucfVPg8olqf 7s78U0dC7qDEidr4Hr1Xv4cO3CpxgpquMVzYVT1tTg9xPdewRFVqA7SLvfGnntJe5P rJDK7r5NSwVCzs4BrJ/5g8Wujp/7ggImfhB9jhhSY2N+Gxs07I1C/bCj5G5MBtTdAC 4mFINDf7SE5/w== From: Jeff Layton Date: Thu, 11 Jul 2024 07:08:07 -0400 Subject: [PATCH v5 3/9] fs: add percpu counters for significant multigrain timestamp events MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240711-mgtime-v5-3-37bb5b465feb@kernel.org> References: <20240711-mgtime-v5-0-37bb5b465feb@kernel.org> In-Reply-To: <20240711-mgtime-v5-0-37bb5b465feb@kernel.org> To: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet Cc: Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org, Jeff Layton X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3923; i=jlayton@kernel.org; h=from:subject:message-id; bh=V0Y36Pam00rCiMQb26squSrDlnu7zkSekBYQGaNEp4g=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBmj70krkIlkGBeCvXUTXPhRsNRgPGJ/7YIxm4VL oKt1D2isCCJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZo+9JAAKCRAADmhBGVaC FW9aEACXcSFuqDDqkal+wDTNWITDuTTUB2w8mpenTaC/RQ3UZtBsS3UcX1Cx8QGaA/9P1j70Kpc b24dZI2nx8fs3w6Tdw+tosbB/bBOkwvgj6FdMTijoam8dSosicCguBmMSx5afItFNUeokv4BpZq fYTF7BCzFykIsuYa8XzhyDtFt5TpzJtbHjrFMhpCioS62H8q+jReo87cZThXZkAagQYFnFb7G2X yNacNVvoBPllyhx9PA0PdCv3+A5HDmtWKzFH/w+doHLJb3Umabh9NkkQNvf93F5jKFrpMD9jNxa odgFtZ7FVa08ZF5AoVNUUa7/TwwAYlsvMJt7eZsthrL2N5/zth9xDVzCJd1qVvgwrAjfKUzo2Co yKM5XS+ZmsTnpi1u6TesAh1lvQk+L3uX01nCXJEtyovW1FvVRTPBgFNvviObAKTj/cyd2ZHJno0 iaC79matLqywBRRBk7lkHD48raPWyTxIniS3Oo8dAzxF+sRZeMZFkMwgnuLXyJk/oghLI0NqlUf dXAA5OHTlY0zGAZWoVLrcnPu2NXMDt9074Qvn7BcbYsOs8KVGY9Wm3XyT+IX0c9FQX1O6bWT/J3 oTWjUmrPm+su1GqxnnelBFzr1W79r+m/y4xgRiiD9eJLqFBEx4O5EoSFC+o6wdeplizkl0ovYh/ /RbyRLwcUU9VYrw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Rspamd-Queue-Id: 2AE6A40012 X-Stat-Signature: rj619nitnhgrdqu5aax1b9pnjddwumak X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720696116-518939 X-HE-Meta: U2FsdGVkX1/d7Zf/J31adtlQ5zuzcqmuPYLzVCWUOtgNl43o/co/LZOUsjMlx2Msq5o8h2cjirJu9XohFgYCA6D+9L8O1ZMuNiSxm59ZjFeIQcK+CQ08dFexQ2/es3/JFeI88Z3oO3on/Rb1/zP5ICWE1kSPnND6uEjLZE6mVtsFL56GeMkIF9s0UtV290UQiPjZ09Vpb6q42k2YPsJ9aiRPManyQjVjXSbcBnAByzcwwlpvnV/h9lEC4DY6k5ogHDGTUFCh4tWjGRRzg02dPuZEElODnO0xMVHE4zXuieXgEqlY6ebqopvF/rJh8hux1k9ghIyMolakaE9afe+gCRg+iWiQ3iFf+j5X0vYSoh7iN7VVf4z9CS1yeNGE22V0JCZrE7Bc6K1PC+kr7/1F5ohWMdsegfXppFJ56KKmoJYUI5dpXJokP/S8EjXQj3y6PNeSV32wEd10YV0I7H1OyGSqJ29E3O/0maZvGHONrGZ6Pytl/DSwgamrHzhx0ojVX1ERwl9HLu+tG2oSZmz/he60T/wgGAVXPrdxpjLJWds43nT+LaYs2aXXfNKbRg09KaKAlcoqcuQASlQOTobOw8fL/YZGkPEpbIR7NVtTdPtaM5A/zzqFi/rmurKBluRYdEGVWkuKzWk/0lErRWATww1xpeofYJqoLFACwgddZ/ViIpKJlm6GdN3/2gx+8ujPuCftjJf35QH/vVsMKUrUKTaVxz0ZqYqXino76EhcQSTPSK+f7XDGY34SWljsmU32G/eHFD1BlZow/qaIk3Oc2DqUuFNkaP48ixaoZg65n2h4UxsUePNxeVb5qoBNIXPC1pP0UDNCBUTQxDH2ldcRtN3XntVdcBq2QGDCNoQRhyuOvr24SnfHfB6xzObFk2G80gvBuGguGtYUr9/KSWm0VOAXpXZXN5VreE3z0u6OunD6qoUZ6G4U+nxPkgm79kZlPogqfzh9atkvPbdz10i FOIo5MSH 7bplb5jCvnSByX18EOThWqoCGvT0HAGVJ375r1jZphBeYuPWGHGdTyzwwmVRNlVPDChgmf8SJ23tDHf+xPBgK32kE60OIrRAAjVkxG2LQ+UpCOiI82iXdujttRq5Pa9Q9TvYMecmZ1c503PZaBE473sKd5vLn8jMX0cLgdPEYBx+M+JRDrFMMZbxfwTzbJaHTtK6TQFcio5ryLwMrXdwYLyrLR171lLWBs2cAxp/p3ALXCFazRBXFNy/4nfRJyaRKe3PYyk+DBGqKwXWIya2yR2htQ5f9UEWWR0eRNw105M6qUmxXjKaYZ5fJaHMD9Vh4TOsEz2lQ5Iu2kwegxzhmwdpAUFwjtbKw2UZgWVSyIdwCGWqKRlbGtf2Ke3/Gn5DEkD3Rh9nf/U5MusIR3E9OzJyGQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Four percpu counters for counting various stats around mgtimes, and a new debugfs file for displaying them: - number of attempted ctime updates - number of successful i_ctime_nsec swaps - number of fine-grained timestamp fetches - number of floor value swaps Signed-off-by: Jeff Layton --- fs/inode.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/fs/inode.c b/fs/inode.c index 81b45e0a95a6..011148c82901 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -21,6 +21,8 @@ #include #include #include +#include +#include #include #define CREATE_TRACE_POINTS #include @@ -70,6 +72,11 @@ static __cacheline_aligned_in_smp DEFINE_SPINLOCK(inode_hash_lock); */ static __cacheline_aligned_in_smp atomic64_t ctime_floor; +static struct percpu_counter mg_ctime_updates; +static struct percpu_counter mg_floor_swaps; +static struct percpu_counter mg_ctime_swaps; +static struct percpu_counter mg_fine_stamps; + /* * Empty aops. Can be used for the cases where the user does not * define any of the address_space operations. @@ -2654,6 +2661,7 @@ struct timespec64 inode_set_ctime_current(struct inode *inode) /* Get a fine-grained time */ fine = ktime_get(); + percpu_counter_inc(&mg_fine_stamps); /* * If the cmpxchg works, we take the new floor value. If @@ -2662,11 +2670,14 @@ struct timespec64 inode_set_ctime_current(struct inode *inode) * as good, so keep it. */ old = floor; - if (!atomic64_try_cmpxchg(&ctime_floor, &old, fine)) + if (atomic64_try_cmpxchg(&ctime_floor, &old, fine)) + percpu_counter_inc(&mg_floor_swaps); + else fine = old; now = ktime_mono_to_real(fine); } } + percpu_counter_inc(&mg_ctime_updates); now_ts = timestamp_truncate(ktime_to_timespec64(now), inode); cur = cns; retry: @@ -2675,6 +2686,7 @@ struct timespec64 inode_set_ctime_current(struct inode *inode) /* If swap occurred, then we're (mostly) done */ inode->i_ctime_sec = now_ts.tv_sec; trace_ctime_ns_xchg(inode, cns, now_ts.tv_nsec, cur); + percpu_counter_inc(&mg_ctime_swaps); } else { /* * Was the change due to someone marking the old ctime QUERIED? @@ -2744,3 +2756,49 @@ umode_t mode_strip_sgid(struct mnt_idmap *idmap, return mode & ~S_ISGID; } EXPORT_SYMBOL(mode_strip_sgid); + +static int mgts_show(struct seq_file *s, void *p) +{ + u64 ctime_updates = percpu_counter_sum(&mg_ctime_updates); + u64 ctime_swaps = percpu_counter_sum(&mg_ctime_swaps); + u64 fine_stamps = percpu_counter_sum(&mg_fine_stamps); + u64 floor_swaps = percpu_counter_sum(&mg_floor_swaps); + + seq_printf(s, "%llu %llu %llu %llu\n", + ctime_updates, ctime_swaps, fine_stamps, floor_swaps); + return 0; +} + +DEFINE_SHOW_ATTRIBUTE(mgts); + +static int __init mg_debugfs_init(void) +{ + int ret = percpu_counter_init(&mg_ctime_updates, 0, GFP_KERNEL); + + if (ret) + return ret; + + ret = percpu_counter_init(&mg_floor_swaps, 0, GFP_KERNEL); + if (ret) { + percpu_counter_destroy(&mg_ctime_updates); + return ret; + } + + ret = percpu_counter_init(&mg_ctime_swaps, 0, GFP_KERNEL); + if (ret) { + percpu_counter_destroy(&mg_floor_swaps); + percpu_counter_destroy(&mg_ctime_updates); + return ret; + } + + ret = percpu_counter_init(&mg_fine_stamps, 0, GFP_KERNEL); + if (ret) { + percpu_counter_destroy(&mg_floor_swaps); + percpu_counter_destroy(&mg_ctime_updates); + percpu_counter_destroy(&mg_ctime_swaps); + return ret; + } + debugfs_create_file("multigrain_timestamps", S_IFREG | S_IRUGO, NULL, NULL, &mgts_fops); + return 0; +} +late_initcall(mg_debugfs_init); -- 2.45.2