linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Lorenzo Stoakes <lstoakes@gmail.com>,
	Matthew Wilcox <willy@infradead.org>,
	sidhartha.kumar@oracle.com,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Bert Karwatzki <spasswolf@web.de>, Jiri Olsa <olsajiri@gmail.com>,
	linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>,
	"Liam R. Howlett" <Liam.Howlett@Oracle.com>
Subject: [PATCH v4 09/21] mm/mmap: Expand mmap_region() munmap call
Date: Wed, 10 Jul 2024 15:22:38 -0400	[thread overview]
Message-ID: <20240710192250.4114783-10-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20240710192250.4114783-1-Liam.Howlett@oracle.com>

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Open code the do_vmi_align_munmap() call so that it can be broken up
later in the series.

Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
---
 mm/mmap.c | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 49b3ab406353..a1544a68558e 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2916,6 +2916,9 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 	struct vm_area_struct *next, *prev, *merge;
 	pgoff_t pglen = len >> PAGE_SHIFT;
 	unsigned long charged = 0;
+	struct vma_munmap_struct vms;
+	struct ma_state mas_detach;
+	struct maple_tree mt_detach;
 	unsigned long end = addr + len;
 	unsigned long merge_start = addr, merge_end = end;
 	bool writable_file_mapping = false;
@@ -2948,10 +2951,27 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 	/* Find the first overlapping VMA */
 	vma = vma_find(&vmi, end);
 	if (vma) {
-		/* Unmap any existing mapping in the area */
-		if (do_vmi_align_munmap(&vmi, vma, mm, addr, end, uf, false))
+		mt_init_flags(&mt_detach, vmi.mas.tree->ma_flags & MT_FLAGS_LOCK_MASK);
+		mt_on_stack(mt_detach);
+		mas_init(&mas_detach, &mt_detach, /* addr = */ 0);
+		init_vma_munmap(&vms, &vmi, vma, addr, end, uf, /* unlock = */ false);
+		/* Prepare to unmap any existing mapping in the area */
+		if (vms_gather_munmap_vmas(&vms, &mas_detach))
+			return -ENOMEM;
+
+		/* Remove any existing mappings from the vma tree */
+		if (vma_iter_clear_gfp(&vmi, addr, end, GFP_KERNEL))
 			return -ENOMEM;
+
+		/* Unmap any existing mapping in the area */
+		vms_complete_munmap_vmas(&vms, &mas_detach);
+		next = vms.next;
+		prev = vms.prev;
+		vma_prev(&vmi);
 		vma = NULL;
+	} else {
+		next = vma_next(&vmi);
+		prev = vma_prev(&vmi);
 	}
 
 	/*
@@ -2964,8 +2984,6 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 		vm_flags |= VM_ACCOUNT;
 	}
 
-	next = vma_next(&vmi);
-	prev = vma_prev(&vmi);
 	if (vm_flags & VM_SPECIAL) {
 		if (prev)
 			vma_iter_next_range(&vmi);
-- 
2.43.0



  parent reply	other threads:[~2024-07-10 19:24 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 19:22 [PATCH v4 00/21] Avoid MAP_FIXED gap exposure Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 01/21] mm/mmap: Correctly position vma_iterator in __split_vma() Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 02/21] mm/mmap: Introduce abort_munmap_vmas() Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 03/21] mm/mmap: Introduce vmi_complete_munmap_vmas() Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 04/21] mm/mmap: Extract the gathering of vmas from do_vmi_align_munmap() Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 05/21] mm/mmap: Introduce vma_munmap_struct for use in munmap operations Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 06/21] mm/mmap: Change munmap to use vma_munmap_struct() for accounting and surrounding vmas Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 07/21] mm/mmap: Extract validate_mm() from vma_complete() Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 08/21] mm/mmap: Inline munmap operation in mmap_region() Liam R. Howlett
2024-07-10 19:22 ` Liam R. Howlett [this message]
2024-07-11 14:16   ` [PATCH v4 09/21] mm/mmap: Expand mmap_region() munmap call Lorenzo Stoakes
2024-07-10 19:22 ` [PATCH v4 10/21] mm/mmap: Support vma == NULL in init_vma_munmap() Liam R. Howlett
2024-07-11 14:28   ` Lorenzo Stoakes
2024-07-11 16:04     ` Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 11/21] mm/mmap: Reposition vma iterator in mmap_region() Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 12/21] mm/mmap: Track start and end of munmap in vma_munmap_struct Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 13/21] mm/mmap: Clean up unmap_region() argument list Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 14/21] mm/mmap: Avoid zeroing vma tree in mmap_region() Liam R. Howlett
2024-07-11 15:25   ` Lorenzo Stoakes
2024-07-11 16:07     ` Liam R. Howlett
2024-07-16 12:46   ` kernel test robot
2024-07-17 17:42     ` Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 15/21] mm/mmap: Use PHYS_PFN " Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 16/21] mm/mmap: Use vms accounted pages " Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 17/21] mm/mmap: Drop arch_unmap() call from all archs Liam R. Howlett
2024-07-10 19:27   ` Dave Hansen
2024-07-10 21:02   ` LEROY Christophe
2024-07-10 23:26     ` Liam R. Howlett
2024-07-11  8:28       ` LEROY Christophe
2024-07-11 15:59         ` Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 18/21] mm/mmap: Move can_modify_mm() check down the stack Liam R. Howlett
2024-07-17  5:03   ` Jeff Xu
2024-07-17 14:07     ` Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 19/21] ipc/shm, mm: Drop do_vma_munmap() Liam R. Howlett
2024-07-10 19:22 ` [PATCH v4 20/21] mm/mmap: Move may_expand_vm() check in mmap_region() Liam R. Howlett
2024-07-11 15:38   ` Lorenzo Stoakes
2024-07-10 19:22 ` [PATCH v4 21/21] mm/mmap: Drop incorrect comment from vms_gather_munmap_vmas() Liam R. Howlett
2024-07-11 15:39   ` Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240710192250.4114783-10-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lstoakes@gmail.com \
    --cc=olsajiri@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=sidhartha.kumar@oracle.com \
    --cc=spasswolf@web.de \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox