From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 189CCC3DA41 for ; Thu, 11 Jul 2024 01:23:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67F1D6B008A; Wed, 10 Jul 2024 21:23:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62DC06B0092; Wed, 10 Jul 2024 21:23:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5966B0093; Wed, 10 Jul 2024 21:23:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 305EE6B008A for ; Wed, 10 Jul 2024 21:23:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B406E14031C for ; Thu, 11 Jul 2024 01:23:30 +0000 (UTC) X-FDA: 82325724180.07.AB7FED3 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 806C21A0003 for ; Thu, 11 Jul 2024 01:23:28 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KObjfEuH; spf=pass (imf19.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720660992; a=rsa-sha256; cv=none; b=uFKeJp/GCCBcqQlWuP7iyTLB2QxOqTlE6AtrdFydRRK9YcSc28zzD5Py7wCOPkaDHh2tNc 7oel7vuzBsZ8t5INNPCVc0bj+91Rt/78nFC2CxZ+CTCDEesvx9uuCzkdeOLK/3JnzWb6dv 0YBwz8JwjY5mtIeJeVnNujjdaZWLvIs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KObjfEuH; spf=pass (imf19.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720660992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2sVKrNOw3m/GLat4uTTl7rV/zkeM3eePW5nq9ZRppLY=; b=kNEhLbrWMHLqUlqq0XU/kBrxXHJceCsXpiYMcJYXzJF6XASAABUhfb8GpliLqRooSeG4YX hkTN2KYT3PaWTJAS9i366OqesGokwvolQkwkEQqqfOIXGKDlzqdymvZEwe36XBX/0mmoom t8gB+T1gGC3pC5n5OVCtvBYbxq7lsEU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 76CCFCE16E9; Thu, 11 Jul 2024 01:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0730CC32781; Thu, 11 Jul 2024 01:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720661004; bh=BNGP4duokc8ncBE7271BuDVYIIwbBx7q1BctfwQaFqA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KObjfEuHg+F+/bNhywmUUTSGFn3bv/UvTtLsoLP/A8j+JrYJp2Ka3O/ezDg7IquU7 64ig4waKXABYjNs3vbvrYkR7ULJbLzB1fN702YTrMz0Hkxis8BMfqdvmxik/sQQ21K XXeIDIYx3mYfCBeuUJq0aaQspg3EQOjFC5mPiG7btWl7kDBRHcLzhqrGBo3ghENCin 5wPf+YTZV7+ICl9eWbLIMvEJhTp71W9ETPYKnyot5YbyIOKw8smwAldqsdn2p/dXmj xdQJd61Xv49iwsP6htPMECVZNf2v9MhwXGUeQ/ixSeS6yXvvH4jnN0ZxI/3Fhw701B s1ygLn4p0sytg== Date: Wed, 10 Jul 2024 18:23:22 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , Christian =?UTF-8?B?S8O2bmln?= , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH net-next v16 05/13] page_pool: devmem support Message-ID: <20240710182322.667f0108@kernel.org> In-Reply-To: References: <20240710001749.1388631-1-almasrymina@google.com> <20240710001749.1388631-6-almasrymina@google.com> <20240710094900.0f808684@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: epe79ees3un7n8y7qk8j7f6y73j67tam X-Rspamd-Queue-Id: 806C21A0003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720661008-425695 X-HE-Meta: U2FsdGVkX1/V3lu+RTv5nSz961rj0f00ppIhHkDRYRWawnNlGJQdMVQ8opieYpDktxk5Eo++DpitqDnOWQpCW7MVEp1bn8EOkY0QgywZt4y/MRjskDxxGxrlBSM+esBnxs083I7VCxHdZB/xhKw6LlMi9Q6nIOivaRPp8xHD3+b9yNOAzsOvjGB6RyJhjeQCbUkrY/IqJcm2CZz4gJetj9SMb3tLCrSu7LC9vNP6trrnBAMhqzM9yn0D83SLvxX3+z2eEFsOfMnI+Wj7PpXeDjuBNs9sT4i3YHS81Qd79d4gXrffjV51a5M6akMPk+GKvdW/vV0/kCf2wMmH5aNEacrAIcReU2Kg0I83YfvgZlIQs76OHr8SkmxzOvJd5deZO5aQCK4exE1srCph/Fm/dN1AzwpRBeFSr5Pv5/YDAgTSq2cVyKHO5wV7IiuxF7kcgg9Xn0s8i5QoAazNjiR5/xj8UTnbj6buQDtHG/8xb5cStkoNCVGJLMCxJbGyPmTrhFAaCgdbusuZCcQPuAFj0HF5ZkoeIdOS9DmJKOFx6ULt3yX0m1A81PtAh0l0/ikw0BLM04MixBscHB6aivdj07AoMDtgNDExjrPpIwDZcEnQKpckc+pBjjjJz6V7+j3G0NPeLGdBDSXCkBelyDuEhrXuHlX+RnX0MeFpFpw+59+9wlLj1pZFXTINygOMErVbPWsV73/K8P9Ljetk0xoyvnwKdBAIZv/AmKp+8exjwq2iqM26L2YC+Szlc0DudnPUB5TzXLsuRDgapuVtLe6McZXIXjLBEkd6iUpNJZVrzrp3Q8PEpkhz/Y2fW3DymqsXQBvnh5karmcQNaQh/MltP2K/oDBgsZcoBsVGcnQiolbujPdrImIC45Jwe96GKFuU+PjDcLcstfKVYu66BxpGJJ2L/NEfWzcsaJ3rYVc4FKQd14RaoHidU+Dyi56TAkz6awBMWjYwP949G/tZOXi ytCZzoSk rne3/k79/ecJ0NcT+H62J3r5rPOQC7VwfUoOEieoep6MNp2KSNdZWrXd/fG3K5d1SpHhsprEpXfHSuxlUz8veBdbiXcFTGD1pqZTntex/tg8NcwP650MYjw9TdqXpCTJPIWRDMzbtwfGd23fFAeOhDHfMGgxF66bdJrvF7rRn0ItcAszA99ADVGi58OptW6hU+hz1NuWNjno5pLHHE/j42OZmm/I6zbHeCLhPR9WjlGz9/I0bylyh11GT15tYwBNsfLpjX2qaglFzivkiP7RfNkAwvKGP/S0M1bchqk92AMMI6PNoUG4w6Nnyg2t15VMDE2EbjchnRBVwkpofD9oX5YkTnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 10 Jul 2024 16:42:04 -0700 Mina Almasry wrote: > > > +static inline void netmem_set_pp(netmem_ref netmem, struct page_pool *pool) > > > +{ > > > + __netmem_clear_lsb(netmem)->pp = pool; > > > +} > > > > Why is all this stuff in the main header? It's really low level. > > Please put helpers which are only used by the core in a header > > under net/core/, like net/core/dev.h > > Sorry none of those are only used by net/core/*. Pretty much all of > these are used by include/net/page_pool/helpers.h, and some have > callers in net/core/devmem.c or net/core/skbuff.c > > Would you like me to move these pp specific looking ones to > include/net/page_pool/netmem.h or something similar? That's because some things already in helpers have no real business being there either. Why is page_pool_set_pp_info() in helpers.h?