From: Lei Liu <liulei.rjpt@vivo.com>
To: "Sumit Semwal" <sumit.semwal@linaro.org>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Brian Starkey" <Brian.Starkey@arm.com>,
"John Stultz" <jstultz@google.com>,
"T.J. Mercier" <tjmercier@google.com>,
"Christian König" <christian.koenig@amd.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@redhat.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Muhammad Usama Anjum" <usama.anjum@collabora.com>,
"Andrei Vagin" <avagin@google.com>,
"Ryan Roberts" <ryan.roberts@arm.com>,
"Peter Xu" <peterx@redhat.com>,
"Kefeng Wang" <wangkefeng.wang@huawei.com>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Cc: opensource.kernel@vivo.com, Lei Liu <liulei.rjpt@vivo.com>
Subject: [PATCH 1/2] mm: dmabuf_direct_io: Support direct_io for memory allocated by dmabuf
Date: Wed, 10 Jul 2024 22:09:43 +0800 [thread overview]
Message-ID: <20240710140948.25870-2-liulei.rjpt@vivo.com> (raw)
In-Reply-To: <20240710140948.25870-1-liulei.rjpt@vivo.com>
1.Effects and reasons for lack of support:
Currently, memory allocated by dmabuf cannot be read from files using
direct_io. With the increasing use of AI models in mobile applications,
there is a growing need to load large model files occupying up to 3-4GB
into mobile memory. Presently, the only way to read is through
buffer_io, which limits performance. In low memory scenarios on 12GB RAM
smartphones, buffer_io requires additional memory, leading to a 3-4
times degradation in read performance with significant fluctuations.
The reason for the lack of support for direct_io reading is that the
current system establishes mappings for memory allocated by dmabuf using
remap_pfn_range, which includes the VM_PFN_MAP flag. When attempting
direct_io reads, the get_user_page process intercepts the VM_PFN_MAP
flag, preventing the page from being returned and resulting in read
failures.
2.Proposed solution:
(1) Establish mmap mappings for memory allocated by dmabuf using the
vm_insert_page method to support direct_io read and write.
3.Advantages and benefits:
(1) Faster and more stable reading speed.
(2) Reduced pagecache memory usage.
(3) Reduction in CPU data copying and unnecessary power consumption.
4.In a clean and stressapptest(a 16GB memory phone consumed 4GB of
memory). A comparison of the time taken to read a 3.2GB large AI model
file using buffer_io and direct_io.
Read 3.21G AI large model file on mobilephone
Memstress Rounds DIO-Time/ms BIO-Time/ms
01 1432 2034
Clean 02 1406 2225
03 1476 2097
average 1438 2118
Memstress Rounds DIO-Time/ms BIO-Time/ms
01 1585 4821
Eat 4GB 02 1560 4957
03 1519 4936
average 1554 4905
Signed-off-by: Lei Liu <liulei.rjpt@vivo.com>
---
drivers/dma-buf/heaps/system_heap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c
index 9076d47ed2ef..87547791f9e1 100644
--- a/drivers/dma-buf/heaps/system_heap.c
+++ b/drivers/dma-buf/heaps/system_heap.c
@@ -203,8 +203,7 @@ static int system_heap_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
for_each_sgtable_page(table, &piter, vma->vm_pgoff) {
struct page *page = sg_page_iter_page(&piter);
- ret = remap_pfn_range(vma, addr, page_to_pfn(page), PAGE_SIZE,
- vma->vm_page_prot);
+ ret = vm_insert_page(vma, addr, page);
if (ret)
return ret;
addr += PAGE_SIZE;
--
2.34.1
next prev parent reply other threads:[~2024-07-10 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 14:09 [PATCH 0/2] Support direct I/O read and write " Lei Liu
2024-07-10 14:09 ` Lei Liu [this message]
2024-07-10 14:09 ` [PATCH 2/2] mm: dmabuf_direct_io: Fix memory statistics error for dmabuf allocated memory with direct_io support Lei Liu
-- strict thread matches above, loose matches on Subject: below --
2024-07-10 13:57 [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf Lei Liu
2024-07-10 13:57 ` [PATCH 1/2] mm: dmabuf_direct_io: Support direct_io " Lei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710140948.25870-2-liulei.rjpt@vivo.com \
--to=liulei.rjpt@vivo.com \
--cc=Brian.Starkey@arm.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@google.com \
--cc=benjamin.gaignard@collabora.com \
--cc=christian.koenig@amd.com \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jstultz@google.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=opensource.kernel@vivo.com \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=tjmercier@google.com \
--cc=usama.anjum@collabora.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox