From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F6EC3DA41 for ; Wed, 10 Jul 2024 19:18:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76A696B00A0; Wed, 10 Jul 2024 15:18:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71AF76B00A2; Wed, 10 Jul 2024 15:18:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 609806B00A3; Wed, 10 Jul 2024 15:18:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4A1746B00A0 for ; Wed, 10 Jul 2024 15:18:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E69E91C0664 for ; Wed, 10 Jul 2024 19:18:10 +0000 (UTC) X-FDA: 82324803540.08.1FDCC7F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 6AB8640020 for ; Wed, 10 Jul 2024 19:18:08 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=O7z3T8A3; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720639073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WS2oL8rN+x0Hx8pLpWdYv8Gtyr51hfTLPpluXh59jOI=; b=8ff6d7NOd0x0Nv7hAw5ZObl7caSDa2fE4ogdNKMlItd9PoeQOuTifTKwNNcAq8EegATA44 UWELP9vQvg5tDSeGoIN8V6dQCFDgUzIzEvsTWNdOFJTZyyTMhOJoR7XVBr5UamL2KbMdLu pBVTBtI2ILcRFrWwLkwmxWY0+AkugDk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=O7z3T8A3; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720639073; a=rsa-sha256; cv=none; b=m38S5VHPt4AGPp1zSp4esI2WY4L8WXVND5hrrLYxg8HoYUi0TWTB0P9LcXZmVMXDM9Zhh4 s1NiCfpZ95d8ztL3wF6Uk26lpCMlE2JsDlda8fEbfh8gTyv/rwrno5W82B3pFjJ9s2zx9P P49i47Y2DllyZDjzXsvYU5Lby0QNWP0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 42D1CCE12C7; Wed, 10 Jul 2024 19:18:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0509CC32781; Wed, 10 Jul 2024 19:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1720639083; bh=0ihz+DlqmEqKVS2DD/pDgRVbl8B31X8U8rySSkNJDMc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O7z3T8A3B4GolCybuptbj0cLCJONrz5UiiL1xZtL6EPax5CBzOyux7F3adKZtBxS3 /03+1jmomwoyqNbAB0nT677cKCtcgKIy0+OKzxu6YsjhGHprpUrFNK26wr1hLzCVpC rTLXpJ6r0XxJTzpfur+kEr50SDe70f+lMmesTQHg= Date: Wed, 10 Jul 2024 12:18:02 -0700 From: Andrew Morton To: Hugh Dickins Cc: Usama Arif , kernel test robot , Johannes Weiner , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Chengming Zhou , Yosry Ahmed , Nhat Pham , David Hildenbrand , "Huang, Ying" , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org, ltp@lists.linux.it Subject: Re: [linux-next:master] [mm] 47325a5c88: WARNING:at_mm/slub.c:#free_large_kmalloc Message-Id: <20240710121802.e1445448d94b3f6ea16fdd12@linux-foundation.org> In-Reply-To: <612af749-0a59-f91d-693a-43d6217ffebb@google.com> References: <202407101031.c6c3c651-lkp@intel.com> <053bd429-ae19-4beb-a733-a7a838b1e010@gmail.com> <4bc6400e-6199-4147-9399-4a54c94613fd@gmail.com> <612af749-0a59-f91d-693a-43d6217ffebb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6AB8640020 X-Stat-Signature: 1t71a8mxyocqehwmh48rjzq3kcgqrgb7 X-HE-Tag: 1720639088-237005 X-HE-Meta: U2FsdGVkX1+EePYQm4qJEvR8iuaw2ZK24s4s9vKV/kxBcwOCb0WGUIcQ+7/OKDcmHYWSoyXIcIbdA5P3z+Lp4dIEtDASsBJhDYSWpHQrzekCIboKDVRqBmbFNtOSsjU89JORAeLwMqzNA5SAqbwDXS23ufnAnEhye3h0F8+6Hzqdm9G1wHAq7PFvUSAIz+qVa81xDO/J3DwcBj+wVawLPqG1WGUSNwIjdVgEr9KrYnIZM+JSivq3l06+1i2SU068C67gJQfOVzgg8XrKGg3h6IMpCeC3iT6dq1nfXPtZ3GBlBv+CyETa7s00zsKBxdB2184xD36XrU3kUsbresdYM44NI2lUoDcK5LPDlf+9xWvTp1Vs1/8EeuIJ/YIpqx8NTEAf8Sg72kgT73l3QQRSHDE/XANAX1yHHBdl8sX37FudE7YFCpmXzIfHuPJToX5SJoo9Ur3yDIUCPxU5nlyPxfOzqeZBXC8ZCQKKnSPlCz5sS6z0Nq0ZsE19R5RSKZfWvNywtG3FjAdYo2HOQ0tggThYRkm+/QWgcHxPLkxodV16yz71OrYs+aPIz9L4CZmtIXmd+04rWiL/p2hnZoEbbEWJDlHzo2mihFC8SNsLKKSo8RXcJgxrNQF9XaMlr4b4I/FpXbzkGVaesQD5tDhz0dE9xFGTDE9UY5EQqzkwJBMo8R9tTflt2is8jokVwVPPuw7HV3fvo5u085qDefx3IVMNf400jmoVmllQ0Idz41lNVVsAuix0X2nK1cqwAgvZ0qqGz5ZmSREY4TxxZIglhvLI/zLdKxpmajFhFs+k1Ip4vKJLxo9PKgT6kqFTKHqcN/aPNCPxywkVbV1M6fUDH+pnmODgFo9KlD7IHR3BxCf5EMIh/5cXOs9jQIloDocypfmypZjU5VDuDEsAj5BsyQ8xzACppQ/4hCy+8i2nsKgZBsnvurz7XEHm9LUOP9pRM/FrifgMcTBK7/n+hy0 t1rm2t+U fkT/9R4C1BNirTNmLCAQD06sFYe6HDO1GUzMmz2g8r4DeAbs4MS1TG9MoQN+0974SKMMPRnKgvn8BFuBJtskmskzjfIjgpY9Id8lEmODmPwfFi2aAjDLk4+jHaHC6KDGsmC09U9tMcpGZmp0pUpqoIZBj+jryHzd9oIyh4M5a5sK9c7sRBzn/pp06rAfweYp20zSrK3uaIEOss96u6CUdl5ZN0UoEHjLMBnQzZOjckAY3uMf2KBHzsv+5kMyaRjukIfmB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 10 Jul 2024 11:49:09 -0700 (PDT) Hugh Dickins wrote: > It's a long time since I was active hereabouts, but the bot report > and your flurry of updates make me think that you should step back, > slow down, and look more carefully at the precedents here. > > IIRC, the main problem is that parts of the swap_info_struct can > still be in use from before while you're wanting to set up new values. > Observe how alloc_swap_info() may return a fresh or an old allocation. > Observe how enable_swap_info() is called after getting swapon_mutex > late in swapon(), once past all possiblities of error. > > I expect that your new zeromap needs to be taking the same care as is > taken with swap_map and cluster_info: to be safe, follow their example > in both swapon() and swapoff(). Thanks. I've dropped the series "mm: store zero pages to be swapped out in a bitmap" from mm-stable. Let's revisit in the next -rc cycle.