From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9473C2BD09 for ; Tue, 9 Jul 2024 05:24:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 299236B0098; Tue, 9 Jul 2024 01:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 249816B009B; Tue, 9 Jul 2024 01:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1386B6B009D; Tue, 9 Jul 2024 01:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EAF346B0098 for ; Tue, 9 Jul 2024 01:24:43 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8DD491416AB for ; Tue, 9 Jul 2024 05:24:43 +0000 (UTC) X-FDA: 82319074446.30.8203C15 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id E830420011 for ; Tue, 9 Jul 2024 05:24:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=XDqYKgsI; spf=pass (imf13.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720502641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B9ijrgKI0+Xtwb9zuBMhBTqtnYrYFmM2Eq0mEMJjdrw=; b=RbcOdc2xj3DB3cgOnIUPvTvwuS23dQzBJLYInHgawgpxkdW63GygAFZDa1lvxC1BnG88Hg 9yw393eyEZI5tXEuFKZqLOGplcuHduhWAzBIVu2hvCuSV88SGnVmUHQHvTTN3/NXL/l4/R ArKRr054yYBtkNhKiWofpPE8aeEMAmI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=XDqYKgsI; spf=pass (imf13.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720502641; a=rsa-sha256; cv=none; b=1i+jnjI6Ia6fR5bnkEDgZAUTzlvi3qn7h8OdsSk3drFA6czTb+T2aQO1vrkd99yQX8D24e 5Zo4AEiwoB43rHBj761pmes5Nly/WS1VSwBGoP5G2fOaphI8g1RIiMUkas0SP7AuPyrMI1 yHJ5y1zud6zulFJfUiZAzyo2i2EMedM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D959D60DF8; Tue, 9 Jul 2024 05:24:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1AFAC32782; Tue, 9 Jul 2024 05:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720502679; bh=4tizSs2TAz0RtnGGO1qTakHRK5xJiSrgMw06tNFDBRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XDqYKgsIjcET2kG1gBOUaqJpVZRjnWrfe/SliV+a6cDFnihfT2gV17xgJBP/01gLl KBHufVqFyunnGuPTq+OvlHH2V0IuFokKYmXxwNZ6Kl6NojikK6lbLLQonmlYHil3e0 h9DrFrcyO9g+jAUgHYWyvHHmvafZKTrKlMgmSCDs= Date: Tue, 9 Jul 2024 07:24:36 +0200 From: Greg Kroah-Hartman To: Martin Oliveira Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org, Andrew Morton , Artemy Kovalyov , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: Re: [PATCH v4 1/3] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: <2024070927-expand-carless-0680@gregkh> References: <20240708165714.3401377-1-martin.oliveira@eideticom.com> <20240708165714.3401377-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240708165714.3401377-2-martin.oliveira@eideticom.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E830420011 X-Stat-Signature: wii9mzsb9y9ccgxuqfyo3dtfowidey8o X-Rspam-User: X-HE-Tag: 1720502680-95762 X-HE-Meta: U2FsdGVkX1//jc79NM+/166hZrbYxfm46y1nF8vRcFBUISccJeIBMoxAVFjx9zysy7zKpZFb+culyiGYKZkJJ65d8taCcOVq84JXUzqkhkfZqqaVDBCaQli+I5E7ww6U/AtkVZ2USjGokXvYLxDONs7QayNbTVhkDP1s4igvA5k00g7x8HStZnClhCC+pQAgLVIE22pucYSlZJs6uBTm0bH2ztxrk4o9qcnVApT4LUgyeaux+29X9wZIwdbIG11QaDbTtz4wXJCcCceg9p00XOAd9GADJWehVHom6E8Wwe5+cD75DsgQiEbboIaydHAZz0/z0QRA6XhPd1MP9Dgra/lfa9gVemfFVJlSUFoNwKxGcJs/ZVYkeDC89zUyEAqYJ08gQdPlkOfzzIC1Wgo0X1eRfkQIKXjpU97UNoYrrK7ugxlJ8XgKgyiVaONfk9jF/ZAAzuDdgKd0g2WW2//783Nw8pkEDV/3wsnxb5jnFZ+VYApUvQCPk46AG3GJaoHxpn6QqxoRvsl2H+e1oe9fnWa0lvL+5vfDgO9skqAw5iYK8pGPvhh6MdiqqvmSyWaVTPKHXZZrPAWIov8mRxyl6CZSvw/5JavOtKi+1mwgMb6MjbWsr503viUIOCVFFEMsZbDtm9q7jSUKN/xPrpYAhoz9jlBYILbIfEsctGLy4TvAGpIiFqw+EZ8Pno18b/NdS9sFn0Jz787mpqElEBCBjD6jb1C8tLBUs97UA/r55JAiSgHdLixdrqUNk+VRE2gFm96V4nof676t1e5YdwoW2/FcrJYX8uT208Tm/BtV01KHvjo3zmGaCLbTjTZ1diD3/ZFGoS6wdHZPppS2c06veMZLcDpcob14gypyla2N0CxxXXsL9kcWLa1QowntjMD4Y0ucMPNr/N1WhBGVEvpWfgnlMVyxhjSfEw90PkHLQ75mh7SQVSmE9mzoQf+E1yBNcMCcIK5FSavq2wVpP6J gy1lucCN XUB8DxrpA4Q1UnY7GgORbKM4vh/0nX8Oo9rbxnKiVHHkzpHe+Xt90aiK7JveSPxDpwHjYC77fR4trhjXEjaFJdLMuonkVjG2gASKHeVNCflGeSq2a2jftQZJNXHwrh3A/K7U8yFmzEgWChCZ/Mau3oAOc6Hj+4m7f69W2qOqMbXyZ/NajJcbhESBDswYOhCBxocyudP7mZabWMuKlQWMHp5HKJ8nBDO/S9o5DOFmzRH+qhoLWkRLD6YllgH8EGe/1C1aRNXyqFMGSTW5XxCFnvE5N3K8OeGfzwxTNNn9wR4ZX4Bnn0GV21v5zkDXW17rUSrYvBTcN7RnEZjYdclwDStirhkRAUvfn+Uv9/WpgqiQ9+DMYW8O2e9HSu0ihXYlrjeklT21lO30mxnV4kCUWDaNuGseerkBr3w987XgMSE8lHnzM5Y+CO8nt7xwSmUBZOgOSXU+1X8KKRD4Tyw0FRXrsCufMW6PccjeH2C2Nx6wfa6eedeYiiscZSeAeWMb5z5LLuALZj+GhxTc5UwHr6AQkMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 10:57:12AM -0600, Martin Oliveira wrote: > The .page_mkwrite operator of kernfs just calls file_update_time(). > This is the same behaviour that the fault code does if .page_mkwrite is > not set. > > Furthermore, having the page_mkwrite() operator causes > writable_file_mapping_allowed() to fail due to > vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for > enabling P2PDMA over RDMA. > > There are no users of .page_mkwrite and no known valid use cases, so > just remove the .page_mkwrite from kernfs_ops and WARN if an mmap() > implementation sets .page_mkwrite. > > Co-developed-by: Logan Gunthorpe > Signed-off-by: Logan Gunthorpe > Signed-off-by: Martin Oliveira > --- > fs/kernfs/file.c | 40 +++++++++++----------------------------- > 1 file changed, 11 insertions(+), 29 deletions(-) Acked-by: Greg Kroah-Hartman