linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Yunsheng Lin <linyunsheng@huawei.com>,
	Alexander Duyck <alexander.duyck@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Subject: [PATCH net-next v10 09/15] mm: page_frag: use __alloc_pages() to replace alloc_pages_node()
Date: Tue, 9 Jul 2024 21:27:34 +0800	[thread overview]
Message-ID: <20240709132741.47751-10-linyunsheng@huawei.com> (raw)
In-Reply-To: <20240709132741.47751-1-linyunsheng@huawei.com>

There are more new APIs calling __page_frag_cache_refill() in
this patchset, which may cause compiler not being able to inline
__page_frag_cache_refill() into __page_frag_alloc_va_align().

Not being able to do the inlining seems to casue some notiable
performance degradation in arm64 system with 64K PAGE_SIZE after
adding new API calling __page_frag_cache_refill().

It seems there is about 24Bytes binary size increase for
__page_frag_cache_refill() and __page_frag_cache_refill() in
arm64 system with 64K PAGE_SIZE. By doing the gdb disassembling,
It seems we can have more than 100Bytes decrease for the binary
size by using __alloc_pages() to replace alloc_pages_node(), as
there seems to be some unnecessary checking for nid being
NUMA_NO_NODE, especially when page_frag is still part of the mm
system.

CC: Alexander Duyck <alexander.duyck@gmail.com>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
---
 mm/page_frag_cache.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_frag_cache.c b/mm/page_frag_cache.c
index 73164d2482f8..b2cb4473db54 100644
--- a/mm/page_frag_cache.c
+++ b/mm/page_frag_cache.c
@@ -59,11 +59,11 @@ static struct page *__page_frag_cache_refill(struct page_frag_cache *nc,
 #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE)
 	gfp_mask = (gfp_mask & ~__GFP_DIRECT_RECLAIM) |  __GFP_COMP |
 		   __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC;
-	page = alloc_pages_node(NUMA_NO_NODE, gfp_mask,
-				PAGE_FRAG_CACHE_MAX_ORDER);
+	page = __alloc_pages(gfp_mask, PAGE_FRAG_CACHE_MAX_ORDER,
+			     numa_mem_id(), NULL);
 #endif
 	if (unlikely(!page)) {
-		page = alloc_pages_node(NUMA_NO_NODE, gfp, 0);
+		page = __alloc_pages(gfp, 0, numa_mem_id(), NULL);
 		if (unlikely(!page)) {
 			memset(nc, 0, sizeof(*nc));
 			return NULL;
-- 
2.33.0



  parent reply	other threads:[~2024-07-09 13:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240709132741.47751-1-linyunsheng@huawei.com>
2024-07-09 13:27 ` [PATCH net-next v10 01/15] mm: page_frag: add a test module for page_frag Yunsheng Lin
2024-07-09 13:27 ` [PATCH net-next v10 02/15] mm: move the page fragment allocator from page_alloc into its own file Yunsheng Lin
2024-07-09 13:27 ` [PATCH net-next v10 03/15] mm: page_frag: use initial zero offset for page_frag_alloc_align() Yunsheng Lin
2024-07-09 13:27 ` [PATCH net-next v10 04/15] mm: page_frag: add '_va' suffix to page_frag API Yunsheng Lin
2024-07-10 11:13   ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-07-09 13:27 ` [PATCH net-next v10 05/15] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Yunsheng Lin
2024-07-09 13:27 ` [PATCH net-next v10 07/15] mm: page_frag: reuse existing space for 'size' and 'pfmemalloc' Yunsheng Lin
2024-07-09 13:27 ` [PATCH net-next v10 08/15] mm: page_frag: some minor refactoring before adding new API Yunsheng Lin
2024-07-09 13:27 ` Yunsheng Lin [this message]
2024-07-09 13:27 ` [PATCH net-next v10 11/15] mm: page_frag: introduce prepare/probe/commit API Yunsheng Lin
2024-07-09 13:27 ` [PATCH net-next v10 12/15] mm: page_frag: move 'struct page_frag_cache' to sched.h Yunsheng Lin
2024-07-09 14:56   ` Alexander Duyck
2024-07-09 13:27 ` [PATCH net-next v10 14/15] mm: page_frag: update documentation for page_frag Yunsheng Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709132741.47751-10-linyunsheng@huawei.com \
    --to=linyunsheng@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox