From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168C6C3DA42 for ; Tue, 9 Jul 2024 20:28:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A3936B008A; Tue, 9 Jul 2024 16:28:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 453D26B008C; Tue, 9 Jul 2024 16:28:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31BA46B0092; Tue, 9 Jul 2024 16:28:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 12DC46B008A for ; Tue, 9 Jul 2024 16:28:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C174A161A85 for ; Tue, 9 Jul 2024 20:28:56 +0000 (UTC) X-FDA: 82321353072.12.3421CD9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id B3F6E40003 for ; Tue, 9 Jul 2024 20:28:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EmTAyWIB; spf=pass (imf17.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720556920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D5LAoXYUQaLnF66xr6Eaut48YxmPjtapg7wzp/nprlg=; b=f47GqOCiuUbhnb+bC/3kcoT1e1z+UCsbPVYUSjFczqsNFPG8+8VhhVPpL/WPTA7nMe1NgZ H84Z8+uXCWIOsvbQGXl2VyW4tJB1Uq0uwp6AcfbfQdIGWjVkQjZLGPPCSV69UQcnXcGfRV XRt5HhUTuA0/KIFd7Tm2+AoFsLPAU0Q= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EmTAyWIB; spf=pass (imf17.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720556920; a=rsa-sha256; cv=none; b=gvgo0MT5RtF78C1YkpjyLpNNxNqIU+07uqsE/rxx4vdEn8YARK9onO/qSd0E/OqGSIOKbn faYab92REvhHMEruBUBRePHhSVFjBZGLQJeryoKmOGVMfUPw9CVkJpS5flE1YTmnIpQDqE yJbqI5YfDpUumK4YssXD0Px/sqhpUtA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 804E5CE12E4; Tue, 9 Jul 2024 20:28:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3159C3277B; Tue, 9 Jul 2024 20:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720556928; bh=/od/8NDo7YI4mcGiqROSpWSo0Vq0Svc7ugQRRWHIgmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EmTAyWIBox6iTlNcpEjiozvHqqsaSQqmssiA3sRSEjudjhFFGUH0gF1m+YjkY2CtY DnGJk2CEvBT5c6skfOIQJWLXh7PMOn59Z9DucZ2qCfblOXYDhOWttvty4yVVgXun9C 83539ZtY6woapgUb+Q3j2dnxwApt8TQa9hYehkmqHbC6p79ZnYv9wzQT4+XuN0eYWU FP1neFvEGOaNw5A0e0d0siPkwDYeNTj/8xxV3aGavRaE5m6o1gz95s3ZRP3pJUMthC Z+GvVb2J8T+GBT6MD8sAZvonOjYhPsd5ro0W4wIdcMnvesgHrjlbKYHgPBb6KHzuyf Mr+LX/keb3nuA== Date: Tue, 9 Jul 2024 13:28:48 -0700 From: Kees Cook To: "Christoph Lameter (Ampere)" Cc: Vlastimil Babka , Jann Horn , Tony Luck , Nick Desaulniers , Miguel Ojeda , Marco Elver , Nathan Chancellor , Hao Luo , Przemek Kitszel , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Guilherme G. Piccoli" , Mark Rutland , Jakub Kicinski , Petr Pavlu , Alexander Lobakin , Tony Ambardar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [RFC][PATCH 0/4] slab: Allow for type introspection during allocation Message-ID: <202407091327.AEF6C020D@keescook> References: <20240708190924.work.846-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B3F6E40003 X-Stat-Signature: jxi6djutiqb8fhzr9an1dafbgcmgb9bb X-HE-Tag: 1720556934-347807 X-HE-Meta: U2FsdGVkX19A/U9BH4S+kuBrBVB8cnBaShSs3rud9VnGm6Jgu3LF5GG2kboIASPDMcEmK7686wJKBSUXFVo51CKDQ5jpwOJ/j2CVd+25edZa8i1ubAVOHtFdxFzytZ4TnZgiizn4NvMo3tYgCFYaBgdYPOwDc1jJoluUblY2mZlYNZmAfUNQ6Wu52akczQZKxP0Xp+rDVT/ZOHiDPMu0uyZTHG9J7VVmEw2X+SyrwF6IRkY7sOLSiJOtwWd6uwaNC0yheFZ4+hu+QCqjOg24CG287XrHos7MNNc6dx41K3zAS6p6pV2tKe8WPyGv2274xASdRXMPp2fa7drKgU7LLWq1X0pEbqRZ4GPj7oKLW5I7+ARCIYvG7XpUhRcT/88k+X6BsEmSN29MQHI8iklWDy/zCIcYcMu1Rj1WdpfIw8KHw7f2+gBy0JrVt3MLJf8KBa+uNfGce40gLBVItpSI+6nw+WZnKg8Jv98OUuKlxSSzV3SUMF3zJt6S2SKiMPWfo34LfSXO3BcPHNP8OdNYeL7gEF3/USz62hwUj3W9vKuhLAAUdWdBff9tYLGD6JEmKrzZWDixB/5G8Mz2VDOCVX7nr14R+nJqz19sqZGftruQDMYMVkeJ5LLTtq7dSvCxoACZY0DZE7F8ppa85LD9vrJBeKQirE5dOKifRudYM9GKYNQavP+HagTz6iOKOUK4xDswh45ifCWZS6fXx8VbJw7PtQBMleo3tU3Tl43a5KMYZ9HEIrJhvERqAE218J+bhShuUiJpeTx+cHRdsMQ3OOkYLxjXmi1RgDkZp0juM7WnrJoGPmSLJAzrniq6lpYbk9SiWonC0mnzwMIpaApmgI0Jn/8KaVs2Jsd3/SgElZ89Baxa/uHDDnbrIp9yPcbCGngJH0/Pnf0cKSvftqXqSKXOy676yjkq3ms5yFEQyZVDxChyZzWXvV4HfTqJuayshd4KjjM1wEqTcv48PNz 12sbI9Zp OR/GuyOa2M0UsqMf2NU06N7kKPk3B/UOmKAj0gbiL81xiJIQ7qgv0hyxnST1QPyp3afA5hfAU7QWBhZnjEJxtOSOvIWhR8OrPyOgy80xf4YGDSCc5R+B5k8nTCCRmtvOZtowmXerphzjBlYQEuTPvUGJ2XtI01gQVGbN+i/JwLf0VzVpoSeJiYDpBF6a4jjldTan0drW0AarYp7CI/SzHik5K4IEZFDGe//fLClzJObUGBU8CuGx5uHsRqKGSAv0MjawNBxnH4J6JT58a9d+7BN2pCsHX6vezIyZq4zOKZFSaNQ0s3TcT2fTgClOVahvGOJuB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 10:26:32AM -0700, Christoph Lameter (Ampere) wrote: > On Mon, 8 Jul 2024, Kees Cook wrote: > > > > > obj = kmalloc(obj, gfp); > > Could we avoid repeating "obj" in this pattern? > > F.e. > > KMALLOC(obj, gfp); This appears to be the common feedback, which is good! :) And we can still have it return "obj" as well, so it could still be used in "return" statements, etc. I will work up a new RFC... -- Kees Cook