From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D58C3271E for ; Tue, 9 Jul 2024 03:00:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D03386B009A; Mon, 8 Jul 2024 23:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB2506B009B; Mon, 8 Jul 2024 23:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B792D6B009D; Mon, 8 Jul 2024 23:00:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 94EE16B009A for ; Mon, 8 Jul 2024 23:00:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 200F0A16A7 for ; Tue, 9 Jul 2024 03:00:38 +0000 (UTC) X-FDA: 82318711356.03.1C47D7B Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf28.hostedemail.com (Postfix) with ESMTP id 2E8CBC000C for ; Tue, 9 Jul 2024 03:00:35 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jVKeNm35; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720494013; a=rsa-sha256; cv=none; b=Z+EBaqCMTNcrJQhFsbpBtZhb96rlRrh0ih+YHqNz3jebWqo4MorRo6hMKRdWrlaQpXBX5C N1ngCfRXqO+SiEyPkLwbv4LtG8SOjwxzOoXtYrYsA5cXFxXoZnYMOniIre021h7bZeQJIg 2p5vagINK+1E4Dc+QV2pfz+BRy/V8gU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jVKeNm35; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720494013; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8rr83lZVphwTxFLirkUzTuGoAIzy7TcZPXokDzjVzw=; b=Vj+lHml7I3Cb0oWrRUihbERl06EFcu4wA9x24TJeDMtnAPUyI+a4J/F6LfG1WBaS0hySTa MhfxD9GAJWuDl15ykhJu/pC3Nlgzmgn6cNjp//WeHyjiCRpvG31lAZYO4OSvjCa7OGsTs8 U4TJVs13FdsBlR0n2yumU6YNfxiUtJ0= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a75131ce948so550470166b.2 for ; Mon, 08 Jul 2024 20:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720494034; x=1721098834; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=T8rr83lZVphwTxFLirkUzTuGoAIzy7TcZPXokDzjVzw=; b=jVKeNm35oDy6O3Xx3dj0tJdLiVjM1ioNUOZ0g3OHDPv0DnZIgRyFRFTQoW3JtK3xZL YrnAMXyOwQC7EpQ1Gyw9BPlESsqlRhqlY64I+E0sbm7rurC1WaBSp4PYUdaJc+Oo3oEt NRlxda+heKltjn48NH/I9PDOzCTZgZiJPnzOoUlLK/J2XmQZ+Yxp9Z7ZCjmRUDbSFSS+ RqQF1T50/b8C9ILApeKEtm8mSMS4IJ8xC5EQ7Poo8lpUiZR+m/eW1/cMNXtsNmlLITTF UM6oHuMxzcGSRC3Y3hJY8136h72vbZegT7ilWCZHrwNMaB0fGGRotvttq/kn8BLKTNup s4Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720494034; x=1721098834; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T8rr83lZVphwTxFLirkUzTuGoAIzy7TcZPXokDzjVzw=; b=viQiqSiTXd3ImsuRUubQFl84uk5Hmdg2BKOEHV9gdluZTVcDXL5AFF78Bs9odG+hqA 8uKxOY7YxzpjWVEhtbSB76O5XGan60lgKcee0+rXNEWm0Fbzscqv9OvKYQ0rxGpnmJfg pea2ZP5XD6C+QGwQ2xCIt1bShSwaXkODwMIhBRecEXLin62ODkpPtR5ZVdK3GjVxC/6i ocXb5ZA8SWcswQqy8K13Gz9Hk4VPGlXC0cgCne2O9Ki7tiE0yZUg5DksMnuIiz1RnHNE BfTj+Ec5KHU+fJ40ntjfU2M/GA+yJ+0z06wUB68fEzsQ8QsDzEkpV3E0vFyt0C80J0DE fvww== X-Forwarded-Encrypted: i=1; AJvYcCXAYQIRx0GzSsA0fQM/NjmxukT0VbPKXwu+/4CNpEGLowXWDxu08ouXh82tJTGhz29b4qwD3VtbBnNRJ16Wnzutb+0= X-Gm-Message-State: AOJu0Yzmmx9GY1+Cv/PdQ24Fuv5aIp0QJ7y4ZUFBW/GMRaC0dyKyvwiY nRl++HICPV7RtcVfcQXnCWQOr2MlZwgz9VgMuzdq8Nx77b859C9F X-Google-Smtp-Source: AGHT+IE0R+vGdyJ4p3l9ZIFoSLe8tZwIpF8TGtlTeXyIlv2ivfEq8KucIMF+CneQ5A5TwxQ5qYOH4w== X-Received: by 2002:a17:907:7e82:b0:a77:bf32:b91e with SMTP id a640c23a62f3a-a780b8848e7mr76289366b.49.1720494034513; Mon, 08 Jul 2024 20:00:34 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a780a7fef4esm40115766b.121.2024.07.08.20.00.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jul 2024 20:00:34 -0700 (PDT) Date: Tue, 9 Jul 2024 03:00:33 +0000 From: Wei Yang To: "Garg, Shivank" Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Mike Rapoport , David Hildenbrand Subject: Re: [PATCH] mm: use zonelist_zone() to get zone Message-ID: <20240709030033.xgtfuifkqf5ycvh7@master> Reply-To: Wei Yang References: <20240706015044.27789-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 2E8CBC000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mzebg3tassadm1yhmnqxd7xcdmkijnb5 X-HE-Tag: 1720494035-438328 X-HE-Meta: U2FsdGVkX1+2Ve0mZ03YKJZKVV5v2WtifBuUjNCrv9E9UJNenrs5YoRAPOdVv7iTMeU1I5fSgf+KmMd3LBs4qPbfTSEKs4KebDwndXOTivKU3jTmHMJZUPNtoE+xA8FVRnN4IVnJ6L+c8Ys59QhyW6xV8NnlvAuw6RjYhGtWoGJ4fr0Kc5HZSsZuMkCPq2K4/sVlj7MSOkjpZu+Rkh3veh59rOnKS5U2Djp3W39si0txRJStTE/ayTrdHMGieu5gqA0iheZSb3sBRPRyWkn3YXJmDMTMSYiHuSBq62cspe6dhbMQcB7T6TCJKuAf004xwgRA7AOfeogtQTPMSEcn5rH8p+bXxYsIKSeERnGGxM/QygxiqDjeP5aYiUfj04AJ+7IKMJTyf67DO+P7jqbATxFGthjW+z1SURePNLNAF+F0U2XEW4wqF9y6eLOyzsJQaSXanvFG5iaJAQAkgrKeGBmi2CryhTv4o0raF9eX6Qq8lKejJ+grKj2wv5+hNKtprEF4KnoCdVpkTZs/0IxghTuA530A3Z5dIKVgpN6W2hNGQB7GEVRVm8S80nZrV/KIvGL64yNfbL6JgEfQYy+YfWEmej6q/DzrwGSBhJ848sztXPGqKtf+g+5uUXM+bLgY518xpldENrw7vllQ1Nqz/gaoIkCgPUW/CdX1SWPbly21XQNQbDstECHWjwiowfVjCd4tWusoDGZWrmRPDWFwvxDeZETPdBgDhfR7LlR08witSUMiFU7PZO/ZjMR7wuinmldopKea3gz3yrbdNVjpG2iCAH+VH/u5CEqNL8Ij8S1WCAe+2GwcEVwsqBv2zh7nQ8V4oAO18E+cusX9Is61Pu/A+j1vHrdNTTHAcoa/+5m+UMqqUNP4wK5SqC1bP0X4ekW247dOY0e3Dc/v24xDN7B6A0zTTcG/D5ZqMdFZ+FqP4dOBWZAAfJbedGFFr8ah/hwR5ZfyinFYVxtSCJh ErYLjGl7 PRVY66WChZwFafWcUO4fZXB88ulkf8UU9LSD0v6ez5rHf8MUFFF3T7cxXxH3oxBm74dbO0EYVXQb+OCUmxfF/dErQboBUqTDDU6hZlCtFg+qY1wI0r5UGJHl6YPwWDhQF36Cro7Uam6DoVWEuY9LXQX9u2OY7oDuXz9x/Gs/giVhAnA+oEy1Pcr8bYTESLNS2EH8l6+RBnGnk3Ry/ZsYczU4LmhuK2QmbL5qlKQiaQkWzfC95lRvGrhYeMY0uWsIqlM/tw+AQeYr1GYo7zXLnT6mKhROauriWKqEb+/2DcQTyqyfIb75HQWJIr8vKZrIliN60ejVO8kPYaUFZ6tetvjn6byOPaW1HZ2XIP3uW5KwWQsQon6wfN2uDyGaMN2z1m5pXftDKB0raR277ny/fGrHgHowYTtagYozWdcMMUisk/w5QDgwzN8XDlbEqvTaydM52NVIOMfIyn2CsBn62zUKSNUaK3tdeggT2CfG3VkAdrsqYDtAfkTErITuTClWNprIYg/m1Pbn1YIXd2lrX6U8Xx1tUnRjNtfg4vL7DvaUJ+SE4GsCv2KprH7dvZokBuOz0S9Cwsftc4Ad6KXvDCCnZ/onNAsmx6BzmtcdUGYKhY+QmP9qSM+JWZ4V/K3uS3kWfBu3qot4VYFm1b4CuDQeDEybGISM1cB3Olc8kkzVq9migK5rjmVf97mJWe95zqhyNqjxVhP6k1sN4w9IE6EiABa7QtOFw6Utki/lMNhiZslihuT2wZHsAzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 03:00:50PM +0530, Garg, Shivank wrote: >On 7/6/2024 7:20 AM, Wei Yang wrote: >> Instead of accessing zoneref->zone directly, use zonelist_zone() like >> other places for consistency. >> >> No functional change. >> >> Signed-off-by: Wei Yang >> CC: Mike Rapoport (IBM) >> CC: David Hildenbrand >> --- >> include/linux/mmzone.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index cb7f265c2b96..51bce636373f 100644 >> --- a/include/linux/mmzone.h >> +++ b/include/linux/mmzone.h >> @@ -1690,7 +1690,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist, >> zone = zonelist_zone(z)) >> >> #define for_next_zone_zonelist_nodemask(zone, z, highidx, nodemask) \ >> - for (zone = z->zone; \ >> + for (zone = zonelist_zone(z); \ >> zone; \ >> z = next_zones_zonelist(++z, highidx, nodemask), \ >> zone = zonelist_zone(z)) >> @@ -1726,7 +1726,7 @@ static inline bool movable_only_nodes(nodemask_t *nodes) >> nid = first_node(*nodes); >> zonelist = &NODE_DATA(nid)->node_zonelists[ZONELIST_FALLBACK]; >> z = first_zones_zonelist(zonelist, ZONE_NORMAL, nodes); >> - return (!z->zone) ? true : false; >> + return (!zonelist_zone(z)) ? true : false; >> } >> >> > > >Hi Wei, > >I'd like to propose extending the use of the zonelist_zone helper >function in several other locations. > >I've identified the following places where zonelist_zone could be >used instead of the current approach: > >oom.h:58 __entry->node = zone_to_nid(zoneref->zone); >mempolicy.c:1956 return z->zone ? zone_to_nid(z->zone) : node; >mempolicy.c:2805 polnid = zone_to_nid(z->zone); >page_alloc.c:4205 if (!z->zone) >page_alloc.c:5285 return zone_to_nid(z->zone); > >I hope this will further help with improving readability and >maintainability across mm. > Will add this, thanks. >Thanks, >Shivank > > -- Wei Yang Help you, Help me