From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C33C3271E for ; Tue, 9 Jul 2024 01:03:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E0726B009A; Mon, 8 Jul 2024 21:03:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6900B6B009B; Mon, 8 Jul 2024 21:03:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 557F36B009C; Mon, 8 Jul 2024 21:03:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 383786B009A for ; Mon, 8 Jul 2024 21:03:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AA6F41C3365 for ; Tue, 9 Jul 2024 01:03:24 +0000 (UTC) X-FDA: 82318415928.09.8A371DF Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf03.hostedemail.com (Postfix) with ESMTP id B561B20009 for ; Tue, 9 Jul 2024 01:03:22 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Iu2KzNES; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720486973; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iFO55uxdi8FRVhzNa7rRusXHfIz8daUjQUpq0icE1SY=; b=ciAdf3G2eH48LrLOSrMUiUgeWqxUUVTaXWLcrSdQlcYdEV8bbRNLSd6gimQxh1e2DyO3dV N6yKtTxUILFUIx7LuKiuN2uECTn4S+wYVDl2TzIYrTttqC0knuumGaQ9NqtnHw6sGx7auF 2NWHYM2oR6ZrOMIiHWmctaEJFf7Cb+c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720486973; a=rsa-sha256; cv=none; b=lvwI9UiaxPWe+etU9O1UAR0rUZQeFYa/onxYwkVPPIs+NHEYnHaieux82VEGvJya9GpqHJ X4ZJvXkVJiv+yxgrz+R9tAg2h+rJvLIe9Sf+HZHNkwTEs9T6TOr+kBClkBbSkDTK2nAPox NaNVS4PQcsX2pXGY0BmgDwMHe2FUzEM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Iu2KzNES; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2ec61eeed8eso55049491fa.0 for ; Mon, 08 Jul 2024 18:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720487001; x=1721091801; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=iFO55uxdi8FRVhzNa7rRusXHfIz8daUjQUpq0icE1SY=; b=Iu2KzNES55XJEbnifdspX8xJ2RABODPFQd1GmG9oJhzvE0hFcuQrSkPax7OqVIGYAe rJ2hyd+W46cen4We9nm4zqzKsln1evzkVp9QGfcnQtq8fuLGFu5EpPK01SgkIUS+1KJE lPQJ0ILayZ+/K/xybAX//auvSoF1iBbKz1P4+ZwDWwfErIKmV639Va62lrDBWiitC4M8 2zyu+OB5IP4N2BputjG34Xp3xYFv3PIzMSSic+Z4gPb9x8G1VJ1HtE4ZaD8NVBZvqPQ4 tuD0qDKYal7bv2WNGpnBpWSkKZT/d9e/KRyS+MRwJhgsnOjZjjKSupRAgyyrZguOPMJH xH1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720487001; x=1721091801; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iFO55uxdi8FRVhzNa7rRusXHfIz8daUjQUpq0icE1SY=; b=kZFGPFhSytSfcaTaNV4s52I5gP39kCuVRgD2kZEvtJk5QPdi5lnI7zpvbvTP1EEt7w 1YvyFgmp1PhJh+qnNRLnN4BEUL8l7/IJHMXwv9KKaYv84Z7bBYrcdtbgFG3MXCzzqn1a I5/xSIEbPloZgjCqL830wGCNLYv6C2QupF1EwMkMqRTtSpIyHogJPC730nXHiThGbsUC Cv4kPXl/tdSyOu05pqAfNmudPetzq78d93bIZqBdS3Py51h7ioi69hLRK4jTj/8WR6Fn 3USjWzNKGClRy/M/YutsSuNQqUlbXIPA1qR2JbdPEl/AcHZHSqSgTjTh21R2+jkLcicr HLWg== X-Forwarded-Encrypted: i=1; AJvYcCUWsyaAq3C2Ll1xD8FwEAqUGO3Cmo8IaFuYQYpIM7jNVZQYNvYMVprXDKbHa0CTuq5DtobzcZ5Y3UOa3j1nL1HPLs8= X-Gm-Message-State: AOJu0YxQIozxTV6Kfz9PjvZGsyx9/r4tQchb8ENrY174jcVPGYk3efkx EcrEgS5RnLIbsWRkoTlH6hTs5rgT6zY7ApcQMDs6+rq7ciP3C4hxcI1NNvoZ8fg= X-Google-Smtp-Source: AGHT+IGfSsAqjNtOUpM4VVF5QwRLL78xs/D2lW+2NQL//NMV7n0myPbPXpX+umYlGfSbQ5qvxqe3wA== X-Received: by 2002:a50:ee0b:0:b0:58d:836e:5d83 with SMTP id 4fb4d7f45d1cf-594ba59f8eamr535289a12.22.1720486579362; Mon, 08 Jul 2024 17:56:19 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bda30f0csm416259a12.88.2024.07.08.17.56.18 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jul 2024 17:56:18 -0700 (PDT) Date: Tue, 9 Jul 2024 00:56:18 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, oleg@redhat.com, mjguzik@gmail.com, tandersen@netflix.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_free_pages() Message-ID: <20240709005618.a4uvufvnledd4vb5@master> Reply-To: Wei Yang References: <20240708010010.32347-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: B561B20009 X-Stat-Signature: h59n1uqzgsuuned6neug8c53i6pep6jn X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720487002-962604 X-HE-Meta: U2FsdGVkX19JZMv7ByYaeJ3hCwuq10ZnyslshPpHAaAx4LhER4FQg8c7sAyr3NagQ9IS5iH6tMW5JnG0KX7van337mdphIGgkFVaFQ+Sr1Xz+Mkp+sXlkmRhjY9uXZKFPXxlqklhdQJ8CeHVg7vBMto4Sx55tZAgohToVMd+UivxkQGZWgfawD+LWkck48y0uQ4HWTIXjpISRp7WM53JTUdxH6Hj4Fnn37DeKZh1RxCC2Xp9LMuYF/6r7XX5v36vVtxYWU0xamKg9DRJ5a9CmC0J6h5ojpBFQD9khJBnDo2CgvUpnRKbjWRruqoH9hukFLIRzpYvJIoMeIygWjpcxkGYku7Ze1fvjH4yWL72SurL4HS+PD25hIvpP+g7cgnylQCo1PmoVQlgMgLPiM+yY4WMopHYU6bdukaAr5ZCCld/J55vb91AWyn7Mdt0fxEKEf4BuOKReKj1/tCMGClOS4LigdxNuAoB1n+4fmvg/SsWoQq/cXdHHKFPLiI9t6l27KWFIvxiWB4+NcN5v/Jxej1Jerd0iZWjuBEOkcvclzBCdQ52HpEzViyjkiyd3+N598ZZukvFdV0uVryoeO34JD+nnNB6wg9leYYgJq3PUWknTNt3ZYDlP7Hg7oE3zsW3hopftIw3gmkWIomae7Ynl+2ZvXOyU9znkQEJemq5aFPAvxOkkneneCptMQCePGXDjHK65Zmljz9MXt/8UVmFUHtSynyjOuz+QwY5YW0ibdEN1vMTEjoXzYcmC4QIoROQgy/j6zxFCDbbYUKisqBOQ8BxchChkwAlBF+/TZTDhmZRmcApdVM1dCiPV+SZKgZYyTQ67xwC9LO7Zxl0QGJirdukkvjHzmVCYl1Z0pvUai0rWBZF33sGPT6vy1k7zHglsw+FF/jP3Ozj09y5xmpEU4nB5zPvpb2esHaNQ+tfy9cmCYC6D4ZJpK8EDgVDvrWV0hxQKY/GBmpGwI0fpzS r9E/5ERl +x7Ts4A9g1DuvHa3f62awNsgXQ5Ipib1P4VoP7E3l3qE8xO/os5NXbtnPls2NGAoYjJUJQq1qsMZN9BQ0zmT9I8S3vepFBqMAz6ByL7kPKUrh3rVkFDFfCIjufOYGLJZydMd36zSRTQMk5ETrlD2pd0natiiNi+R3Kpfy4uiMl8H/q7Cfw9pbHrSOoPTnBnBf878/r5dAvMlBQQVzCKifY9rS+GIfn+vIkZu/jRtc6G4K9Un2QQTiKJ8furBPBT6ud5EQxz67ltJV1IT964FGQXyh6dlKzEQ67XF1i6mQHZAxrEu0TaZQpHIoDHNm2l7BGQOr2hEdLVZnchRX+GSleqDSHYW1ckf3fGccuK0avnBS8K4Xw0gZ2x45Tw+jrDT1Zjlwifuw2Dd5wYEjTu3qCYX0xGDDBBCA8tLsKo/DZzcUKUkgUBKhaMUGFWPH3/PsieF8rzwB9CBZHnU7z7pR8izlXpSGNML1Q9cEv5vDl39zdEzYDAbZMwvYTYfI/IZyNil3rqtW9Ah0sUDk+vUR1PADQBVsTQfHAPowPig79kxrRBYcGbJDv86WkFk13Nw+h8RFbneqWyAnChECHzeTyytLoYIUn0xE/3r3x0dwVbc2aL9kQaR38bp4mnJ9LLBITsMEzpQSH1XqKPq0h+I5XbM2E53ZAu7smmfC0cF8hvT98uO0gH/va3k/OFQYQOXEsnbK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 09:56:21AM +0200, David Hildenbrand wrote: >On 08.07.24 03:00, Wei Yang wrote: >> During bootup, system may need the number of free pages in the whole system >> to do some calculation before all pages are freed to buddy system. Usually >> this number is get from totalram_pages(). Since we plan to move the free >> pages accounting in __free_pages_core(), this value may not represent >> total free pages at the early stage, especially when >> CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled. >> >> Instead of using raw memblock api, let's introduce a new helper for user >> to get the estimated number of free pages from memblock point of view. >> >> Signed-off-by: Wei Yang >> CC: David Hildenbrand >> Reviewed-by: David Hildenbrand >> >> --- >> v4: adjust comment per david's suggestion >> --- >> include/linux/memblock.h | 1 + >> mm/memblock.c | 20 ++++++++++++++++++++ >> 2 files changed, 21 insertions(+) >> >> diff --git a/include/linux/memblock.h b/include/linux/memblock.h >> index 40c62aca36ec..7d1c32b3dc12 100644 >> --- a/include/linux/memblock.h >> +++ b/include/linux/memblock.h >> @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void) >> phys_addr_t memblock_phys_mem_size(void); >> phys_addr_t memblock_reserved_size(void); >> +unsigned long memblock_estimated_nr_pages(void); > >^ stale name My bad. > >> phys_addr_t memblock_start_of_DRAM(void); >> phys_addr_t memblock_end_of_DRAM(void); >> void memblock_enforce_memory_limit(phys_addr_t memory_limit); >> diff --git a/mm/memblock.c b/mm/memblock.c >> index e81fb68f7f88..26162902789f 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -1729,6 +1729,26 @@ phys_addr_t __init_memblock memblock_reserved_size(void) >> return memblock.reserved.total_size; >> } >> +/** >> + * memblock_estimated_nr_free_pages - return estimated number of free pages >> + * from memblock point of view >> + * >> + * During bootup, subsystems might need a rough estimate of the number of free >> + * pages in the whole system, before precise numbers are available from the >> + * buddy. Especially with CONFIG_DEFERRED_STRUCT_PAGE_INIT, the numbers >> + * obtained from the buddy might be very imprecise during bootup. >> + * >> + * While we can get the estimated number of free pages from memblock, which is >> + * good enough for estimation. > >I'd drop that sentence. > Will update it. > >Apart form that LGTM > >-- >Cheers, > >David / dhildenb -- Wei Yang Help you, Help me