From: alexs@kernel.org
To: Vitaly Wool <vitaly.wool@konsulko.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
minchan@kernel.org, willy@infradead.org,
senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com,
Yosry Ahmed <yosryahmed@google.com>,
nphamcs@gmail.com
Cc: Alex Shi <alexs@kernel.org>
Subject: [PATCH v3 20/20] mm/zsmalloc: introduce __zpdesc_set_zsmalloc()
Date: Mon, 8 Jul 2024 14:33:41 +0800 [thread overview]
Message-ID: <20240708063344.1096626-21-alexs@kernel.org> (raw)
In-Reply-To: <20240708063344.1096626-1-alexs@kernel.org>
From: Alex Shi (Tencent) <alexs@kernel.org>
Add a helper __zpdesc_set_zsmalloc() for __SetPageZsmalloc(), and use
it in callers to make code clear.
Signed-off-by: Alex Shi (Tencent) <alexs@kernel.org>
---
mm/zpdesc.h | 5 +++++
mm/zsmalloc.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/mm/zpdesc.h b/mm/zpdesc.h
index 05def4d45265..06371ce60cd1 100644
--- a/mm/zpdesc.h
+++ b/mm/zpdesc.h
@@ -119,6 +119,11 @@ static inline void __zpdesc_clear_movable(struct zpdesc *zpdesc)
__ClearPageMovable(zpdesc_page(zpdesc));
}
+static inline void __zpdesc_set_zsmalloc(struct zpdesc *zpdesc)
+{
+ __SetPageZsmalloc(zpdesc_page(zpdesc));
+}
+
static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc)
{
__ClearPageZsmalloc(zpdesc_page(zpdesc));
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index d88602fb0233..7f8e02df4e3e 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1030,7 +1030,7 @@ static struct zspage *alloc_zspage(struct zs_pool *pool,
cache_free_zspage(pool, zspage);
return NULL;
}
- __SetPageZsmalloc(zpdesc_page(zpdesc));
+ __zpdesc_set_zsmalloc(zpdesc);
zpdesc_inc_zone_page_state(zpdesc);
zpdescs[i] = zpdesc;
@@ -1820,7 +1820,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,
VM_BUG_ON_PAGE(!zpdesc_is_isolated(zpdesc), zpdesc_page(zpdesc));
/* We're committed, tell the world that this is a Zsmalloc page. */
- __SetPageZsmalloc(zpdesc_page(newzpdesc));
+ __zpdesc_set_zsmalloc(newzpdesc);
/* The page is locked, so this pointer must remain valid */
zspage = get_zspage(zpdesc);
--
2.43.0
next prev parent reply other threads:[~2024-07-08 6:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 6:33 [PATCH v3 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool alexs
2024-07-08 6:33 ` [PATCH v3 01/20] " alexs
2024-07-08 6:33 ` [PATCH v3 02/20] mm/zsmalloc: use zpdesc in trylock_zspage/lock_zspage alexs
2024-07-08 6:33 ` [PATCH v3 03/20] mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc alexs
2024-07-08 6:33 ` [PATCH v3 04/20] mm/zsmalloc: add and use pfn/zpdesc seeking funcs alexs
2024-07-08 6:33 ` [PATCH v3 05/20] mm/zsmalloc: convert obj_malloc() to use zpdesc alexs
2024-07-08 6:33 ` [PATCH v3 06/20] mm/zsmalloc: convert create_page_chain() and its users " alexs
2024-07-08 6:33 ` [PATCH v3 07/20] mm/zsmalloc: convert obj_allocated() and related helpers " alexs
2024-07-08 6:33 ` [PATCH v3 08/20] mm/zsmalloc: convert init_zspage() " alexs
2024-07-08 6:33 ` [PATCH v3 09/20] mm/zsmalloc: convert obj_to_page() and zs_free() " alexs
2024-07-08 6:33 ` [PATCH v3 10/20] mm/zsmalloc: add zpdesc_is_isolated/zpdesc_zone helper for zs_page_migrate alexs
2024-07-08 6:33 ` [PATCH v3 11/20] mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it alexs
2024-07-08 6:33 ` [PATCH v3 12/20] mm/zsmalloc: convert __free_zspage() to use zdsesc alexs
2024-07-08 6:33 ` [PATCH v3 13/20] mm/zsmalloc: convert location_to_obj() to take zpdesc alexs
2024-07-08 6:33 ` [PATCH v3 14/20] mm/zsmalloc: convert migrate_zspage() to use zpdesc alexs
2024-07-08 6:33 ` [PATCH v3 15/20] mm/zsmalloc: convert get_zspage() to take zpdesc alexs
2024-07-08 6:33 ` [PATCH v3 16/20] mm/zsmalloc: convert SetZsPageMovable and remove unused funcs alexs
2024-07-08 6:33 ` [PATCH v3 17/20] mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc alexs
2024-07-08 7:42 ` [PATCH] mm/zsmalloc: fix build warning from lkp testing alexs
2024-07-08 6:33 ` [PATCH v3 18/20] mm/zsmalloc: introduce __zpdesc_clear_movable alexs
2024-07-08 6:33 ` [PATCH v3 19/20] mm/zsmalloc: introduce __zpdesc_clear_zsmalloc alexs
2024-07-08 6:33 ` alexs [this message]
2024-07-15 1:33 ` [PATCH v3 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool Alex Shi
2024-07-15 16:21 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708063344.1096626-21-alexs@kernel.org \
--to=alexs@kernel.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=vitaly.wool@konsulko.com \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox