From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A404CC38150 for ; Mon, 8 Jul 2024 00:37:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1834D6B007B; Sun, 7 Jul 2024 20:37:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10CFD6B0082; Sun, 7 Jul 2024 20:37:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC8BF6B0083; Sun, 7 Jul 2024 20:37:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CAFBE6B007B for ; Sun, 7 Jul 2024 20:37:04 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3745EC0FBC for ; Mon, 8 Jul 2024 00:37:04 +0000 (UTC) X-FDA: 82314720768.29.5DB6013 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf22.hostedemail.com (Postfix) with ESMTP id 3AC9AC0016 for ; Mon, 8 Jul 2024 00:37:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UDEWOcOt; spf=pass (imf22.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720399007; a=rsa-sha256; cv=none; b=imKDsN2/0PxKLEseiYzUKvsm6Hb0F/wKwOp+Ru9IjhrO3IU2ZDu7+5gbCeqhQkox7YEXoZ YDkJEEsL0L/q33tS6PgUl44kfkDHpycO+s5WLLLbkTzl4ObYkDE8AX36zn1VvoJLOmWVTW 5cvbfCroUpJoh5ugtxoOMY2VzKilAh8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UDEWOcOt; spf=pass (imf22.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720399007; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0maobCSW8jMDbFz8GUq2aphge1nCAKz/nFEddtGsYBM=; b=jPBXgaC8aNSVH8UkGRsR8ccomy/7DWKTQ1foyBmnIeQRrqfZCghjt/5UyAlZtOjbkHKV8Z rXEjmfCbwfyu+yGdJOHniNpCv/cBNpHv+zwwLxkEYHCncQnM/HjjOMULLzA5cR60+4GxkT XKf0U0QwBRqN+5273HOjrKCxUGGzzIg= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ee7885aa5fso36261301fa.1 for ; Sun, 07 Jul 2024 17:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720399020; x=1721003820; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0maobCSW8jMDbFz8GUq2aphge1nCAKz/nFEddtGsYBM=; b=UDEWOcOtnOqfIlm/uP0rl6ogeXqPTj9+DLgkhrx/lVuonKElbmVAuJTpLpnySQgbY8 ubMopnq6X+QV9hnNGhcdqON5jA7uDqSP3faVxShv6yOthxH0dJ37cRXzb7p7nJ4xqlbX IPuIts0ROmB9+GY2/1l2aKx8Za+qydigiUeopct9K0WN2FYdrfEmelVOEmzK8bczHfnl moHa/zXkS46//nI47XjlU2Yf4Pj8isCcwvxmoaS8mLj2z8rxbeudJecG3vEtw1DCqfpN L9RcV/XziOGUhN9/LYV3k/TIbbYM+6B13XQIsOWStAVDqNKloSbNxTqhBG5nhqLePi/X GGug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720399020; x=1721003820; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0maobCSW8jMDbFz8GUq2aphge1nCAKz/nFEddtGsYBM=; b=K7gR+LhbyYASHC3ay3tVwSyEF8M0+y7omb02U2LEbcwrh+LJtOOn4Zg+beqeQQ5Q0p NqvZH/ENjwBx+c2byWIq+bnYnw4aEaxI2unXFn2thGQhjiVkoukUxnFZ9JdVmwAaz7EP CIQnXIgJEC7lG2Z8yoTuRTPiFMO9pYxgUG8LpcWL1FS8fDCcnMWaRZChDEWJ71Qm1WDj /XgBtEV00rgLNIdA7O6m1ESvSkc6IGGKY/I7/UoZcg41UrDVVglCJz8EIoubIrB2LxKo sKMiWK+KGylmFmakMGinKz36IUidQvfiW5f/ot3FwdJnP23ULJ0ez/QTWLI2NfPp5ejs duEg== X-Forwarded-Encrypted: i=1; AJvYcCX3qN/OfH8uwF4xCp2bL/KZ1EJ4IPnpGJw/UyjORmHF2umQ0ZFgWs8Z43EUHTSVX7EONO8grjC/FgOBEwUKcN0jfDQ= X-Gm-Message-State: AOJu0YyOqauy0XVUIiTILaV3xWX4+G2G2pdYu8tM7N2VBOf1GfPlJ0y/ 3cY9qRL02f203d06PGkJSpJdgTAmXtTBDVpjvU4mBlSUl0NrYqyX X-Google-Smtp-Source: AGHT+IGvfoRCtahGcXgfBB0qSDli+0q4c6M0sTsmdYOaNTpy2n+v6qWfPqsOXrVP8DOoWe8kJoFCxw== X-Received: by 2002:a05:651c:2da:b0:2ec:40cf:fa9 with SMTP id 38308e7fff4ca-2ee8eda03bamr69533711fa.29.1720399020036; Sun, 07 Jul 2024 17:37:00 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58fbfccf0f9sm3245044a12.75.2024.07.07.17.36.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Jul 2024 17:36:59 -0700 (PDT) Date: Mon, 8 Jul 2024 00:36:58 +0000 From: Wei Yang To: Oleg Nesterov Cc: David Hildenbrand , Wei Yang , Mike Rapoport , akpm@linux-foundation.org, brauner@kernel.org, mjguzik@gmail.com, tandersen@netflix.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages() Message-ID: <20240708003658.fivcxqgwqhst4mip@master> Reply-To: Wei Yang References: <20240703005151.28712-1-richard.weiyang@gmail.com> <20240706012805.uuvysz2qgapgqj6p@master> <9f38e4f1-0ad3-4cd4-bcb7-5ec287859051@redhat.com> <20240707190304.GC11914@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240707190304.GC11914@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: x4aotri3odkeratqsitpkdzyh5p8tu6s X-Rspamd-Queue-Id: 3AC9AC0016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720399021-986211 X-HE-Meta: U2FsdGVkX19FNsRY6xZOq4mka7cG9VgKTTrWK/QIal2Zp0NF5bpurXQbfewkVzn5E2c9LJV9198KZduBMU1nZz+3KvgV9Ijr7IK/UldOrVz+bXwN632MQsISGNDpQJuj9UyQjwqOTwyAjcqRdk+f2xDyZFyV6+OgNELnjY6D+80oGpcn5IirnHVhJWZVtXmytf9+p8+oKerhVRzQorJNlNUGpe+yF0IsGaWjDXGqoOZHZXPtliyBtyQQ4TZBqyAhUvYTO6HOSwNOmSE4NFHzqVgMtlTo6VUro77LB/M7Q6tCP7qOhcQPA+pm0NlUZQpuoOTJu3QKec5mBAGaDZK6itZDMXOUwLeZu8uJGPiXPyej7+ABTynWkjLIsI4ZNVF1YXCm3n7X23rWFDh7i311AeX93TUsl5HPtITl4Lz2SCMSAdS5OvZYk2QAu3nH58qu33zheU+X6B0NTX9CAcMHxWP5FgJRfp/FjNMjidNarw7sTIFVpGlui5f4zM3taN5zZA2ucC46UoKAuk4HY1Z78QBN9RGlS3nDDDCMO8ncJ7cj2gcIEEfOGzcCHwpd5+72IqzNJExmC5BE5JNbPXzBud2zEaA+d9GGftnNVVsqEKAQgCatTHgKWr4CL4Gx4z2huvfd1buF5ZHb7MyJvZrwWVr5FQ7Q/n4gj66pnS1AyUv4iOofL8yfH3RmczMJCCUVeNFt3PHv127867cLyhg1HsW8gU6YTHRNeHNnGZ69osO0HOByTo/jtlEMgJTtg9Icjg3slHnLEhG2bduoX7kwozHDtzm7jhPnZ3qt5VPWaTmdW6wuxNorcKjzz5w2+xhMJUzFkNB7kpFaKycFEFz+HvtE2ZBdOr2uNmOGARn70cGjtXqG2sV1aYvokDcHPrkUQHQt8sNdCpuhLvQ0vhuEgDyeS83sebN5Fvs7EPlJRq27MGhH+zIES92nynf9wa9Rmk6XdgfNpxEWYwv6R/t w9OXdTpl 3t1jhzBzBbDIi5fBxrs66LaZQsR9PHvpzHgMpMegYO2i17LSjjQbePn/oaXuDZZS6HTYonG/G6v6+vLnIxUiUwIDvE/P/A+wLWpOuTZ083Xy7fd1aoI50rbyvYkLYj5w8MoXhcKS+xuUWpg7o1/IVrHt1uHQ4pIGAVtBfGd/ZJCtQgROL++G7OplUBJpOFVEUposZ1j2nr9EsNow9eGjDUDWvpwulTqDOhSCSKyGii8YFp4Tq95LpaDJUE7Hu1TPinA/YLbVRk3IZBHhIUVhRqV0ocbt/XoPgzmf3X9g9a4C1q74qi4VNCGwS67XRCYzmOhK1tGuh9emnJY/uX8rxc0lfB9mXjWhqhRZQKK7rlq6FjC01Sz3GKeyLr+wLN6vVtQIb+q3IxI/gWaNQdoAsDtru7QN662M9TJvbSk/TpP6DNZhqZcOUwVhAeKxM2n1gvZnI4Jz5K8UUhBISS262s+6BDnEUn4MFT9HoMSeens69/dioyBsmtqQ3491gXmKFoFx20AKIxJJdrvosPaJ1iKqaoDmaSmzkaAaCngEvAqpsPdOerHkIfygIT21I3KMaE6uIydRnBMSj+26c/VPXdt3THwzNPfxRDzoLpdq0/ipBn38DILTIhm7OlGB6qfR12YNXdpvgeiHcmFoQ8y4GFUB6+0VlJH9XkPOhOdCrtxIVOx9wYk4PycX6OsksPnCzpuJP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jul 07, 2024 at 09:03:05PM +0200, Oleg Nesterov wrote: >As I have already said, I can't review this patch. > >But I am curious, why set_max_threads() is the only user of the new helper? >Say, should files_maxfiles_init() use it too or not? Perhaps the changelog >can explain this? > files_maxfiles_init() is called in two places: * vfs_caches_init() * page_alloc_init_late() And in page_alloc_init_late(), it is called after deferred_init_memmap(). This means the totalram_pages() here return the real free pages at this point. So it is not necessary to touch it now. >Thanks, > >Oleg. > >On 07/07, David Hildenbrand wrote: >> >> On 06.07.24 03:28, Wei Yang wrote: >> >On Fri, Jul 05, 2024 at 12:09:48PM +0300, Mike Rapoport wrote: >> >>On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote: >> >>>Instead of using raw memblock api, we wrap a new helper for user. >> >> >> >>The changelog should be more elaborate and explain why this function is >> >>needed. >> >> >> >>>Signed-off-by: Wei Yang >> >>>--- >> >>> include/linux/memblock.h | 1 + >> >>> mm/memblock.c | 19 +++++++++++++++++++ >> >>> 2 files changed, 20 insertions(+) >> >>> >> >>>diff --git a/include/linux/memblock.h b/include/linux/memblock.h >> >>>index 40c62aca36ec..7d1c32b3dc12 100644 >> >>>--- a/include/linux/memblock.h >> >>>+++ b/include/linux/memblock.h >> >>>@@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void) >> >>> phys_addr_t memblock_phys_mem_size(void); >> >>> phys_addr_t memblock_reserved_size(void); >> >>>+unsigned long memblock_estimated_nr_pages(void); >> >>> phys_addr_t memblock_start_of_DRAM(void); >> >>> phys_addr_t memblock_end_of_DRAM(void); >> >>> void memblock_enforce_memory_limit(phys_addr_t memory_limit); >> >>>diff --git a/mm/memblock.c b/mm/memblock.c >> >>>index e81fb68f7f88..c1f1aac0459f 100644 >> >>>--- a/mm/memblock.c >> >>>+++ b/mm/memblock.c >> >>>@@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void) >> >>> return memblock.reserved.total_size; >> >>> } >> >>>+/** >> >>>+ * memblock_estimated_nr_pages - return number of pages from memblock point of >> >>>+ * view >> >> >> >>This function returns the estimate for free pages, not the number of pages >> >>in RAM. >> >> >> >>How about memblock_estimated_nr_free_pages()? >> >> >> >>>+ * some calculation before all pages are freed to buddy system, especially >> >>>+ * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled. >> >> >> >>I'm failing to parse this sentence. The return value here won't depend on >> >>CONFIG_DEFERRED_STRUCT_PAGE_INIT. >> >> >> >>>+ * >> >>>+ * At this point, we can get this information from memblock. Since the system >> >>>+ * state is not settle down and address alignment, the value is an estimation. >> >>>+ * >> >>>+ * Return: >> >>>+ * An estimated number of pages from memblock point of view. >> >> >> >> ^ free >> >> >> >>>+ */ >> >>>+unsigned long __init memblock_estimated_nr_pages(void) >> >>>+{ >> >>>+ return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size()); >> >>>+} >> >>>+ >> >>> /* lowest address */ >> >>> phys_addr_t __init_memblock memblock_start_of_DRAM(void) >> >>> { >> >>>-- >> >>>2.34.1 >> >>> >> > >> >Thanks for review. Is this one looks better? >> > >> >Subject: [PATCH] mm/memblock: introduce a new helper memblock_estimated_nr_free_pages() >> > >> >During bootup, system may need the number of free pages in the whole system >> >to do some calculation before all pages are freed to buddy system. Usually >> >this number is get from totalram_pages(). Since we plan to move the free >> >pages accounting in __free_pages_core(), this value may not represent >> >total free pages at the early stage, especially when >> >CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled. >> > >> >Instead of using raw memblock api, let's introduce a new helper for user >> >to get the estimated number of free pages from memblock point of view. >> > >> >Signed-off-by: Wei Yang >> >CC: David Hildenbrand >> >--- >> > include/linux/memblock.h | 1 + >> > mm/memblock.c | 22 ++++++++++++++++++++++ >> > 2 files changed, 23 insertions(+) >> > >> >diff --git a/include/linux/memblock.h b/include/linux/memblock.h >> >index 40c62aca36ec..7d1c32b3dc12 100644 >> >--- a/include/linux/memblock.h >> >+++ b/include/linux/memblock.h >> >@@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void) >> > phys_addr_t memblock_phys_mem_size(void); >> > phys_addr_t memblock_reserved_size(void); >> >+unsigned long memblock_estimated_nr_pages(void); >> > phys_addr_t memblock_start_of_DRAM(void); >> > phys_addr_t memblock_end_of_DRAM(void); >> > void memblock_enforce_memory_limit(phys_addr_t memory_limit); >> >diff --git a/mm/memblock.c b/mm/memblock.c >> >index e81fb68f7f88..00decc42e02b 100644 >> >--- a/mm/memblock.c >> >+++ b/mm/memblock.c >> >@@ -1729,6 +1729,28 @@ phys_addr_t __init_memblock memblock_reserved_size(void) >> > return memblock.reserved.total_size; >> > } >> >+/** >> >+ * memblock_estimated_nr_free_pages - return estimated number of free pages >> >+ * from memblock point of view >> >+ * >> >+ * During bootup, system may need the number of free pages in the whole system >> >+ * to do some calculation before all pages are freed to buddy system. Usually >> >+ * this number is get from totalram_pages(). Since we plan to move the free >> >+ * pages accounting in __free_pages_core(), this value may not represent total >> >+ * free pages at the early stage, especially when > + * CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled. >> >> These historical details should be dropped. "Since we plan ..." will easily >> get outdated soon. >> >> * During bootup, subsystems might need a rough estimate of the number of * >> free pages in the whole system, before precise numbers are available >> * from the buddy. Especially with CONFIG_DEFERRED_STRUCT_PAGE_INIT, the >> * numbers obtained from the buddy might be very imprecise during bootup. >> >> ? >> >> Reviewed-by: David Hildenbrand >> >> -- >> Cheers, >> >> David / dhildenb >> -- Wei Yang Help you, Help me