From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414A8C3814E for ; Sat, 6 Jul 2024 00:51:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0BC96B0085; Fri, 5 Jul 2024 20:51:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BB626B0089; Fri, 5 Jul 2024 20:51:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 883106B008A; Fri, 5 Jul 2024 20:51:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6B97A6B0085 for ; Fri, 5 Jul 2024 20:51:36 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 18A4E1A045A for ; Sat, 6 Jul 2024 00:51:36 +0000 (UTC) X-FDA: 82307499792.06.89E15B7 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf15.hostedemail.com (Postfix) with ESMTP id 19831A0011 for ; Sat, 6 Jul 2024 00:51:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iuSTWvH2; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720227067; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c7KFeV49gmhlyGls5y/8NCSbJCJFVQwXPZ0jtKuYPY8=; b=6Y80R+2Hw9Rq18Gd1kMRz1z/VWQK/tC+xcMuZ2//tnfnW2RGyN6JvA4tBEOuEH8e/P1wHv 2rngVAuPNnGsWWZfgVq23ZAkn33XYjrWyR6y3ehwMn6zwyHhtPTFR5zLwwWkuJ0knbohqq QVhasa5VnfsFalE0rJm/tg2HszJL9Ds= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720227067; a=rsa-sha256; cv=none; b=s/q6TJMU4Fsi7xWV6X9NdQa6y6mHXq/mnXzoYjx4ecl1Zdgrz+4W8XJuJDHs1fwMuNlNud EObsjUeO6y7SSlQBKgk4B8mAf2SLqKO4L4zE2xUG7w7DOv8jvfwPlWNyXQ6LGzHuoCdY3h 33+M8k+JoTWXFDmniQoSV2bU7iiBXio= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iuSTWvH2; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-52e9f788e7bso2262924e87.0 for ; Fri, 05 Jul 2024 17:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720227092; x=1720831892; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=c7KFeV49gmhlyGls5y/8NCSbJCJFVQwXPZ0jtKuYPY8=; b=iuSTWvH2NxuLSGDILvCeLVU/dZrQRljuhtofuYivYRPMlLT8zcuoPeTEfbZ96gcZ5U fcqL9ptbweD+pehaQd6HRu24NH0gKGmwzu5+eCyzq9wKFOQ0ET9RNFGzAOjgNCAEs2mP RBUdDJHg9JYT4V0nq+xebK9neRQoY+/AXBuNB0wEPxCSQC3ly3cS72yXcdJ+I5UNYdni BkjrrCPEMNkDMsEGzn3phBbaNazX5kfSh7/L/QVofXPAr96bNcau+p5lMT+Ae4i0ddUO Z4l5j0PeXJsDu17pQIXUgyn0ZaYXMB+io/HbquVvwI4/2a3HHXMKKKK2UKjw70CgX2OX V3ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720227092; x=1720831892; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c7KFeV49gmhlyGls5y/8NCSbJCJFVQwXPZ0jtKuYPY8=; b=HsoapZfgrf5AA6hpNrDl+dmnzZicLkT+uDkHgtedpxxmj0S1ODUpVo9VHXNohOuq+I pU6iCZqg5lf8RH2y13yeNGs7Gx3N6fELcqkMS9fXtwCKmrhiV2fnaD8vvRUVBXRkAUBF Nxt1P/R0i55wQxZn3IIA+QsBXKhzKM5T3F++caqeVoZF/eR/6sK9ncZVE9lXVbqAldAh Cx3KoFJ6sv/pq8O/a49TFlIjZw75QobvnmH/zmBJiFyRFBD2N/GJLdGeWGpkJXwgYlkM STHJvsF2HVF6tx62LmM5yUqSy69qqLw7vY3FkUWTg3/npzJIaZ4vP1l2S9EKjJegMW+w y1KA== X-Forwarded-Encrypted: i=1; AJvYcCX7uLtN/fNcCSqogiv7hBQKAbihiykygPxbG5yftZVj9nkHDxGoTaM/zBKeIXG4ULyCIVLQ7LBW9lXqP80e7EkbCfo= X-Gm-Message-State: AOJu0YwXI2CSL3x710yVUI8E2/0Z/M0Vxt92uKOV4exEFxRh0fuAKYzr jtN1Or710nanXktFWpQf4Ug1OgbROpsMO0p2HRWsAePpFOR9Q4QS X-Google-Smtp-Source: AGHT+IFRGqvMJ701guC7GxeWtW133Kfp9+soZJ2E5pFnQJRh8x6ffl0U4YWIQ7uCNGz8QcE+i4Af3w== X-Received: by 2002:ac2:5eda:0:b0:52c:9e51:c3f with SMTP id 2adb3069b0e04-52ea06b85a9mr3857483e87.42.1720227091959; Fri, 05 Jul 2024 17:51:31 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77df94db65sm33206366b.140.2024.07.05.17.51.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jul 2024 17:51:31 -0700 (PDT) Date: Sat, 6 Jul 2024 00:51:30 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , akpm@linux-foundation.org, masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH 1/3] mm: use zonelist_zone() to get zone Message-ID: <20240706005130.fvxwrv7joshnkhej@master> Reply-To: Wei Yang References: <20240702234008.19101-1-richard.weiyang@gmail.com> <30bc19a0-4cd3-420e-92a9-7b3c97d6ad2c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30bc19a0-4cd3-420e-92a9-7b3c97d6ad2c@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 19831A0011 X-Stat-Signature: r9shbzr64wcwqpj8exintwey5xe1fm1t X-HE-Tag: 1720227093-176236 X-HE-Meta: U2FsdGVkX19AIvcPB57gp669zgcbzg/neQmED3Dnrtybw87X1JXZUCeHjsFH3OlZ5SBfB0CowGXw8ZBerXA/N+7Kik2Tno4ATyx/uS8YphnhkFldyzVFIyyD/FDBgTvXnZ3Vd5hbmQTLEg+JHE8il7kbPKhiiCke/7hv14Ay0OWdSVUe6PC2sFeDFq7ccs3IbZxM8lRCac6dcUY1zV959D8RprkFH6Z6QOknvJVURuQwJEAaHEcHAl/bE+lh1Aw0ghyqdqXQJbJPf9zBmi/lJgxDfxlul9Y/EBoCtkNem0aZgfoIDk5oPCn/+HDjGiYfq3aaKnJ/xLmyomHti/E/WioaZqugAqpTg2TSmiE3OMVmqHMqG2NFDhhY3RdkIQzJUveS4wGrszkiSiw5WP9HQFdI79bPlB0jSWz6BS9Gjbwt44+gSmN3Dc6lQKV43CW7zOmTlNI5slKo/4UR2nPr5FoaroGFpiYLTtVUYE+F25G+aVJyzzpgpw6FJhQ7MI/ObyvsWe+d3SGPEiCL2mK6Z9wSUc7riHHjBqo1OufAgCUyaREgjzGeOR3AeWGz7c7/pWlvaKjWzgOGWoJAQBnNj3ccIr9Lq055BtACJVdnU6DpQG4SSnRZWaAvkyWcffxkuM2skjD/YajNX1prrGR8DiQRc0NHdWcYaLFcfBbH4/TcUSDkGJpAJkNJv04BweDXWdJt2RanUohweCbvYepS3m2cgHnn31vPw4XAVW1xZkOfucBFRbsAG6Yp6pOM13xHD0JFmQZ+2jJxSIlo+NpDnZXEw87cUFqkj0WIH7BN4Cd2KK5iwmokqVPbXCWsQKIXgyAjYZ3RhcaO7HRERsN96zvIQUMyxI2oI30ktY7Jy7Frdqn6C3H82SK5ZxfbYnk4CEIlZI3My1aNWboI0rVj91sCybUWlT1O0Sz5kK2cIxLE7DazqYYPzVaf2omsWBZYQpJ5gTG50rKyAnmrjSS jckSVGzk w4Fb5wE7ugrNsjUrut43++8csXEyfciww/Ii+xRg7o/Yy3YcQThuB2W6jqmTl/TrDOd68kavomU+qOqeEaordwU0d2EuZkUUZkUIBGLggkTmo1xCqkWMEhVp+AP3wDpBXcXV6yrMt+9Jb4fwkrSk2UPIVMES9wHCheOD328OekXPFclyyNsvqioy2tuZtjTxZCdJauIoVKS/2z1lOVNpcbTwqnAq1CmYJJa3c+cxYWtBouFw3ya4AI493wOSKypReetDrpwRbp3pjVTJAwLWR11lrEVP8ZxCy1z9ZokFKUy+5pbTfS+xwAJWiBNAG/2X6LScWTxnvioih+8w0rLZvYuhxxqrnmPH3Hqor9GJAexwD9Z5TwBpRDASt1Z52Bd5uUdxbLSYe1jI7OY6U2XfH8qcQSMF6P54vTpRCs9MHmmzEuThSwwbYOsK1WYEkyKf8aeaxaeOhFiHX+9gSZUXnoMq45HOz2f8i/NGsAcQKeJxvyqYgepNaF/GsOtK5azkC7mY5nlIO+s1pnGpT1530/ds32kcE39H+p8dQUGW/BNrr4Cu2b95Bal3+83wMhkqOXxHwDSAL3NViS157cIBMO+O6tUl9++NmUXv4lVO2vzZcXZHVI07XO7fiA9VO3wuxRl7CTdL/ckWgyR14yeTb6Azl+MjKFYv5RnFPq7sCyUfDSnnaJMFUCQJME4Km19K2/aHjDq3wEmhkFak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 05, 2024 at 11:03:03AM +0200, David Hildenbrand wrote: >On 03.07.24 01:40, Wei Yang wrote: >> Instead of accessing zoneref->zone directly, use zonelist_zone() like >> other places for consistency. >> >> No functional change. >> >> Signed-off-by: Wei Yang >> CC: Mike Rapoport (IBM) >> --- >> include/linux/mmzone.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index cb7f265c2b96..a34a74f5b113 100644 >> --- a/include/linux/mmzone.h >> +++ b/include/linux/mmzone.h >> @@ -1690,7 +1690,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist, >> zone = zonelist_zone(z)) >> #define for_next_zone_zonelist_nodemask(zone, z, highidx, nodemask) \ >> - for (zone = z->zone; \ >> + for (zone = zonelist_zone(z); \ >> zone; \ >> z = next_zones_zonelist(++z, highidx, nodemask), \ >> zone = zonelist_zone(z)) > >Should we do the same in movable_only_nodes as well to be consistent in that >file? > Agree, thanks >-- >Cheers, > >David / dhildenb -- Wei Yang Help you, Help me