From: Wei Yang <richard.weiyang@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, masahiroy@kernel.org,
nathan@kernel.org, nicolas@fjasle.eu, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH 1/3] mm: use zonelist_zone() to get zone
Date: Sat, 6 Jul 2024 00:51:30 +0000 [thread overview]
Message-ID: <20240706005130.fvxwrv7joshnkhej@master> (raw)
In-Reply-To: <30bc19a0-4cd3-420e-92a9-7b3c97d6ad2c@redhat.com>
On Fri, Jul 05, 2024 at 11:03:03AM +0200, David Hildenbrand wrote:
>On 03.07.24 01:40, Wei Yang wrote:
>> Instead of accessing zoneref->zone directly, use zonelist_zone() like
>> other places for consistency.
>>
>> No functional change.
>>
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> CC: Mike Rapoport (IBM) <rppt@kernel.org>
>> ---
>> include/linux/mmzone.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
>> index cb7f265c2b96..a34a74f5b113 100644
>> --- a/include/linux/mmzone.h
>> +++ b/include/linux/mmzone.h
>> @@ -1690,7 +1690,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
>> zone = zonelist_zone(z))
>> #define for_next_zone_zonelist_nodemask(zone, z, highidx, nodemask) \
>> - for (zone = z->zone; \
>> + for (zone = zonelist_zone(z); \
>> zone; \
>> z = next_zones_zonelist(++z, highidx, nodemask), \
>> zone = zonelist_zone(z))
>
>Should we do the same in movable_only_nodes as well to be consistent in that
>file?
>
Agree, thanks
>--
>Cheers,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2024-07-06 0:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 23:40 Wei Yang
2024-07-02 23:40 ` [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY_HOTPLUG set Wei Yang
2024-07-03 1:52 ` Andrew Morton
2024-07-03 14:49 ` Masahiro Yamada
2024-07-03 14:44 ` Masahiro Yamada
2024-07-04 2:27 ` Wei Yang
2024-07-05 6:54 ` Wei Yang
2024-07-06 6:12 ` Wei Yang
2024-07-06 13:50 ` Masahiro Yamada
2024-07-07 0:04 ` Wei Yang
2024-07-02 23:40 ` [PATCH 3/3] mm/page_alloc: put __free_pages_core() in __meminit section Wei Yang
2024-07-05 9:03 ` [PATCH 1/3] mm: use zonelist_zone() to get zone David Hildenbrand
2024-07-06 0:51 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240706005130.fvxwrv7joshnkhej@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox