From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B47C30658 for ; Fri, 5 Jul 2024 14:19:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A6B66B009F; Fri, 5 Jul 2024 10:19:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 655936B00A1; Fri, 5 Jul 2024 10:19:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51CF76B00A2; Fri, 5 Jul 2024 10:19:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 345A26B009F for ; Fri, 5 Jul 2024 10:19:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A601140159 for ; Fri, 5 Jul 2024 14:19:21 +0000 (UTC) X-FDA: 82305906522.01.DBCB2FC Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf18.hostedemail.com (Postfix) with ESMTP id 7DA0F1C0019 for ; Fri, 5 Jul 2024 14:19:19 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=DLXx8XjT; spf=pass (imf18.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720189147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ebu8sK6BukO3lLURMplNxavYrXjjHfqDLjXeOhdJfo8=; b=fAzNqsTF/8zbKGB6Gctqv3URnplH2lmzyasnICx4a/J6wTsVDgr6Uqjp7tzjg/C7ACvNA9 9hdYUyJzNkeLMNF1WwOE7bIKhwb34Yo92Y0zsHFRVdrRcZdLbsnTuFRyMGraC6S9ZCLnbj gMAYdVURdeUTK02bJFDZyMuLob1Xpr4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=DLXx8XjT; spf=pass (imf18.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720189147; a=rsa-sha256; cv=none; b=EJ7xoHXxYoz2So+I3r+31dGE84QOKPqO1Ym3q05nHVGYP2hl3kfcUJoHdiJPBBNdKLXsHK LUoaclVLsA3ihXfKqab9KekJBwEYhXFkFE+IX0Zxje3Mt4Iej/ZsTExa7swd8kBBZoYGx1 OJlEHo+4t2+QXfGiNecGo2vPLcKUAWw= Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4WFwcg1fX1z9tGB; Fri, 5 Jul 2024 16:19:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1720189155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ebu8sK6BukO3lLURMplNxavYrXjjHfqDLjXeOhdJfo8=; b=DLXx8XjT6eR5GyEh/sIiJ/bGQZYBG9JVM2U9YTBDT4qkrAeR3bSKl960dXQoBGuK0b4HAq Ax6NkOZqbR9n3HLTsvul3xLXvyfTAW3JhHXRRF6UuJyeGVWW8MAfZa4Van79qm95jZTDBf XZIoc+kium4ipfHa5pdnpz0fuJwIwbJ4rWD9v4jctPoRRnP13RkrAaaCRnAEzF/UBybdU6 nNPMpF7ZsPGD4xc+2NdB9CugFZq44SN8rJzKco0FA8v9SoV5PkJesC3eg1Dy+D5rinO4gb zFfXe0CZcBblAfS7hXp9s0nvOzgzqnaIiuEUf0u1zj6QbADBDXgwgAMEUFRaNQ== Date: Fri, 5 Jul 2024 14:19:11 +0000 From: "Pankaj Raghav (Samsung)" To: Hannes Reinecke Cc: Dave Chinner , willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v9 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240705141911.zamclkk7iajcvwik@quentin> References: <20240704112320.82104-1-kernel@pankajraghav.com> <20240704112320.82104-7-kernel@pankajraghav.com> <2c09ebbd-1704-46e3-a453-b4cd07940325@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7DA0F1C0019 X-Stat-Signature: 3y5nud9773okzfwn7xpkjwea7tbt4hup X-HE-Tag: 1720189159-327393 X-HE-Meta: U2FsdGVkX182SSdARO875jVvZBa9MygEAgOsyFH/TZSAmJStjAxwRljF+9/AmWlr8B+ubwv8XlTbYu/FQz5SqnKxTpi+mHE5kTkI2muBWt1REGZLz27cgV5wJ33uudAq6ofJ/F2KXr/R03PzcYnUdxoT9WKHDCM7g6ZSlgb3cwh1rfkKGk42Jg3mu9gYy8Tp/ypl7AR5aLYq2UEJX+bCwirKsZdKpvCuy5Qy09QoRcg6pMPUthztnhBx2QTLGDNMD4LmUtGCofF11/nde981JVdw8I+vS2OvJmo/820+m/vwF4ObV6epaIoG0nc+ZNzBo4lfbzz3o4e7gHbEJxwROflxVVR3MknLEhg6pR+YNj9vPBfpT7JUdebI3QEX1Pu8joBhMB1o0ioyWSSEpfIOHCfQqtJb12spcOT2NSrM6TRpZZyow+RER0TStORa5vswkFL+/9DO/PuDags7KUnnjODRKAnW0glEkPBNYQ5Lx2SeqKNj8wZQisHWgKp3fIxAy53gmRPPe9AdAd2cj3U3DrbYeE3HE9D6gPJUped72tSqtGX8z0lb2RBcrcv1Ihz9xcZaJaxNUEY61wUI/RPaKEwHjHio3DMEUbDURJnRHnNqjIProXHGWgmSDxR4JgDuGX2GJKCA/bjRjHvd1L8Vb0mj6pa8a6mfLx24W94rongYlfsHB2rmD37f9pAcP0sAWgxDC6F/B6FCY46nSMxYB8aJpDS2XbqeAlTJrIYfmb1s8fxRSj8HlUEe6Tsfh/gnATGfYpgzpkPMIJyZWHugm7QGJrQkEgy7fuOvTkbtpGHoDKzOoYhD9Soq+r8xjmmRpjDtrTorcfsa5ER2HKeWAJO1mJY27v6Zh37S1MLus4KDVV7iPGDMKnsc+6X1ZajwzkNUxxUJbKOPGFUVTmtGgdWFg1D/Gar4ASRVl8kTCFHYe+OaTEzR5paRZvHUo2VERTeBLtfwQaKEKMaIap6 QrWjS85P OzF4mMtC7GKi/77jAH/K6Z+BiU54ELwT0/NTHo/xWBVl0AIcm3CgJQT+Ae2OKMxdMVe6D5gw58XytQgBKHJhGR+kpUUFh6/d8xB4TroFFTiJ191P4InWO36VzqaLRm2bYFlNcMA3kYtjGN8IEvZwju3T67/+PfNT0OLForYvtZH78LKQLV38TEbAz9+PlFz2y6O1tOuVI+dTFctRbSYcr0epn6VK912pnxzBidozgKsc/LFnEWYJKWUwaBRfzAn1tZAMmwzfe5b6N3Yh8s6oHxk6W8jF0K7PTlD3QYEVdD6H7aMo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > > > > There are other users of ZERO_PAGE, most notably in fs/direct-io.c and > > > block/blk-lib.c. Any chance to make this available to them? > > > > Please, no. > > > > We need to stop feature creeping this patchset and bring it to a > > close. If changing code entirely unrelated to this patchset is > > desired, please do it as a separate independent set of patches. > > > Agree; it was a suggestion only. I was going to say the same thing that Dave said as well as we are almost there with this series :) But I will add your suggestion in my TODO. It would be good to have some common infra to avoid allocating larger zero pages all over the place. > > Pankaj, you can add my: > > Reviewed-by: Hannes Reinecke Thanks Hannes.