From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE94C3271E for ; Fri, 5 Jul 2024 18:07:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B37B6B00A9; Fri, 5 Jul 2024 14:07:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18B5A6B00AA; Fri, 5 Jul 2024 14:07:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051806B00AC; Fri, 5 Jul 2024 14:07:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DCA8F6B00A9 for ; Fri, 5 Jul 2024 14:07:11 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 90243C02E7 for ; Fri, 5 Jul 2024 18:07:11 +0000 (UTC) X-FDA: 82306480662.06.07CFCC8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id D1606A0010 for ; Fri, 5 Jul 2024 18:07:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of "SRS0=5kbo=OF=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=5kbo=OF=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720202816; a=rsa-sha256; cv=none; b=EKu9k6S+Ir0hoNm4MQBbSWHemCDL1tpe6HjHWxsF38DwZ8WmPf+NpMwc0ffY2/1yf9hzUn 07VSVagCwilujkbZ/A1t9+mjy9ATAs7mej1bnaV+DXaMEyxUMTxahYFcuAIRQlLqLzLZ+1 tdzYdNz1ezz4HQPPS6Fm4gUPvOVNXKk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of "SRS0=5kbo=OF=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=5kbo=OF=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720202816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qX3d2V+Qhy1ViFPJbnsdf4CtIEhv4aiw273tGUlYCXs=; b=lmlef/UnaJl1dASbaeBFieTvVxrJmXg0W0mZRvdGDfOsH2QqsX7oM+1y1vhlcv9+ir8HCL InYgFFXx9lNguOSkbm5hX543vSq9cfJtVL/6//I+oQThS5ZbKOrkufG3Oox9Tuw4LWPMZP gByoxBnDvbWepYNPse+pDRO0/Ji3U/k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C693462C35; Fri, 5 Jul 2024 18:07:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1470CC116B1; Fri, 5 Jul 2024 18:07:05 +0000 (UTC) Date: Fri, 5 Jul 2024 14:07:03 -0400 From: Steven Rostedt To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 2/9] fs: tracepoints around multigrain timestamp events Message-ID: <20240705140703.711d816b@rorschach.local.home> In-Reply-To: <20240705-mgtime-v3-2-85b2daa9b335@kernel.org> References: <20240705-mgtime-v3-0-85b2daa9b335@kernel.org> <20240705-mgtime-v3-2-85b2daa9b335@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: ks8px7d7efp58qnrzxo1h9bkapc8qc4m X-Rspamd-Queue-Id: D1606A0010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720202829-258613 X-HE-Meta: U2FsdGVkX1/6EW82jzHmA0QK5d9XcjssV1fMk9qmjHjnp8F5E5Dm4VAruvBDFwQdcCiRmOJIS1YjWYB8QE6UaaV6xhzDwtifg9d6PhOHokG2mrgRDsS3jpw53MOaOn9mMBGPHYOzxYxX0/4YBKWwbJ9yatzKC/BrW0EuQl4F9UJHq/lLJcuAret5pnW+ZAjzs01PUFfd24Du7fdCDlXiNbVNBx/8rJ2Be+n5rfDpCVkESui1M87dY24dF+txvHJbFvBCtA4cSJV6wcyyhH3IEA5w0QokC3p+y1mKOGUZfgL7zgiWsE2NBO4hT2xlR3JiVFxZqg/O0k6hrwYHYAC7ZwWOK4jbo7VB7kNPu3MUDZgR/9bWzf0vKdixtPL2rymC1/63M9bVAYIBeHSdlFZw95ZHvLqrQDgJETBV3NR70xALmLRKi4NE+phDOaJKfDwBRpOoT0Y48+eI12y7CSEA1sX9CNm7KxmuTbJLTkZV6rKKCLhN7Saqx4aIa6QeMc0R/mcOcLEVc6kdvE6jkOM5vCBmEqi/yu2MmXfR03BhMVpgELZgQpElOdEcZY3xhKSlq6OrL5NPobpHO/lnLCFd2kenV+Fc/FVZ0PpP8pLV/CBtUyyzMjoeBvAnwbnxrfxyrnHS/u1lHsLWdP2vDSRkyukOp32QjDXnEDnwLw7sDc3ommKnREADya2CbExjQGxQK7yFjqiORkl8gnTbcV/4Pr9X5qnEZjx5P76EFW0WUn95c5yoGHNRy+uMohl+LdedpCGDsE+5bEb5lwtNW/ah4bI5LCveHyPtAiiAmRQVL7wWBocsccr2ej/fTsbS7N0N7h1szYD5AdVUPWHIKq+RQU5YOKmQcIrlnWirMYrFq31PbEc6qT1iwNdTGmlNonsKr7TkG1ONamOHsFDWLUhHKF3LKwJSGYeCII37UG7Ufyq/BTnBfi/XKEEhxOr6mFZRnYO7zRg9ViyDSP0LETB LHay7AMv eww6iydkDP5A4cGdSrrvdr7BmtcM2WXVQOo7x5Sx6/DxSr06CKG/+5UkNKGGAwWjKbAau7c7pdAynLuwjq5BlNTx0mIKqNi/asW9wnu82yCqfPgDNHXtn/Y2CScgE61y/vJbggR9x6MJ+IFER4MBrYgxsbUA4dLPAkKXtoWco1XNX6C54kQj8m0P+MS5dmEz1pRCXY7LwISiTUiWKN2V+zazDKazgHQkYiS2veXL7ZuHgkr1/iAReZcsB0bStxmChrIShzDJU43hYEekYnufx5KXO/L8KuIhuVRFY67zjBJddg4fMmGbNnV/IOxYt4dVzQM1uXba5N+/1WC6wgL9VJbvhVPY+8QLU/LEq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 05 Jul 2024 13:02:36 -0400 Jeff Layton wrote: > diff --git a/include/trace/events/timestamp.h b/include/trace/events/timestamp.h > new file mode 100644 > index 000000000000..a004e5572673 > --- /dev/null > +++ b/include/trace/events/timestamp.h > @@ -0,0 +1,109 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM timestamp > + > +#if !defined(_TRACE_TIMESTAMP_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_TIMESTAMP_H > + > +#include > +#include > + > +TRACE_EVENT(inode_set_ctime_to_ts, > + TP_PROTO(struct inode *inode, > + struct timespec64 *ctime), > + > + TP_ARGS(inode, ctime), > + > + TP_STRUCT__entry( > + __field(dev_t, dev) > + __field(ino_t, ino) > + __field(u32, gen) It's best to keep the above 4 byte word below 8 byte words, otherwise, it will likely create a 4 byte hole in between. > + __field(time64_t, ctime_s) > + __field(u32, ctime_ns) > + ), > + > + TP_fast_assign( > + __entry->dev = inode->i_sb->s_dev; > + __entry->ino = inode->i_ino; > + __entry->gen = inode->i_generation; > + __entry->ctime_s = ctime->tv_sec; > + __entry->ctime_ns = ctime->tv_nsec; > + ), > + > + TP_printk("ino=%d:%d:%ld:%u ctime=%lld.%u", > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, __entry->gen, > + __entry->ctime_s, __entry->ctime_ns > + ) > +); > + > +TRACE_EVENT(ctime_ns_xchg, > + TP_PROTO(struct inode *inode, > + u32 old, > + u32 new, > + u32 cur), > + > + TP_ARGS(inode, old, new, cur), > + > + TP_STRUCT__entry( > + __field(dev_t, dev) > + __field(ino_t, ino) > + __field(u32, gen) > + __field(u32, old) > + __field(u32, new) > + __field(u32, cur) > + ), > + > + TP_fast_assign( > + __entry->dev = inode->i_sb->s_dev; > + __entry->ino = inode->i_ino; > + __entry->gen = inode->i_generation; > + __entry->old = old; > + __entry->new = new; > + __entry->cur = cur; > + ), > + > + TP_printk("ino=%d:%d:%ld:%u old=%u:%c new=%u cur=%u:%c", > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, __entry->gen, > + __entry->old & ~I_CTIME_QUERIED, __entry->old & I_CTIME_QUERIED ? 'Q' : '-', > + __entry->new, > + __entry->cur & ~I_CTIME_QUERIED, __entry->cur & I_CTIME_QUERIED ? 'Q' : '-' > + ) > +); > + > +TRACE_EVENT(fill_mg_cmtime, > + TP_PROTO(struct inode *inode, > + struct timespec64 *ctime, > + struct timespec64 *mtime), > + > + TP_ARGS(inode, ctime, mtime), > + > + TP_STRUCT__entry( > + __field(dev_t, dev) > + __field(ino_t, ino) > + __field(u32, gen) Same here. -- Steve > + __field(time64_t, ctime_s) > + __field(time64_t, mtime_s) > + __field(u32, ctime_ns) > + __field(u32, mtime_ns) > + ), > + > + TP_fast_assign( > + __entry->dev = inode->i_sb->s_dev; > + __entry->ino = inode->i_ino; > + __entry->gen = inode->i_generation; > + __entry->ctime_s = ctime->tv_sec; > + __entry->mtime_s = mtime->tv_sec; > + __entry->ctime_ns = ctime->tv_nsec; > + __entry->mtime_ns = mtime->tv_nsec; > + ), > + > + TP_printk("ino=%d:%d:%ld:%u ctime=%lld.%u mtime=%lld.%u", > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, __entry->gen, > + __entry->ctime_s, __entry->ctime_ns, > + __entry->mtime_s, __entry->mtime_ns > + ) > +); > +#endif /* _TRACE_TIMESTAMP_H */ > + > +/* This part must be outside protection */ > +#include >