From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBBF4C30658 for ; Fri, 5 Jul 2024 11:31:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 542F26B009A; Fri, 5 Jul 2024 07:31:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F1C96B009B; Fri, 5 Jul 2024 07:31:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 394096B009C; Fri, 5 Jul 2024 07:31:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 18BBA6B009A for ; Fri, 5 Jul 2024 07:31:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C0E5381837 for ; Fri, 5 Jul 2024 11:31:39 +0000 (UTC) X-FDA: 82305483918.11.7C93998 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf16.hostedemail.com (Postfix) with ESMTP id D24FD18001C for ; Fri, 5 Jul 2024 11:31:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IjFeJcwm; spf=pass (imf16.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720179063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4tXpMesFOysqjQmdIZBXmi/S8232psTHkbVyhmtrB5Q=; b=DO3tRRoQsAES3aFnaOOax5ovC7uCznmtWmKwLcxTUCmU8DkumsRTllCfBoEU/6OJ1IAuoA rAuZQdhr0xyQx6oEzQmm0Lrtqsx2UUorzwNe+zO6IT6fmAXFKGmvz3kFzHGZpl391Ren73 F7lxXqJqfiVOzhOGQFwl1ltaz9qUDNQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IjFeJcwm; spf=pass (imf16.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720179063; a=rsa-sha256; cv=none; b=dh7kGUpHQhuvmU1ivL+AnF83s7WLn03Bq1Fb+JA4qhnxwQA0pR8QNcn0NMwF6TsYSO6y39 xzwwggCH8kbAfVmaHiLi+2NWwT2fs24GYeDBPDiOcLy8LMZzzO0ATpeE2uHAoe0lQviDo6 mGC5x9ibYO4rQd6hQLD60PA8t9N+Nb8= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1fb4fa1bb34so2602215ad.0 for ; Fri, 05 Jul 2024 04:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720179097; x=1720783897; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4tXpMesFOysqjQmdIZBXmi/S8232psTHkbVyhmtrB5Q=; b=IjFeJcwmqOU8agtQ4EEJ27acYBHUlG76L41JidxJaz3Of901OwfQI0ZMCz0ZUa/5SY JQE5C4zdkkXm6OBeCSqPLzdWfI0Lloxa0U1gR8lhISIt2vH4mnkGgkNA3BxSalsYMc/F 42Af9YtMOwUU9foIqCGbxDog/ptuQfxgfAsIowV2bFCP9Ghn5oBOh1r+ypOn3wrMfo6e gNbw5aXPjaNBw/tiio6UXqjNfid3ujM8CjFsKdJx1J+eUUISBVHi2pWta1C387UpGujb 1CsfPKpRyH8DLtC7Mru34/aaNucGSXXoy/5Uh8lrYVXD487A4KhSBhrht9+HpUzDgqfK 48lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720179097; x=1720783897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4tXpMesFOysqjQmdIZBXmi/S8232psTHkbVyhmtrB5Q=; b=CQJQkCI/DrLc0Pjw1yqYc+8oONNNkv2O1sGsb2MEY2LUnxqtePlInqi7iqxZdLcejK wgnyjJotsuP6xS9LK/fHKk8eeK3QFQMnAbaEXfnrffQVVfZu4RwmD2Tt/ZPwcL9/o+8c sK+901bCb887qutBSUp/9ThjBds9/ejw43eCRgPChoO7NAHVwe2T94XJE+PfmI2myPNw iA8V6jUfxwEEyfOhznc/PhtzzVS5PyrT+6onmz0o4a/pYs22pGmqJR/JbPQJq/Yp32n6 OxT8iAkIhD/Ll2u9m4QcR0O9AC8oiDWP1Y3nktzEhAVX3ONd73XtpQ+3SN+LcB+my35Y WDlw== X-Forwarded-Encrypted: i=1; AJvYcCU4HAh+qCyTgEbl7kNIKiQQbrsCDW5Vl9NYxU6BZHDmDWlBA3EO8AnBIIjVqOk9vRf4EXERgGf24MdTmlbqRewPRZw= X-Gm-Message-State: AOJu0Yxx5ymqU0XlvsEDLDZ2Cj6qyknSxelcLXszsCYRDic0Kz2xHYz8 dmJWc9vcZZhIv5gecZFBKhEwXNUD22d3q1wc5LfUDDFa7X8vtxf0 X-Google-Smtp-Source: AGHT+IETeKs74PjP9sc9Th/Pog9gWp8PldcnmgzKsxBrqPmYCfbWxc8MuoSqX2HCLAXoT528Vs9D+g== X-Received: by 2002:a17:902:6805:b0:1fb:3474:9527 with SMTP id d9443c01a7336-1fb34749830mr24634745ad.25.1720179096537; Fri, 05 Jul 2024 04:31:36 -0700 (PDT) Received: from EBJ9932692.tcent.cn ([43.129.202.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fb167c6a34sm49698415ad.241.2024.07.05.04.31.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 05 Jul 2024 04:31:35 -0700 (PDT) From: Lance Yang To: akpm@linux-foundation.org Cc: ioworker0@gmail.com, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, david@redhat.com, dj456119@gmail.com, libang.li@antgroup.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingzhe.yang@ly.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com Subject: Re: [PATCH v3 1/2] mm: add per-order mTHP split counters Date: Fri, 5 Jul 2024 19:31:19 +0800 Message-ID: <20240705113119.82210-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D24FD18001C X-Stat-Signature: c8pz3jeeqoydogbf7fbk6nqo8ct174an X-Rspam-User: X-HE-Tag: 1720179097-784421 X-HE-Meta: U2FsdGVkX19nHEbgRsa94PrryMcMMaZl03/31GzPXTJuhz+g64AWUEQ0+uzyjvyJCCl/i3+ypGi9mkuUnqmzFGQDwU/81+3wSvr/mGQGXottejBkC5pQXuW5LnY4v2atRKGlI3L6v3r6o09WAwUWjIbJfJxO23MrKZyviEGp0xDaWpcqxUKCDFdiHsoF/FYrwBbcMJmF4qPB6Fzrh4voTrKxmUVAkNVYtag/eLhh6jwsPutGS8Cih9ZcxSuvg6G2p5RPnETnw31u2z7ScJS0Tcpqv3SSUjufJK7oy+ueI1TTUqNZyGuRKcqfuVA+cUH6GMHYV/U2tSHGpcOLfo4fYDGmIz9hrT1qE1srs4H0JLa1naA+bEofKPl9mNZ5B/HxG87/zpJOxyTMlVjCLWriRKjNSUDas1g/PZmScpoI3zUY7zGV5TSTIrBQTyukpr/rITP0S0xSfhxzBW8nqUdBqcGy4Ebu704ZkS16DZrLnNmFX7YqceVMshyHm4PgM0XDLr1HEpgvYFa//Rp379ieiW6dgnfWGV0HvxGqqV46MIIpIAU130tiEKrnYv4WC50qLmXlCQ5Wiy0namgib+gU8tWsQd1/R5nGVXlUD8HoKB+NvR/E0/mQAbJuZTov7OLf2X5dvkeTXYit9furiZxrnzAYy9XlC6nJpdlvnqetRknB4wA0vbkxhbdmP9/doCQy0OuGXLPkSzoopn/WN6zTnQ+nVUHJDUzFtMOgood2MoImLRGqp1cK/PupoZsyPqB/ovRFZ712LdrYX93GXHPuokAdC57Yvydqsg/whJ+3ohSCc/BPaauh+Z/26yX3IWK1/akajrte5IJ52FdJwYzBgnfZ0sDjI3nEZYD98g1FVMka/Q0065xAbuVnbpjOejM1tdFOk9PT53NyS4ZPjHHqJFK5Ty9pxYMtwH94HUxoTbOxNOktfWvZJkAfCLldPlmSERRRpq9L5yDoBEiurJc BtzJABUU iuaXAcbUvjh8m/2NGKaRdr3TCeyeVio1xyDD8cmSohdYEQHnMb7nrWlYB9EcIyt7Z7gT75oZoSZ7SNS1Zg+HnAbE17OQJiHXy3H4Wj6ypwEq3H38dsCpuBj1T0tnDl0zlkjFdVPGspMGiuWERs2BVGIoksgmxQcrNLAbrDhufKpoi8ywN9WItLbn0UFUOKiNzcv/gb4NmRaVEbXz+AZCLZVA0ZIgQTzfdpLve2oKsAIL/fi/KvmVYkXq/PG+hxdQdN2adnyvrCW3pC9xZ2JILLCr536lVYhMSQBjmeufcGIh0lB7cqXrWqDGthYA2lGgW4CpyQxq2jf1mWyw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, Could you please fold the following changes into this patch? diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 993f0dd2a1ed..f8b5cbd4dd71 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3266,7 +3266,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, i_mmap_unlock_read(mapping); out: xas_destroy(&xas); - if (order >= HPAGE_PMD_ORDER) + if (order == HPAGE_PMD_ORDER) count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED); return ret; Thanks, Lance