From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3F1C30653 for ; Thu, 4 Jul 2024 16:48:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EAA56B0095; Thu, 4 Jul 2024 12:48:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09BA46B0096; Thu, 4 Jul 2024 12:48:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA4DD6B0099; Thu, 4 Jul 2024 12:48:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CB4E16B0095 for ; Thu, 4 Jul 2024 12:48:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7532E14143D for ; Thu, 4 Jul 2024 16:48:48 +0000 (UTC) X-FDA: 82302654336.04.ACE3762 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id BA69B120017 for ; Thu, 4 Jul 2024 16:48:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Iz1Qx73x; spf=pass (imf29.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720111714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hJCknN7oSaUMPxREP6rwGIXJRO+dIQ8kobBfL2ULmV0=; b=kEDEem+bVCupJ3WOYq0TNjXMMpVr/H1jlOEMQaUnjD87uYQkLzY5n2Rc2GSd3SasCYwrNN FrE8YeWBtpKUSVrgCsaSdLm2IxiVvdHB9/PehCpwLuQBw2N+ySgPz4thNCuzZEc/Z+pEkU FcWwIxRbsjOn7H9qGM9q/ASE2bVWOyM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Iz1Qx73x; spf=pass (imf29.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720111714; a=rsa-sha256; cv=none; b=PaO5FwCrqw9/jyLMNdXUZhWsF251G63F48vTF2+HhzTdhDmui49Um+ImuAGkcVcViBQddd gbGsrHWIodfvvOuIcHArnPaSEFzV+LeafrIH2zP3tvJPAaECJ3L/FhlUmSDRvO3v6VVfh8 lKTw58c+mSfnNn5levtiaSqLBsr1+oY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8D005627F0; Thu, 4 Jul 2024 16:48:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9551DC3277B; Thu, 4 Jul 2024 16:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720111725; bh=fws0HiGmamLZEZZjubszO9u8aqlHTHOAwe7LhWHHqWU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Iz1Qx73xmcMl1yR+IY4nIYNphQlCVh1WMzcNcBPEqtrbJPSqklaUJJbeIzn0jtSoz zNM3MW1SeY/SzjMB8kSkXkPqFqjv1RVRS/BNEcEY117j89sf69i0IrsJqyeRK+3Fgu DeSdr/iDtOWXvhhcqGHKYee8sHJCz3+2bVorgggo= Date: Thu, 4 Jul 2024 18:48:42 +0200 From: Greg Kroah-Hartman To: Martin Oliveira Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org, Andrew Morton , Artemy Kovalyov , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: Re: [PATCH v3 1/3] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: <2024070435-powwow-steadier-de07@gregkh> References: <20240704163724.2462161-1-martin.oliveira@eideticom.com> <20240704163724.2462161-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704163724.2462161-2-martin.oliveira@eideticom.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: BA69B120017 X-Stat-Signature: pzjocgij8ubdieawypgf89hw8ea6dobc X-HE-Tag: 1720111726-848371 X-HE-Meta: U2FsdGVkX1970aWb+icm07TI/ESKoJx2WSBEtzngYsVxYf2wGf3KzysMdGvn6QqsBjealHkdjgaXejv5iT61/yUfceUk1mJA+i0eqapOsAFow+ofZX6HeV/+J3WylsR+onf7yOCD0Gog/DypN+J2L9uZnRRDAWU42jF2EM8nt79DdspzK3B+e+M3P4rhMYw5cHVpGIO+p+hfiXxvq7p2tT4QO1dnY0DD841vB2ROuwfSHR5VF8X2T1JKR5/54YcW1vY4982ZjzYjn5klhl7ShaIDHdAY1Ni/rYFzj7WCmUyccoKPhbA9sLwVesBIFiLuQK72jRP0L0xK+W1C1UIk6NejGct5qzgGT+sXG2Ly+UyvG2DoHPjlLKDMbBoNmJgaHdtv8LbfOxQ43OfgSISxh3bt94QA0kzIdFwLtLFAEEkYtwiRgRb5NMTG0bc8p+hvgIYgoZWpBov1KYQZDVl6znaic0ntExvl4jsVCnLCunp0+mI9RkIS9/JNjbCyX6zV4BIDdzdXBqd4aSjauJ/5Tw3/w9ldgSHxwhCT2eJza2VwOY0N6/MIIeHJNNiGoV1FESvimV3WUQTPf+AhsVqh7LRrtFO4OSE2ajoJv31cPEF7/B1Vx9A1w1LEaxhHqCX7Mdy1S8jocj7jkSAT9aqT+ldDdlcO/v6H+RDnDPaZLOuychhimb7bmjyYIj1lXxJBTJ3j4mi/X4HZc7meKVy1ZYu5H8t4lefSwh9B7RCIo5xOfeADp377hBmX8tEcrHO/EEa9jUCSL8SqRmofxhpXKQ57RWpWY5lgwszSGi3cuFnRKKEEYn2Edl5nm8Uhz+yEhjuZYv1il0JHMEYhY7zXV189/jo1VNRpMkffayafZXOCDe4FP3bNgkXdkIknn2VqcPGMx4ex79U9uR6D4TTw1o7dDPO2RibfWUcz4RWkr5aqNtDstgFXW15u91z0lYx86iLFQglPgCImDpGOXAs xkifUEH4 3F4CR1wkgP6+EBQbKUKOmTTokkqYNQcWHXj8iAqA2Q703rNCATUDgbmOeHMWraWZOXMsXfg4ozK0ZYV25cOQXWHKxrOXzL0mgR8MhtMOHGRyIr5/RhO7vCpJeP5XIjd8LMvYHlySQPiwdegdxgEbFxt2I26sXJCx56LIFKSSqdU7zEFZkjM30PujGfcE8wgXYeqNa4AivCvwRYt0ySUigzqxi+Aixlsy30zDJG3XccuGXgBSs5xRsc9dfyEB66WvgMCWyb6+irHVEeBOI52KcfPUdbWU5Qgk7VJqOGN6RVnIgC46leltv/BGn/GJFhaegR8GDvoUfnYl1Ppiyh7DGTRq+9NI6HsOWzlXMXy4pLfQpsGqcumNYdcWRGzbRwqAL3+hOB3UppFb5plJ8wCj58DqbVVcfWtXojqQRal0C8icKSaSTTT5JzsPcsyzM/T+P8pfT81GQQ+R0bxncWdj++SoZzRIH2xVrPAQrlp39ULyCWdkT6Zszuw1GOnTOKKl4HjxbDtZxfdKlsRsBrYw7ZGii6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 10:37:22AM -0600, Martin Oliveira wrote: > The .page_mkwrite operator of kernfs just calls file_update_time(). > This is the same behaviour that the fault code does if .page_mkwrite is > not set. > > Furthermore, having the page_mkwrite() operator causes > writable_file_mapping_allowed() to fail due to > vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for > enabling P2PDMA over RDMA. > > There are no users of .page_mkwrite and no known valid use cases, so > just remove the .page_mkwrite from kernfs_ops and WARN_ON() if an mmap() > implementation sets .page_mkwrite. > > Co-developed-by: Logan Gunthorpe > Signed-off-by: Logan Gunthorpe > Signed-off-by: Martin Oliveira Acked-by: Greg Kroah-Hartman