From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22449C3271F for ; Thu, 4 Jul 2024 21:35:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8ED796B00B7; Thu, 4 Jul 2024 17:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 875DB6B00C5; Thu, 4 Jul 2024 17:35:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A0426B00C8; Thu, 4 Jul 2024 17:35:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 487B56B00B7 for ; Thu, 4 Jul 2024 17:35:03 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9724F16038A for ; Thu, 4 Jul 2024 21:35:02 +0000 (UTC) X-FDA: 82303375644.06.4AAC47F Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf10.hostedemail.com (Postfix) with ESMTP id 7F8C9C0009 for ; Thu, 4 Jul 2024 21:35:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=gUdkDthW; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf10.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720128882; a=rsa-sha256; cv=none; b=yFGR7eSE9MfvbN5K5mszippnYCwdaTxhCgtBxSqLdhL1c5YGbqzvtfuiewDSpsn4hQNi6v P5fR6nEjCZC+74qA5DrlEwDGW0MdeFIlVMJEceeEjWhAQ3zzi2/6j5o17glJ25fqPhBduA 91EA0HoY8LlPQwi9i5tR2dZ3Os/GLyI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=gUdkDthW; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf10.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720128882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4nqeguYiwGj4yC0V8xFrII7E3d9fSbG1e0CN7cOg21E=; b=0nhlgEVOudz+gjfAB43QnWtS4GddJziTuHvzKb6Gprvb7G4trUUJpoh1enjOK3AaXmA6rE zv3JZHSIZfherlj28RbW/Taz2fOD2hvpANcqCVjuJeNp161wZyJyfYfHiEgahroeNWo0Gr I9bagiqT62z5SXHBPLUDRv8ObIIQAzc= Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4WFVKq5gf3z9sSx; Thu, 4 Jul 2024 23:34:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1720128895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4nqeguYiwGj4yC0V8xFrII7E3d9fSbG1e0CN7cOg21E=; b=gUdkDthWvGQFlFIBRRacgtdXClnQSaAq4fqo2xjg7JgkJ2SfkAuEuxv/KugTqBwKuyMN92 V6TNoVnLfos+5Y9/xkfnpGHdt61pdeQQb99vEIrGLS1cnOJ3j6aOdv0Ly3MdWBnJWB/41r tD/SEuRnxAqtY7SKNTMHWFQ5YV9zp/j8e47jxsqK7ydxiE7WfWVDx3V659r02+PMbxV8a3 UJC7uIBr4avY42eljdlL7M+TUwQr6aIEfVym6ZZRuJoTfgnSiXqXVQUjdJ7eHayAnH6+GD ZXRiqxHqV1qGUDeH0BxAvaIoQb27NJA3oFQz9tfM8WWEIKLJ3Ey6T+fXwRuk3Q== Date: Thu, 4 Jul 2024 21:34:51 +0000 From: "Pankaj Raghav (Samsung)" To: Ryan Roberts Cc: david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v8 01/10] fs: Allow fine-grained control of folio sizes Message-ID: <20240704213451.y2oc2f6ie5wmhmcs@quentin> References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-2-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 7F8C9C0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3s3s966y5o3qbj6pnxt61gjgqywxek1f X-HE-Tag: 1720128900-926471 X-HE-Meta: U2FsdGVkX194wrm7XN78cBR4FsykgI0MRAiDeGEbzlCVZIh9+M0ydkE8I3j+LEnavZtpuz+ZxsmsmSm3+iOOhA+lvEJjseN/InPy0DvoGvhhonYc7BonaO2vp9jNeC8VZ13bAJpjsXQh5DvUfJ3iaNLHtXjv6KVpDJKPzNpO8YVlVxvOVK+mVpZGD0GXzbVPi75NQMUljr9+SOPR8ViFewBphOsTTqGwUO4Jgnd91d1s3CEIOnreq7V8rsai8Yn/OEiPZyTOlRB62bTrhp7hc9ZQ3M2JagVuAJr3VjbjHGljilcPfGSr7+4iKaEU+NMvUvyEkgSLxbce/En+yrTyU5x50aflKBh37CGs3o7mlZJZbPZ+slqGkyMH4W0fiyuWwfD4rYo++xR2XTkNWxRDhQSUpz5kiOjH8wBPSeiKhdyNNYf5HoNViA+/BLyIr5Oq1egKjcIpizV6XF5GuD1l2Q5/1wPnSl1xsz9FoGp3ohufA2O2DH3aYMbWxVEQOGeNBt9vl7lE2G1yQ94ZVs/jV4i16fMbC2PGtmNCenR+K0hOejwobJOWSn/sPm8XRSyMrFGTN4cwp0CeEK5uOyGsqUkTtCoBddy2Wmbx0Rw+z8qyRtiQtrw+SAHTKLTdiOF6ExOwFoha+cXYcxiIcc8w7vuSnhn1uvz/9kCJSVwvdr3HQC1/HFw1SravycdCrsKrC781FTfse0F6+0VNFqYy9otSrzIenlE6THVcWO9cJ8+/nMexuci+bW4TMsRfiCVNJpO4vQ2k1atVRy5aYWnOy+hOocaU/tqXWTozKFicTf35Dc39UQakhhcPXdrzp4hU6fAUWCgPnTPYueOWtIvqvoywgnKZhgVg0JtC0g4HuXJU20uMaChdlOEjBQTDbE2kKUT2gIPByG1Rpu/OLkz68bB7K3T+qhLHJ16y7uNEWVCuJJwtcipW5BoQrNxbCjG3dGuwJnUYbUQezSWUURP UnQ+Plhm OLrJXqMe9MgCdEkYwjY/luRD++ZsixjC6u9/wH4hWkEbn/bXa0LNAVx60cpHSvPCYBAQP6i+PuoFQ2V0U+rS9Wzo9O7JC5BXt9ZmlS5XTHd/y8avetRXU0EtlbKFVIk2H4nj6AKUtnAwbY3c9qjTwaiTw0edKBuOIon/6bkvXg8eigdPH7mbtqFhKto56k1LlA6e2r6XiMf7vY7nPDbWIkIb5ccQtoUuk9btntble64joWEum62iOhjP8uodCE8cDpRVRpSCR44rt3BivS2rn2LHIyWy3qglR7rFlU4rM2xQphz6T1NXenq+a4BkfY5NfxF6FraLlLRXMCBDfxpYuxbHxKiuRwjZh7zSZ4sirXdSXPw+PvQp/nXEJkAXauZo/UaY3tucXsgzf5jldjEgZf5zzk18FTAGn9NwzziCViDVsSKE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 01:23:20PM +0100, Ryan Roberts wrote: > Hi, > > Here are some drive-by review comments as I'm evaluating whether these patches > can help me with what I'm trying to do at > https://lore.kernel.org/linux-mm/20240215154059.2863126-1-ryan.roberts@arm.com/... Just FYI, I posted the 9th version[0] today before these comments landed and they do not your proposed changes. And it will also be better if you can put your comments in the latest version just to avoid fragmentation. :) [0]https://lore.kernel.org/linux-fsdevel/20240704112320.82104-1-kernel@pankajraghav.com/