From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132D9C30653 for ; Thu, 4 Jul 2024 16:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 996FF6B0093; Thu, 4 Jul 2024 12:39:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 946BD6B0095; Thu, 4 Jul 2024 12:39:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 799896B0096; Thu, 4 Jul 2024 12:39:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 59CB46B0093 for ; Thu, 4 Jul 2024 12:39:36 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2431F12141B for ; Thu, 4 Jul 2024 16:39:36 +0000 (UTC) X-FDA: 82302631152.03.7ECB3E5 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2128.outbound.protection.outlook.com [40.107.96.128]) by imf25.hostedemail.com (Postfix) with ESMTP id 42C29A0012 for ; Thu, 4 Jul 2024 16:39:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b="IMtTti/Y"; spf=pass (imf25.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.96.128 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com; dmarc=none; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720111160; a=rsa-sha256; cv=pass; b=DtqhOjqS+wdS8b8JcPU9AaWz1ewOYyKgjlQvpsxxFdty+pDncXS3WHClVmmOrFKTc96qvo x3VSj/JPRTRvQKJTcgkGDl9IFcq8+Ofwa8BPT0yIFf3EAl/gck0mTFiSPnkl6TLSNamEmg UIxTEEaJiCVH5NN2y7d3D9T+0AMkkos= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b="IMtTti/Y"; spf=pass (imf25.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.96.128 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com; dmarc=none; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720111160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E9xpThQSwDqFuSjjUacCMlYFqVz7Hv5d66nL0tsLOEM=; b=ywrnJQN1aHlFrrld+xFqv9wkbviFI2+N2XO/MzzhPTZhxN5GarDwK417JxF01i36pDKlwC 7R0xpxVYalGbrV6Npk7GWVz/mLmmlu9fvQV1P9Rwle1nR7fiuYT7YOXAqWLmbeIfprDI3r pBMi7wEkXOiDRym38wQNkY7m5GhehhE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aeH3sL8HcCzwy3oG7rxLA323cVqweH1WXvU26nrl0QhF8VPEZI/kEDqbgwYEsoPKXDX9m/VECYUSXXHRq3E7tByyYvUuOrdh/BvfaQikq5nmzKiLxxYfdJc1utOjMG3fxkGvwWvnq4PzslIi2dq5lg8aOQhss7yBAJdkv0fI9jWmDOVgWNI8Q+5pUkDBUSosQg26hNl7yOt7fZtEnXVuH+dju2r01Al1ioNwuBaR3Hhz0e/yNdBGA2l2jcN74iIJxAWynZzreIQK+mOeZrwnOfCuJDe15EbuaqgEyfqw+nPLSk+VC0KT6jzPjL//HH8ASkoVeVZ9rOrihtUGcbOj4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E9xpThQSwDqFuSjjUacCMlYFqVz7Hv5d66nL0tsLOEM=; b=UMSfxblBFOQNczrUnTON/iLCbVawFCTYInaqNR311rTD07nICPqFBEPUnwgI9q11vt1Urqq//wf6L1QOSW4qQ5z7icpVi8uEfgexCal1y9OJxpXgL6uzUpIzyv9U6H36I2SwocIeWqRZP+ykTD+Y+ZxZPLL6zgdjNbOs4+7sQWRg78vDyvSgQbo2EEFTH17lvSBm4jMXGLYvrtUc164xjP7n73ruL4jHTRtWyMwzlU+hznaYt0jkHSgxdhT8+gJf5dR88pTyPlSdPwpUuG8SJCP4jY8iKudrLFkAX+cylN8JzNGDGR+NC8B5J2nio5pRXeT8aSN8mXzYNUxa0tZPyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eideticom.com; dmarc=pass action=none header.from=eideticom.com; dkim=pass header.d=eideticom.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eideticcom.onmicrosoft.com; s=selector2-eideticcom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9xpThQSwDqFuSjjUacCMlYFqVz7Hv5d66nL0tsLOEM=; b=IMtTti/Y+8cKQwOWumy3CbRSLFo1b1VI3gUFVdazkZDkm3+8ALaFrLDTepkRvrPA21XYiOYmq8ejcdpmophHyRuSGW3HNJVcoM9maaN19FMbykLErto+dqauWwsw+sVS+XTztD3Waf5f74UMFh3AIJkT9ts+BopNC66riiX43ZM= Received: from MW3PR19MB4250.namprd19.prod.outlook.com (2603:10b6:303:46::16) by CH0PR19MB7850.namprd19.prod.outlook.com (2603:10b6:610:189::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.29; Thu, 4 Jul 2024 16:37:50 +0000 Received: from MW3PR19MB4250.namprd19.prod.outlook.com ([fe80::3280:d8d:de43:6376]) by MW3PR19MB4250.namprd19.prod.outlook.com ([fe80::3280:d8d:de43:6376%5]) with mapi id 15.20.7741.029; Thu, 4 Jul 2024 16:37:50 +0000 From: Martin Oliveira To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org Cc: Andrew Morton , Artemy Kovalyov , Greg Kroah-Hartman , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Martin Oliveira , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: [PATCH v3 1/3] kernfs: remove page_mkwrite() from vm_operations_struct Date: Thu, 4 Jul 2024 10:37:22 -0600 Message-Id: <20240704163724.2462161-2-martin.oliveira@eideticom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240704163724.2462161-1-martin.oliveira@eideticom.com> References: <20240704163724.2462161-1-martin.oliveira@eideticom.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR03CA0078.namprd03.prod.outlook.com (2603:10b6:303:b6::23) To MW3PR19MB4250.namprd19.prod.outlook.com (2603:10b6:303:46::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR19MB4250:EE_|CH0PR19MB7850:EE_ X-MS-Office365-Filtering-Correlation-Id: aa1941cb-f20c-4244-6de9-08dc9c47a4e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9rAnHPmSAkso4hCx28EN/Hx1gNvOBuM0trrl5Y+AK7ldriGdsa2ZZ0gh5efh?= =?us-ascii?Q?YhYRX663DSrSinDajt0dtykDd+l6wgbx0gLduq0I01Ye3kRYmCnVtMyA7qFa?= =?us-ascii?Q?zUVcmSbUk3bauF4/KwT7VROpANM3/HXLjoAYKep/4Q09TkIG6oawpCcKEtAG?= =?us-ascii?Q?U5GJtRLgBa5LCLdfDCq51tsLDmL0CfNRsWLAGlDRHMQPLT5u3uH3PEt8QJTF?= =?us-ascii?Q?6HUHQymqssd47dkMAv+iQxzXrUKtpfT2fAo4XJXhT59BCTXt3YUpW6zuLRQ0?= =?us-ascii?Q?YpxKnQdjKwcURXyCA0wL9OlnjlukfuOimmd4kUNraLYNAJwqkm8vIwm5MGvk?= =?us-ascii?Q?n9diX29QPdI5aJ3/W04oliHTkyLJow/cAtWnBFVl68158ZJS4o/Vokr3MQkJ?= =?us-ascii?Q?VEPnWE6Okkr3ntmAO4GEwBWhpjY+M4HAFip14vBq+397q/PPnheQ+vajcroo?= =?us-ascii?Q?1pC0W6by5AJw5u8mOC6zRI9YIShDBmsZm5M/kPxl9xfJ6e/uGE3aIOCi8S3Q?= =?us-ascii?Q?mxp+K2EDP1bwnlBY8znuut/UMOoF8f6FjbCHWQozLHcqs5REVrsZiVRs2zuU?= =?us-ascii?Q?yYolWdDn4sBLT2y1OUyt6PmYDK5+wMyKikwhRz0rQEp1+5MXoq48DpuQCI+/?= =?us-ascii?Q?nOZJNzhefxqT1lgCjMEDzQ+c1JSCziFZsIL9joLiO1IdQj+wSIzHi0mlU7Nl?= =?us-ascii?Q?qMhSaGQj0MjuWQ9wKhOR4Xl9SXToD1a3pZwIRlr1YN5xKQjBERFT5uidZ7LF?= =?us-ascii?Q?G3PU6gAIVaXdFX2HM//saJ1Mgy+vzgBV5WBKacqsTg45O1gWw5qt/PznESQc?= =?us-ascii?Q?m9s+rvVAylf9wLkRJBbfy1JJ4m7K/6oRilJovNdlMUfZV+sOcJaV8RPK2ll+?= =?us-ascii?Q?fdyA8rTQE3a6HZpq+1a6ZLpueXYzsZQRPEZtbQNGLQHHI4pFpDOoJWyckmsk?= =?us-ascii?Q?/KZzwuU/dMLooL+1WdsJ/HZSr6eUjYpalb7ZfAYyflDgNjK9xwyW0C2e45T2?= =?us-ascii?Q?f8xopdvB6QfFKuZzBVScHIJeeAkpNpX6qAQqLcDVQ6cNA+365J3Xn9MRiicd?= =?us-ascii?Q?5OLUGkcp+HK9HVt9svVt/OkxN2UJNC7jGuxgIPW4SixoXM4UxfNd4K/HA+Py?= =?us-ascii?Q?eQrKLRmrGjl4SnOlQHteD+vcbcb9H3HmS2eUSDfyPhxCCc2xg/yhd7/RBeM1?= =?us-ascii?Q?4LGQViKqPTKGpjzr3Iq7LQnHa/QENCVTYUcTLIxTO5rN7piQJuTbnyXfFAI/?= =?us-ascii?Q?pTcE4SP/kgwtsCdwPIlZIixUoxzviOo53hEXDspxhgOAdDl8kKvoSYSTA0K+?= =?us-ascii?Q?SO2TR/PbCmlg5jha6UHj3D5jHqz8ozaqRyLC9mPmLi5NJ13qyfOOAAj2QX/A?= =?us-ascii?Q?4c8inQh/RD/KOGm0p99TAZvEQBBjD9KKD/iN1ZFgbW2TxtZu2Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR19MB4250.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WbIwduU3K4nMudLaU7AXM37nBdEo1iSfo74SW9DvXzr6djZS6tXi5b8ddwxc?= =?us-ascii?Q?hfhnvqZ1KZIcjzKbmhYQ9UwPf8aGeSWm/f7ap1BaXrc49NUjPl7DbbFwIO81?= =?us-ascii?Q?NmQe+++XX74IpRyI8mBE+jLgjgM99oJ+7cFj6p/aeVUIifWfPxbsOQnFyP4/?= =?us-ascii?Q?+jihjOiI4ziLVYv1eLk18Ee8grgGnET1zlzvrUcMTPnOp48TLNANFE3DlLpj?= =?us-ascii?Q?pdPcA1zEgv8aNsHZILNIw758dLX33yd3NAcIzk4mgUvy77w9NJnKLpV/MLqb?= =?us-ascii?Q?bCO1cCPhG/Urbte/yVOL7iQn17GiICBseukY/+zeygk8dOVEohSYVUAit3Lr?= =?us-ascii?Q?aBeyfeLFhnnS3hyNeKwpMA6VhARkFznL/8icUXJ0qjTUExdoCLyPTWTyCTdI?= =?us-ascii?Q?0o8EgvypeuIZ9JzN9BFKDtyFO1v17pbFEzYrQ7y0M0VyPC7mUOmALKE5FQaz?= =?us-ascii?Q?fEpeD+tHOUT0lHGL2W7UcEp30r46wQaG+9W100be90MjA35uIUzj9sCqRZbH?= =?us-ascii?Q?9RONsJ6TtCGHq031ZmTIiTrnYZnHCjXLcy/kbZcE6LFVyMXc7cePS70uxowQ?= =?us-ascii?Q?apPwF66s23FTG9NqM5Pfy6xBWuMCxauFN0f9zzTFnzkoUHdJsWhGP9UwW992?= =?us-ascii?Q?SarFh6ydXjnuD1t0PxDcjGIqyLewjfKETYKhCEOANm6eMaH4Kj7chOu11Pj1?= =?us-ascii?Q?RBqoqExs4qQSkZm12fRMGD8Ypek6KtzHO5ye7rANSkT9I8hWDTGix19B1f1L?= =?us-ascii?Q?92f0BxkIYfuzS7RxMN+o/LIY5wHaFtyNGYlhcbtI/0rBDQZz55GnVr0nvtcI?= =?us-ascii?Q?XdNbrBl2W14dg/uUulZ9xo7zrKQiNBoqvZHdrMlZVetolNcflefwQOkapsYe?= =?us-ascii?Q?XKAi0ojvekyQbic86YoYEGIv5Q8haGkm5OLVMbBwihtEcSnJth2x4XiWo2aM?= =?us-ascii?Q?NQJT2CyAg19aK7Cjka86hApVCGVdftt+8+55EoszozTd9LE4hJ02sVXviyyX?= =?us-ascii?Q?6rB1MuF8iqvlzbaCp5cTGVV3xOIIx4Mbka16ObXLUlK6ESmAJRdqD1h+0UGI?= =?us-ascii?Q?1qvcMkzDQ8rT4oUD+z3riKycsG2srE//qhzi90NpOU3hhK+h5WtgYk1qElLL?= =?us-ascii?Q?klO40qvo5jivy9D1wtlGHlUulCJMQoYPxcGbvvvJh5m9Fc+3jLdeaRltj/lE?= =?us-ascii?Q?C/M4u2P+qetDLHqicgFTSj59nn1AkPRCBuLgIHIjeAKoIoxmQQe7hfvh6iD6?= =?us-ascii?Q?FJLucBZ5+knOy/kQ/6mIrNQ6zWTsnUOOlqR9ASHEsOJu1Fp4kuc0fBAt08JO?= =?us-ascii?Q?kIYARaDYcAQus9KdhZRBiF87442MYTf1RCOKRJVwh2a2kSxUwDFj3cbxzqc1?= =?us-ascii?Q?LGrnYlsLvmHmaAzEt06t7xk066K5g/xjY1cmUnnAlHSYxq0ASRb7nY9jHQSU?= =?us-ascii?Q?p6SA9efhB4t03O0pGFTrXZPJGksxzwFatVOB6ipMyzySMsaEqTrtVxoT628N?= =?us-ascii?Q?ZjpvdRaO1WzsUOUXB/mxr8IXWwCjvmwgbm/7Wstm/ay5sG7sZU4faxEgwXM8?= =?us-ascii?Q?zr7GnZz4kvOU/ozjAtRHxe5EgnVlQJLBUO344MsLYBgXScNy/xBHoAwS3fzm?= =?us-ascii?Q?fA=3D=3D?= X-OriginatorOrg: eideticom.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa1941cb-f20c-4244-6de9-08dc9c47a4e8 X-MS-Exchange-CrossTenant-AuthSource: MW3PR19MB4250.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2024 16:37:50.4367 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XBHSmtUXiIhMZbKA7esjKytTNhJro+xd4W9ZeP8ibduQCAZ0x/iXadR+5O+YBGgqHKQt6iMmYjbeoMqhJuBAzhw95y3+iv/hMmRFgyCSJ8c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR19MB7850 X-Stat-Signature: s8o1iejycq19ognm8w9nak5o6n7btaow X-Rspamd-Queue-Id: 42C29A0012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720111172-16883 X-HE-Meta: U2FsdGVkX1/8YDeBURNwQ91GdclxEW3y3youz/GrqfJe3AtIkWY8Yr1cRRF+S2HxC3JhNXSUlOYCJSJNvePoqSMcolxUbvPY91xVFRbRjVGSwPxOn3a8Oy7oNyxGx3osBrMyRqtRp8CwsNdlLNVMD2E+YilN6MF/sY6pGm4RCRv9eX75d4N1rryXwlhZDtAyUy2IWG9UdtFrmC7EpkAGv+sDQIShV4iOoJ+hzAhEvn8y4S/6GqRKeBOQXbbMOz/TY33cwvOz0PDQbKGWah+H++edcEDH6C4RHzO/i3fItPvb5ia3vNkH0RPxFB/jehhr+Ontgh3ENlsFntvVytQ1ZjUa4RcMZCkHLav5538QIYENRMJT0DtTQUDH9/AOsxBZ4/60B+RvyXuq+Oe1OUSEznqmuG4vlHoTI/kTQbXfuQol3fbbqNJEiqWstVJO15KtetKJzOEbdw3E/BTe5qGN8OwreLnBy7wt0OjuVFLhrEcTRfYTDAIEWrHSLcjnEAAB/koAdUsj8PGlzGjcNbxu0B6gUbIkhAFszjGA+OUR/ACEYN5z9WZjXZugbmtJoS3F0qRbDUR1WtxzbK2lEAkb2FvOQGhhnbipLf/bv5E4Tu/yD69c0f0K1PHZR7iSlzZbBB/xDbsBr9kxK4A/jsAF4Vdz6dx/U7wMXQwVZlfBb/c3h5muPJap8MKb/rhbmydKSHkWBDa5twzUjtfd/sxi21ts5RhrUQDoBIUFOcEYe+Bdx4HVD3do7ODmLrUuM41utl1ZGUuyfkRpBZSLf8yvKvN9ztIvTdPPu0jHHAISpP4UTfoUsKEo1it9AO4H5LcCm0ZHMJOerQNPL735Y/3lq8+7NkPONV3NIR9pU4L/6fmUwuby49aBcwYW0cTsuJdgBy+vOcDJowNeF8jt4oSxKxuYNGfBqH29+f8s3L9epOIrlZx0dr85FI8GCBL+cqr82Ev2zWQytq+05SkKiid AEo+xQnD 4b/Oawy86Tuwtfkc+xznxjQ5W3mb5QTXsNKeojClBFVgLWUqwCcA/rDybpUOr0Y6pzZhAyoj2R649bTe3KNY9RRD4DJh3NcvhL3iTMEfYftZiIvMH5PV35z1RjTpEoJqhLy/6ZkAT1DDM+x36JCHPocnfGJJDSBtVWlVnws3UvmQD+GmmJNQDa7pRLVchxJcR+1mKdNKW1beLKPTERYF+u/OFg0Ap/xSibo07Dp+UKfcsFKRr86aVDTvbXJQoB2dyw+m5Zunw405PlBN7dOQEN6N/vjE0LjPVNWymNzE+A/gzVSR/IjVECjcHiG8hVa9XRCnnAhgi94Ma5lMYyg7Q2k2Xy21DI8FIGqbMqBEfft37fUkKdDcrHBKs40j3lO5+FZ1/5OuZoog7DsmZM5ZrYypfjWCy6iFT8KQNBWgm7iOijX8nTe6t8qy2iEwQ5k6YKvzxf4mWRMkXeuuR57xxWT3SlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The .page_mkwrite operator of kernfs just calls file_update_time(). This is the same behaviour that the fault code does if .page_mkwrite is not set. Furthermore, having the page_mkwrite() operator causes writable_file_mapping_allowed() to fail due to vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for enabling P2PDMA over RDMA. There are no users of .page_mkwrite and no known valid use cases, so just remove the .page_mkwrite from kernfs_ops and WARN_ON() if an mmap() implementation sets .page_mkwrite. Co-developed-by: Logan Gunthorpe Signed-off-by: Logan Gunthorpe Signed-off-by: Martin Oliveira --- fs/kernfs/file.c | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c index 8502ef68459b..90603664de7f 100644 --- a/fs/kernfs/file.c +++ b/fs/kernfs/file.c @@ -386,28 +386,6 @@ static vm_fault_t kernfs_vma_fault(struct vm_fault *vmf) return ret; } -static vm_fault_t kernfs_vma_page_mkwrite(struct vm_fault *vmf) -{ - struct file *file = vmf->vma->vm_file; - struct kernfs_open_file *of = kernfs_of(file); - vm_fault_t ret; - - if (!of->vm_ops) - return VM_FAULT_SIGBUS; - - if (!kernfs_get_active(of->kn)) - return VM_FAULT_SIGBUS; - - ret = 0; - if (of->vm_ops->page_mkwrite) - ret = of->vm_ops->page_mkwrite(vmf); - else - file_update_time(file); - - kernfs_put_active(of->kn); - return ret; -} - static int kernfs_vma_access(struct vm_area_struct *vma, unsigned long addr, void *buf, int len, int write) { @@ -432,7 +410,6 @@ static int kernfs_vma_access(struct vm_area_struct *vma, unsigned long addr, static const struct vm_operations_struct kernfs_vm_ops = { .open = kernfs_vma_open, .fault = kernfs_vma_fault, - .page_mkwrite = kernfs_vma_page_mkwrite, .access = kernfs_vma_access, }; @@ -482,6 +459,8 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma) if (vma->vm_ops && vma->vm_ops->close) goto out_put; + WARN_ON(vma->vm_ops && vma->vm_ops->page_mkwrite); + rc = 0; if (!of->mmapped) { of->mmapped = true; -- 2.34.1