From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C7A3C30653 for ; Thu, 4 Jul 2024 23:35:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01EC46B009B; Thu, 4 Jul 2024 19:35:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F10D46B009C; Thu, 4 Jul 2024 19:35:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9DD46B00A0; Thu, 4 Jul 2024 19:35:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B9DB96B009B for ; Thu, 4 Jul 2024 19:35:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6A74B12104E for ; Thu, 4 Jul 2024 23:35:38 +0000 (UTC) X-FDA: 82303679556.25.80B631A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id B57C580004 for ; Thu, 4 Jul 2024 23:35:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PuxhPCAB; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720136124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P+xZMPTpbwaq/Uc0fZfjZcVzWiuEMR1xD31bnDJ3q24=; b=CkS6peEG9ScoZ6axQWejx1Po2A4fr9XvkHBLT/FRzIwLhIT4d86PT5HpJYU+NQl+12b55f yOUyyRdSOUpEwejZ0YmFWDKeh701V4qCT3sgSCruFvd0wfjk26PXez9gHMbWSc7/zE8d+M 9Bd9bFF16Hsl5146I4pP3e0cwSjZhmE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PuxhPCAB; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720136124; a=rsa-sha256; cv=none; b=e0nva0c6zhoTY1fr2lnjMxdrbxfm+Ryh4m4qWTSv7Qtlqxf/LBKI1N5Sr0zOJ9ML9C87Cs eOKr5Naa5z2yA92wdusedAqedH/J/O+BaTgjGyybmCaicV47STXwDNe5iQWimWT7Iozlly xxUjslvHh/T+KpcGxglOcOXJemY/7qA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B4941627D2; Thu, 4 Jul 2024 23:35:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29C85C3277B; Thu, 4 Jul 2024 23:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1720136135; bh=5JFAhc6aB5DXVBgfQpgN4i9vJyrF0WBFHXGt5PUEP9w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PuxhPCAB1OHAVni0Df2SLIVNfWo85uIVfxxMmPu81GiGnXfe7EXvXLd1rRwwNfMtj meClQmWP92REbLF7+5MFzQt/Va4r3KtcxOBMJThYeiMzzD2PP8tmEYhD0GkfKdWbIq R4bYp+ZJBcki2BPmFt28Iqa8u/sykSQG+NxYLz30= Date: Thu, 4 Jul 2024 16:35:34 -0700 From: Andrew Morton To: Shakeel Butt Cc: Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Subject: Re: [PATCH v1 6/9] mm: memcg: put memcg1-specific struct mem_cgroup's members under CONFIG_MEMCG_V1 Message-Id: <20240704163534.e82b0d4108ab70319781d6a9@linux-foundation.org> In-Reply-To: References: <20240628210317.272856-1-roman.gushchin@linux.dev> <20240628210317.272856-7-roman.gushchin@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B57C580004 X-Stat-Signature: edkqpz4my5jwj7uo3ya15nrtxgumu8pp X-HE-Tag: 1720136136-667607 X-HE-Meta: U2FsdGVkX19pcuyauyYMVt+k2/xi9Sq+uxiB5Z0IrKKWduZvAcA8ddkzIdlj2wUVrGqBMoFdw+vXX2a3btcgJOyWGU3jdcIOy6thoFUe3vcIcZucKcIcZG+52idyk9mNFNNikT1H86KVhUmZ2tMRbiOEiIrMQQ0/ig8mtqfEpSnduGdOwuRPZ5cLNTMMbfbRXpFB71gA90MKfu54IbbGE2h5pFMxg3t2of44wR35SeidMU1lkMbr1f75urZpU2rMGfaMBDeY5ZWRe4t6RbamH3blsidJk9GGIZGJdAtOPXx8pvTxlVyAX9mpTKkQJCt/TkpD6NCOhZgClFlXxUnz/gIHxzapyJv1dujpy7uKCGhqUErvEAo93de1G1ctJyPG6eoBzkqJbSK1vY+GTNLhMu2qr8xmKkJjaNBaRPbALPg16fCu4nThKvgC13cEX2JpvZqxhidnUxyX+xMoUWESpiQs70oZPpNdW9+2QGSt6rCqM3CdjcCgh5fIi0RVJeyUEVsJSNFRz+PV2rCpXIXkQX010AZfnTIPUgTDPqaEywtzb0lQ/MKBENUkhrl1RFjc7enGLMN2kHHZ9Jh903zwg8zcyAByvUVO4WVnIVPpYy9/BYkBkyOfbRwfz/olhUy+CS+sj1AQD2McHMG1J0eC7C6ix0YPgHjl2MWLiNZFt5MVncOptHmgc52mVdEKR5F4tTWLqrkO7iO6Pkf1y3Uh7AYaD1y8up58w3RzCxhFbD8mR2odlDlvpFBriD2YW2TZu0mAEdKSxUdHNCbqJEV+DWMDD6d4LCAFHVdmslbAO22BUpvT7RLMKdnr2erUDm+ZHfPbjqsbAG3QTwcJRv2dYwQL/PxyzANiMbzt55LE1B1hvr8bPFR/TawLUCcahy7BLdoep+BmoJ973zYOrZAaG0IuWvwIb/jXFolSTe/RmOoZOyiwIGbrQm881dqLcjW9oFceqraTHXLWHv1215l C//6d/fB 5lue4OA661mC7fkzTdDNQM80wxLywtIsXs0BNUt9wd0Z2qTelMGDPLQPKWBsL7aCzCdvOxgBNzKy+/HJM0XzJYQ4xZo1p/j1NfxsT51HCF00ggnihkxrG3dv81mo0ttbJlxzptJgx6k74gEyrfExSMraggDkQeg/8XiA6y9ymAZZAPAIudAD+hb0h5E7TkrF8zuxLV+Xith30Roirr1FDGopY759a7rtTqukypE9inkUUgkqamHvmxa1VT+IJ87H277mXGRYGjrmCubwB+xVgM27zwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 28 Jun 2024 17:48:54 -0700 Shakeel Butt wrote: > > - /* For oom notifier event fd */ > > - struct list_head oom_notify; > > - > > - /* > > - * Should we move charges of a task when a task is moved into this > > - * mem_cgroup ? And what type of charges should we move ? > > - */ > > - unsigned long move_charge_at_immigrate; > > - /* taken only while moving_account > 0 */ > > - spinlock_t move_lock; > > - unsigned long move_lock_flags; > > - > > CACHELINE_PADDING(_pad1_); > > Let's also remove these _pad1_ and also _pad2_ as well as this > rearrangement nullifies the reasons behind these paddings. We need to > run some perf benchmarks to identify the newer false cache sharing > ields. I guess this is going to be a followup patch (please).